mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-22 16:10:40 +07:00
fix(i18n): resolve bilingual data through a pure field() helper
useField and useFieldArray were hooks called from inside .map() callbacks - 11 rules-of-hooks errors. field(lang, value, valueEn) is a plain function, so the same selection is legal in a callback, with lang read once at component top level. One helper covers scalar and array values because both need the same lockstep rule. resolvedTheme is now theme directly: resolveTheme() was an identity helper left behind by the removed system variant.
This commit is contained in:
1 parent
df65f4c774
commit
29a884fd4d
12 files changed
+46
-53
No files matched your search
@@ -0,0 +1,14 @@
|
||||
import type { Language } from '@/types'
|
||||
|
||||
/**
|
||||
* Select one value from a bilingual pair. Plain function, not a hook: `lang` is
|
||||
* read once at component top level with `useLanguage()`, so `field` is safe
|
||||
* inside `.map()` callbacks.
|
||||
*
|
||||
* Convention: `value` is the Vietnamese value, `valueEn` the English one. When a
|
||||
* pair has no English variant yet, `valueEn` is undefined and both languages
|
||||
* render `value`.
|
||||
*/
|
||||
export function field<T>(lang: Language, value: T, valueEn: T | undefined): T {
|
||||
return lang === 'vi' ? value : (valueEn ?? value)
|
||||
}
|
||||
@@ -1,17 +0,0 @@
|
||||
import { useLanguage } from '@/hooks/useLanguage'
|
||||
|
||||
/**
|
||||
* React hook: select field by language. Must be called at component top level.
|
||||
*/
|
||||
export function useField<T>(value: T, valueEn: T | undefined): T {
|
||||
const { lang } = useLanguage()
|
||||
return lang === 'vi' ? value : (valueEn ?? value)
|
||||
}
|
||||
|
||||
/**
|
||||
* React hook: select array field by language. Must be called at component top level.
|
||||
*/
|
||||
export function useFieldArray<T>(value: T[], valueEn: T[] | undefined): T[] {
|
||||
const { lang } = useLanguage()
|
||||
return lang === 'vi' ? value : (valueEn ?? value)
|
||||
}
|
||||
Reference in new issue
Block a user