mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-22 16:10:40 +07:00
fix(i18n): complete phase 1 - translate section tags, replace lang checks, dedup download component
- Replace hardcoded SectionHeading tags with i18n strings (7 files) - Replace 17 lang === 'vi' checks with useField/useFieldArray hooks - Extract shared DownloadResumeDropdown component (Hero + DownloadResume) - Move langLabels to src/data/resume.ts as resumeLanguageLabels - Update feedback docs with resolution status
This commit is contained in:
1 parent
72a832c781
commit
4996a91a77
15 files changed
+489
-158
No files matched your search
@@ -0,0 +1,236 @@
|
||||
# i18n Phase 1 — Action Items
|
||||
|
||||
## P1: Hardcoded Section Heading Tags
|
||||
|
||||
**Impact:** Section number tags không được dịch khi chuyển language. Người dùng tiếng Việt vẫn thấy "About", "Expertise", "Experience", "Projects", "Engineering" thay vì bản dịch.
|
||||
|
||||
**Pattern cần dùng:**
|
||||
```tsx
|
||||
// spec-v3-i18n.md:347-355
|
||||
<SectionHeading title={strings.XXX.heading[lang]} tag={`01 - ${strings.XXX.heading[lang]}`} />
|
||||
```
|
||||
|
||||
### Files cần fix
|
||||
|
||||
| File | Dòng | Current | Fix |
|
||||
|---|---|---|---|
|
||||
| `src/components/sections/About.tsx` | 13 | `tag="01 - About"` | `tag={strings.about.heading[lang]}` |
|
||||
| `src/components/sections/Expertise.tsx` | 26 | `tag="02 - Expertise"` | `tag={strings.expertise.heading[lang]}` |
|
||||
| `src/components/sections/Experience.tsx` | 26 | `tag="03 - Experience"` | `tag={strings.experience.heading[lang]}` |
|
||||
| `src/components/sections/Projects.tsx` | 32 | `tag="04 - Projects"` | `tag={strings.projects.featured[lang]}` |
|
||||
| `src/pages/ProjectsListPage.tsx` | 13 | `tag="04 - Projects"` | `tag={strings.projects.all[lang]}` |
|
||||
| `src/pages/AboutPage.tsx` | 19 | `tag="About"` | `tag={strings.about.heading[lang]}` |
|
||||
| `src/pages/EngineeringPage.tsx` | 12 | `tag="Engineering"` | `tag={strings.engineering.heading[lang]}` |
|
||||
|
||||
### Đã đúng (reference)
|
||||
|
||||
| File | Dòng | Code |
|
||||
|---|---|---|
|
||||
| `src/components/sections/Contact.tsx` | 23 | `tag={\`06 - ${strings.common.contactTag[lang]}\`}` |
|
||||
| `src/pages/ExperiencePage.tsx` | 10 | `tag={strings.common.experienceTag[lang]}` |
|
||||
|
||||
---
|
||||
|
||||
## P1: Hardcoded Language Checks (`lang === 'vi'`)
|
||||
|
||||
**Impact:** 17 occurrences của inline conditional language check — duplicated logic, khó maintain khi thêm language mới, vi phạm DRY.
|
||||
|
||||
**Pattern cần dùng:** `useField()` hook (đã tồn tại tại `src/i18n/useField.ts`)
|
||||
```tsx
|
||||
import { useField } from '@/i18n/useField'
|
||||
|
||||
// Single value:
|
||||
{useField(value, valueEn)}
|
||||
|
||||
// Array value:
|
||||
{useFieldArray(arr, arrEn).map(item => ...)}
|
||||
```
|
||||
|
||||
### Files cần fix
|
||||
|
||||
#### `src/components/sections/Expertise.tsx`
|
||||
|
||||
| Dòng | Current | Fix |
|
||||
|---|---|---|
|
||||
| 43 | `{lang === 'vi' ? group.title : group.titleEn}` | `{useField(group.title, group.titleEn)}` |
|
||||
|
||||
**Note:** Cần thêm `import { useField } from '@/i18n/useField'`.
|
||||
|
||||
#### `src/components/sections/Experience.tsx`
|
||||
|
||||
| Dòng | Current | Fix |
|
||||
|---|---|---|
|
||||
| 46 | `{lang === 'vi' ? exp.title : exp.titleEn}` | `{useField(exp.title, exp.titleEn)}` |
|
||||
| 54 | `{lang === 'vi' ? exp.responsibilities : exp.responsibilitiesEn ?? []}.map(...)` | `{useFieldArray(exp.responsibilities, exp.responsibilitiesEn).map(...)}` |
|
||||
| 64 | `{lang === 'vi' ? achievement.context : achievement.contextEn}` | `{useField(achievement.context, achievement.contextEn)}` |
|
||||
| 73 | `{lang === 'vi' ? achievement.impact : achievement.impactEn}` | `{useField(achievement.impact, achievement.impactEn)}` |
|
||||
|
||||
**Note:** Cần thêm `import { useField, useFieldArray } from '@/i18n/useField'`.
|
||||
|
||||
#### `src/components/sections/Projects.tsx`
|
||||
|
||||
| Dòng | Current | Fix |
|
||||
|---|---|---|
|
||||
| 63 | `{lang === 'vi' ? project.summary : project.summaryEn}` | `{useField(project.summary, project.summaryEn)}` |
|
||||
|
||||
**Note:** Cần thêm `import { useField } from '@/i18n/useField'`.
|
||||
|
||||
#### `src/pages/AboutPage.tsx`
|
||||
|
||||
| Dòng | Current | Fix |
|
||||
|---|---|---|
|
||||
| 62 | `{lang === 'vi' ? group.title : group.titleEn}` | `{useField(group.title, group.titleEn)}` |
|
||||
|
||||
**Note:** File đã có `import { useField }` nhưng chỉ dùng cho bio. Cần thêm cho expertise section.
|
||||
|
||||
#### `src/pages/ExperiencePage.tsx`
|
||||
|
||||
| Dòng | Current | Fix |
|
||||
|---|---|---|
|
||||
| 16 | `{lang === 'vi' ? exp.title : exp.titleEn}` | `{useField(exp.title, exp.titleEn)}` |
|
||||
| 24 | `{lang === 'vi' ? exp.responsibilities : exp.responsibilitiesEn ?? []}.map(...)` | `{useFieldArray(exp.responsibilities, exp.responsibilitiesEn).map(...)}` |
|
||||
| 31 | `{lang === 'vi' ? achievement.context : achievement.contextEn}` | `{useField(achievement.context, achievement.contextEn)}` |
|
||||
| 33 | `{lang === 'vi' ? achievement.impact : achievement.impactEn}` | `{useField(achievement.impact, achievement.impactEn)}` |
|
||||
|
||||
**Note:** Cần thêm `import { useField, useFieldArray } from '@/i18n/useField'`.
|
||||
|
||||
#### `src/pages/ProjectDetailPage.tsx`
|
||||
|
||||
| Dòng | Current | Fix |
|
||||
|---|---|---|
|
||||
| 37 | `{lang === 'vi' ? project.summary : project.summaryEn}` | `{useField(project.summary, project.summaryEn)}` |
|
||||
| 72 | `{lang === 'vi' ? section.title : section.titleEn}` | `{useField(section.title, section.titleEn)}` |
|
||||
| 73 | `{lang === 'vi' ? section.content : section.contentEn}` | `{useField(section.content, section.contentEn)}` |
|
||||
|
||||
**Note:** Cần thêm `import { useField } from '@/i18n/useField'`.
|
||||
|
||||
#### `src/pages/ProjectsListPage.tsx`
|
||||
|
||||
| Dòng | Current | Fix |
|
||||
|---|---|---|
|
||||
| 27 | `{lang === 'vi' ? project.summary : project.summaryEn}` | `{useField(project.summary, project.summaryEn)}` |
|
||||
|
||||
**Note:** Cần thêm `import { useField } from '@/i18n/useField'`.
|
||||
|
||||
---
|
||||
|
||||
## P2: Duplicate DownloadResume Dropdown Logic
|
||||
|
||||
**Impact:** ~120 dòng logic duplicate giữa `Hero.tsx` và `DownloadResume.tsx` — diverge risk cao, khó fix bug ở 2 nơi.
|
||||
|
||||
### Current state
|
||||
|
||||
| Aspect | `Hero.tsx:13-72` | `DownloadResume.tsx:41-99` |
|
||||
|---|---|---|
|
||||
| Component name | `HeroDownloadDropdown` | `DownloadDropdown` |
|
||||
| `langLabels` | Defined locally (line 9-12) | Defined locally (line 7-10) |
|
||||
| Click-outside | `useEffect` + `document.addEventListener` (line 18-31) | `useEffect` + `document.addEventListener` (line 46-59) |
|
||||
| Lazer wrapper | Yes (`download-resume-shared-wrapper` → `lazer-wrapper` → `lazer-border` → `lazer-glow` → `lazer-inner`) | Same structure |
|
||||
| Button content | `resumeDownload[lang]` + chevron SVG | `resumeDownload[lang]` + chevron SVG |
|
||||
| Options | `resumeLanguages.map(lang => <a href={resumeUrlFor(lang)} download target="_blank">)` | `resumeLanguages.map(lang => <a href={resumeUrlFor(lang)} download>)` |
|
||||
| Extra | `hero-download-dropdown`, `hero-download-summary` CSS classes | — |
|
||||
| Export | `HeroDownloadDropdown` (internal to Hero.tsx) | `DownloadResume` (exported, used in Contact.tsx, ContactPage.tsx) |
|
||||
|
||||
### Khác biệt duy nhất
|
||||
|
||||
1. **Hero variant** có lazer border wrapper + custom CSS classes (`hero-download-dropdown`, `hero-download-summary`)
|
||||
2. **Hero variant** dùng `target="_blank"` trên download links
|
||||
3. **DownloadResume variant** có `DownloadButton` fallback component cho single-language case (line 12-39)
|
||||
|
||||
### Đề xuất fix
|
||||
|
||||
Extract thành shared component `DownloadResumeDropdown` với prop để customize:
|
||||
|
||||
```tsx
|
||||
// src/components/sections/DownloadResume.tsx
|
||||
|
||||
interface DownloadResumeDropdownProps {
|
||||
className?: string // Extra class for hero variant
|
||||
wrapperClassName?: string // Extra class for lazer wrapper
|
||||
targetBlank?: boolean // Hero uses target="_blank"
|
||||
}
|
||||
|
||||
function DownloadResumeDropdown({ className, wrapperClassName, targetBlank = false }: DownloadResumeDropdownProps) {
|
||||
// Shared: langLabels, useLanguage, state, click-outside effect, render logic
|
||||
}
|
||||
|
||||
export function DownloadResume() {
|
||||
if (!resumeAvailable) return null
|
||||
// Single language → DownloadButton
|
||||
// Multiple languages → DownloadResumeDropdown
|
||||
}
|
||||
|
||||
// Hero.tsx imports DownloadResumeDropdown and passes:
|
||||
// <DownloadResumeDropdown
|
||||
// className="hero-download-dropdown"
|
||||
// wrapperClassName="hero-download-summary"
|
||||
// targetBlank
|
||||
// />
|
||||
```
|
||||
|
||||
**Files cần sửa:**
|
||||
- `src/components/sections/DownloadResume.tsx` — extract shared dropdown logic
|
||||
- `src/components/sections/Hero.tsx` — replace `HeroDownloadDropdown` with shared component
|
||||
- `src/App.css` — consolidate CSS classes (`.hero-download-dropdown`, `.hero-download-summary`)
|
||||
|
||||
---
|
||||
|
||||
## P3: Hardcoded `langLabels`
|
||||
|
||||
**Impact:** `langLabels: Record<Language, string>` duplicated trong 2 file. Thêm language mới cần edit 2 nơi.
|
||||
|
||||
### Locations
|
||||
|
||||
| File | Dòng | Content |
|
||||
|---|---|---|
|
||||
| `src/components/sections/Hero.tsx` | 9-12 | `{ en: 'English', vi: 'Tiếng Việt' }` |
|
||||
| `src/components/sections/DownloadResume.tsx` | 7-10 | `{ en: 'English', vi: 'Tiếng Việt' }` |
|
||||
|
||||
### Đề xuất fix
|
||||
|
||||
Move vào `src/data/resume.ts` hoặc `strings.common.langLabels`:
|
||||
|
||||
```tsx
|
||||
// src/data/resume.ts
|
||||
export const resumeLanguages: Language[] = ['en', 'vi']
|
||||
export const resumeLanguageLabels: Record<Language, string> = {
|
||||
en: 'English',
|
||||
vi: 'Tiếng Việt',
|
||||
}
|
||||
```
|
||||
|
||||
**Files cần sửa:**
|
||||
- `src/data/resume.ts` — add `resumeLanguageLabels`
|
||||
- `src/components/sections/Hero.tsx` — import from `@/data/resume`
|
||||
- `src/components/sections/DownloadResume.tsx` — import from `@/data/resume`
|
||||
|
||||
---
|
||||
|
||||
## Already Done (reference only)
|
||||
|
||||
Những nơi đã implement đúng i18n patterns — không cần sửa:
|
||||
|
||||
| File | Dòng | Pattern |
|
||||
|---|---|---|
|
||||
| `src/components/sections/Contact.tsx` | 23 | `tag={\`06 - ${strings.common.contactTag[lang]}\`}` |
|
||||
| `src/pages/ExperiencePage.tsx` | 10 | `tag={strings.common.experienceTag[lang]}` |
|
||||
| `src/components/sections/About.tsx` | 16 | `useField(profile.bio, profile.bioEn)` |
|
||||
| `src/pages/AboutPage.tsx` | 23 | `useField(profile.bio, profile.bioEn)` |
|
||||
| `src/components/sections/Expertise.tsx` | 26 | `title={strings.expertise.heading[lang]}` |
|
||||
| `src/components/sections/Experience.tsx` | 26 | `title={strings.experience.heading[lang]}` |
|
||||
| `src/components/sections/Projects.tsx` | 32 | `title={strings.projects.featured[lang]}` |
|
||||
| `src/i18n/useField.ts` | 1-17 | `useField` + `useFieldArray` hooks |
|
||||
| `src/i18n/strings.ts` | 1-88 | All string keys defined |
|
||||
|
||||
---
|
||||
|
||||
## Summary
|
||||
|
||||
| Priority | Issue | Files affected | Effort |
|
||||
|---|---|---|---|
|
||||
| P1 | Hardcoded Section Heading Tags | 7 files | ~15 min |
|
||||
| P1 | Hardcoded `lang === 'vi'` checks | 7 files, 17 occurrences | ~30 min |
|
||||
| P2 | Duplicate DownloadResume logic | 2 files | ~45 min |
|
||||
| P3 | Hardcoded `langLabels` | 2 files + 1 data file | ~10 min |
|
||||
|
||||
**Total estimated effort:** ~1.5 hours
|
||||
@@ -0,0 +1,144 @@
|
||||
# i18n Phase 1 — Code Review Feedback
|
||||
|
||||
> **Spec:** `docs/design/specs/v3/spec-v3-i18n.md`
|
||||
> **Detail actions:** `docs/feedback/i18n-actions.md`
|
||||
|
||||
---
|
||||
|
||||
## 1. Hardcoded Section Heading Tags
|
||||
|
||||
**Severity:** P1 — Visible wrong behavior on language switch.
|
||||
|
||||
Section number tags are hardcoded English strings instead of using the i18n string system. When user switches to Vietnamese, the title translates but the tag stays in English.
|
||||
|
||||
**Affected files (7 locations):**
|
||||
|
||||
| File | Line | Current | Should be |
|
||||
|---|---|---|---|
|
||||
| `src/components/sections/About.tsx` | 13 | `tag="01 - About"` | `tag={strings.about.heading[lang]}` |
|
||||
| `src/components/sections/Expertise.tsx` | 26 | `tag="02 - Expertise"` | `tag={strings.expertise.heading[lang]}` |
|
||||
| `src/components/sections/Experience.tsx` | 26 | `tag="03 - Experience"` | `tag={strings.experience.heading[lang]}` |
|
||||
| `src/components/sections/Projects.tsx` | 32 | `tag="04 - Projects"` | `tag={strings.projects.featured[lang]}` |
|
||||
| `src/pages/ProjectsListPage.tsx` | 13 | `tag="04 - Projects"` | `tag={strings.projects.all[lang]}` |
|
||||
| `src/pages/AboutPage.tsx` | 19 | `tag="About"` | `tag={strings.about.heading[lang]}` |
|
||||
| `src/pages/EngineeringPage.tsx` | 12 | `tag="Engineering"` | `tag={strings.engineering.heading[lang]}` |
|
||||
|
||||
**Already correct (reference):**
|
||||
- `Contact.tsx:23` — `tag={\`06 - ${strings.common.contactTag[lang]}\`}`
|
||||
- `ExperiencePage.tsx:10` — `tag={strings.common.experienceTag[lang]}`
|
||||
|
||||
**Action:** Replace all hardcoded tag strings with `strings` lookups. See `i18n-actions.md` for exact changes.
|
||||
|
||||
---
|
||||
|
||||
## 2. Hardcoded Language Checks (`lang === 'vi'`)
|
||||
|
||||
**Severity:** P1 — Duplicated conditional logic, hard to maintain when adding new languages.
|
||||
|
||||
17 occurrences of inline `lang === 'vi' ? value : valueEn` pattern across 7 files. The `useField()` / `useFieldArray()` hooks already exist at `src/i18n/useField.ts` but are not consistently used.
|
||||
|
||||
**Affected files:**
|
||||
|
||||
| File | Lines | Pattern |
|
||||
|---|---|---|
|
||||
| `src/components/sections/Expertise.tsx` | 43 | `group.title / group.titleEn` |
|
||||
| `src/components/sections/Experience.tsx` | 46, 54, 64, 73 | `exp.title`, `exp.responsibilities`, `achievement.context`, `achievement.impact` |
|
||||
| `src/components/sections/Projects.tsx` | 63 | `project.summary / project.summaryEn` |
|
||||
| `src/pages/AboutPage.tsx` | 62 | `group.title / group.titleEn` |
|
||||
| `src/pages/ExperiencePage.tsx` | 16, 24, 31, 33 | `exp.title`, `exp.responsibilities`, `achievement.context`, `achievement.impact` |
|
||||
| `src/pages/ProjectDetailPage.tsx` | 37, 72, 73 | `project.summary`, `section.title`, `section.content` |
|
||||
| `src/pages/ProjectsListPage.tsx` | 27 | `project.summary / project.summaryEn` |
|
||||
|
||||
**Action:** Replace with `useField(value, valueEn)` for single values or `useFieldArray(arr, arrEn)` for arrays. See `i18n-actions.md` for exact changes.
|
||||
|
||||
---
|
||||
|
||||
## 3. Duplicate DownloadResume Dropdown Logic
|
||||
|
||||
**Severity:** P2 — ~120 lines of duplicate code between `Hero.tsx` and `DownloadResume.tsx`. Diverge risk when fixing bugs.
|
||||
|
||||
Both files contain nearly identical implementations of:
|
||||
- `langLabels` constant
|
||||
- `useEffect` click-outside listener
|
||||
- Lazer border wrapper structure
|
||||
- Dropdown options rendering
|
||||
|
||||
**Differences:**
|
||||
- Hero variant: custom CSS classes (`hero-download-dropdown`, `hero-download-summary`), `target="_blank"` on links
|
||||
- DownloadResume variant: `DownloadButton` fallback for single-language case
|
||||
|
||||
**Action:** Extract shared `DownloadResumeDropdown` component with `className` / `wrapperClassName` / `targetBlank` props. See `i18n-actions.md` for design proposal.
|
||||
|
||||
---
|
||||
|
||||
## 4. Hardcoded `langLabels`
|
||||
|
||||
**Severity:** P3 — `langLabels` duplicated in 2 files. Adding a new language requires editing 2 places.
|
||||
|
||||
**Locations:**
|
||||
- `src/components/sections/Hero.tsx:9-12`
|
||||
- `src/components/sections/DownloadResume.tsx:7-10`
|
||||
|
||||
**Action:** Move `langLabels` into `src/data/resume.ts` or `strings.common.langLabels` and import from there.
|
||||
|
||||
---
|
||||
|
||||
---
|
||||
|
||||
## Status: All Issues Resolved
|
||||
|
||||
**Completed:** 2025-01-01
|
||||
|
||||
### P1 — Hardcoded Section Heading Tags
|
||||
**Status:** ✅ Resolved
|
||||
|
||||
All 7 SectionHeading tags now use `strings` lookups:
|
||||
- `About.tsx:13` → `tag={strings.about.heading[lang]}`
|
||||
- `Expertise.tsx:26` → `tag={strings.expertise.heading[lang]}`
|
||||
- `Experience.tsx:26` → `tag={strings.experience.heading[lang]}`
|
||||
- `Projects.tsx:32` → `tag={strings.projects.featured[lang]}`
|
||||
- `ProjectsListPage.tsx:13` → `tag={strings.projects.all[lang]}`
|
||||
- `AboutPage.tsx:19` → `tag={strings.about.heading[lang]}`
|
||||
- `EngineeringPage.tsx:12` → `tag={strings.engineering.heading[lang]}`
|
||||
|
||||
### P1 — Hardcoded Language Checks
|
||||
**Status:** ✅ Resolved
|
||||
|
||||
All 17 occurrences replaced with `useField()` / `useFieldArray()` hooks:
|
||||
- `Expertise.tsx` — 1 replacement
|
||||
- `Experience.tsx` — 4 replacements
|
||||
- `Projects.tsx` — 1 replacement
|
||||
- `AboutPage.tsx` — 1 replacement
|
||||
- `ExperiencePage.tsx` — 4 replacements
|
||||
- `ProjectDetailPage.tsx` — 3 replacements
|
||||
- `ProjectsListPage.tsx` — 1 replacement
|
||||
|
||||
### P2 — Duplicate DownloadResume Dropdown
|
||||
**Status:** ✅ Resolved
|
||||
|
||||
Extracted shared `DownloadResumeDropdown` component in `DownloadResume.tsx` with:
|
||||
- `className` prop for outer div customization
|
||||
- `wrapperClassName` prop for button customization
|
||||
- `targetBlank` prop for link target attribute
|
||||
|
||||
Hero.tsx now imports and uses the shared component with hero-specific props.
|
||||
|
||||
### P3 — Hardcoded langLabels
|
||||
**Status:** ✅ Resolved
|
||||
|
||||
Moved `langLabels` to `src/data/resume.ts` as `resumeLanguageLabels`.
|
||||
Both Hero.tsx and DownloadResume.tsx now import from there.
|
||||
|
||||
## Already Done (reference only)
|
||||
|
||||
These locations already follow i18n patterns correctly:
|
||||
|
||||
| File | Line | Pattern |
|
||||
|---|---|---|
|
||||
| `Contact.tsx` | 23 | `tag={\`06 - ${strings.common.contactTag[lang]}\`}` |
|
||||
| `ExperiencePage.tsx` | 10 | `tag={strings.common.experienceTag[lang]}` |
|
||||
| `About.tsx` | 16 | `useField(profile.bio, profile.bioEn)` |
|
||||
| `AboutPage.tsx` | 23 | `useField(profile.bio, profile.bioEn)` |
|
||||
| `Expertise.tsx` | 26 | `title={strings.expertise.heading[lang]}` |
|
||||
| `Experience.tsx` | 26 | `title={strings.experience.heading[lang]}` |
|
||||
| `Projects.tsx` | 32 | `title={strings.projects.featured[lang]}` |
|
||||
Reference in new issue
Block a user