fix(i18n): complete phase 1 - translate section tags, replace lang checks, dedup download component

- Replace hardcoded SectionHeading tags with i18n strings (7 files)
- Replace 17 lang === 'vi' checks with useField/useFieldArray hooks
- Extract shared DownloadResumeDropdown component (Hero + DownloadResume)
- Move langLabels to src/data/resume.ts as resumeLanguageLabels
- Update feedback docs with resolution status
This commit is contained in:
dong.nguyen committed 2026-10-14 14:50:27 +07:00
1 parent 72a832c781
commit 4996a91a77
15 files changed
+489 -158

No files matched your search

+1 -1
View File
@@ -10,7 +10,7 @@ export function About() {
return (
<InView>
<section className="section container-wide" aria-labelledby="about-heading">
<SectionHeading title={strings.about.heading[lang]} tag="01 - About" />
<SectionHeading title={strings.about.heading[lang]} tag={strings.about.heading[lang]} />
<div style={{ maxWidth: '700px' }}>
<p style={{ fontSize: '18px', marginBottom: '32px' }}>
{useField(profile.bio, profile.bioEn)}
+2 -1
View File
@@ -20,7 +20,8 @@ export function Contact() {
visible: { opacity: 1, transition: { duration: 0.5 } },
}}
>
<SectionHeading title={strings.contact.heading[lang]} tag={`06 - ${strings.common.contactTag[lang]}`} />
<SectionHeading title={strings.contact.heading[lang]} tag={strings.common.contactTag[lang]} />
<div style={{ maxWidth: '700px' }}>
<div className="contact-links">
<motion.a
+71 -67
View File
@@ -1,12 +1,74 @@
import { resumeAvailable, resumeUrlFor, resumeLanguages } from '@/data/resume'
import { resumeAvailable, resumeUrlFor, resumeLanguages, resumeLanguageLabels } from '@/data/resume'
import type { Language } from '@/types'
import { useState, useRef, useEffect } from 'react'
import { useLanguage } from '@/hooks/useLanguage'
import { strings } from '@/i18n/strings'
const langLabels: Record<Language, string> = {
en: 'English',
vi: 'Tiếng Việt',
interface DownloadResumeDropdownProps {
className?: string
wrapperClassName?: string
targetBlank?: boolean
}
function DownloadResumeDropdown({ className, wrapperClassName, targetBlank = false }: DownloadResumeDropdownProps) {
const { lang } = useLanguage()
const [open, setOpen] = useState(false)
const ref = useRef<HTMLDivElement>(null)
useEffect(() => {
if (!open) return
const listener = (e: MouseEvent | TouchEvent) => {
if (ref.current && !ref.current.contains(e.target as Node)) {
setOpen(false)
}
}
document.addEventListener('mousedown', listener)
document.addEventListener('touchstart', listener)
return () => {
document.removeEventListener('mousedown', listener)
document.removeEventListener('touchstart', listener)
}
}, [open])
return (
<div ref={ref} className={`download-resume-dropdown ${className ?? ''}`}>
<div className="download-resume-shared-wrapper">
<div className="download-resume-lazer-wrapper">
<div className="download-resume-lazer-border" />
<div className="download-resume-lazer-glow" />
<div className="download-resume-lazer-inner">
<button
className={`download-resume-summary ${wrapperClassName ?? ''} ${open ? 'open' : ''}`}
onClick={() => setOpen(!open)}
type="button"
>
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round" width="20" height="20">
<path d="M12 3v10m0 0l-3-3m3 3l3-3" />
<path d="M3 17h18" />
</svg>
<span>{strings.common.resumeDownload[lang]}</span>
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round" width="16" height="16" className="chevron">
<polyline points="6 9 12 15 18 9" />
</svg>
</button>
</div>
</div>
<div className={`download-resume-options ${open ? 'open' : ''}`}>
{resumeLanguages.map(lang => (
<a
key={lang}
href={resumeUrlFor(lang)}
download
target={targetBlank ? '_blank' : undefined}
className="download-resume-option"
>
{resumeLanguageLabels[lang]}
</a>
))}
</div>
</div>
</div>
)
}
function DownloadButton({ lang }: { lang: Language }) {
@@ -28,86 +90,28 @@ function DownloadButton({ lang }: { lang: Language }) {
}}
>
<svg viewBox="0 0 24 24" fill="currentColor" width="24" height="24">
<path d="M12 2a1 1 0 0 1 1 1v9.586l2.707-2.707a1 1 0 1 1 1.414 1.414l-4.5 4.5a1 1 0 0 1-1.414 0l-4.5-4.5a1 1 0 1 1 1.414-1.414L11 12.586V3a1 1 0 0 1 1-1zm-7 16a1 1 0 1 1 0 2h14a1 1 0 1 1 0-2H5z" />
<path d="M12 2a1 1 0 0 1 1 1v9.586l2.707-2.707a1 1 0 1 1 1.414 1.414l-4.5 4.5a1 1 0 0 1-1.414 0l-4.5-4.5a1 1 0 0 1 1.414-1.414L11 12.586V3a1 1 0 0 1 1-1zm-7 16a1 1 0 1 1 0 2h14a1 1 0 1 1 0-2H5z" />
</svg>
<div>
<div style={{ fontWeight: 500, color: 'var(--text-primary)' }}>{strings.common.resumeDownload[currentLang]}</div>
<div style={{ fontSize: '14px', color: 'var(--text-muted)' }}>{langLabels[lang]}</div>
<div style={{ fontSize: '14px', color: 'var(--text-muted)' }}>{resumeLanguageLabels[lang]}</div>
</div>
</a>
)
}
function DownloadDropdown() {
const { lang } = useLanguage()
const [open, setOpen] = useState(false)
const ref = useRef<HTMLDivElement>(null)
useEffect(() => {
if (!open) return
const listener = (e: MouseEvent | TouchEvent) => {
if (ref.current && !ref.current.contains(e.target as Node)) {
setOpen(false)
}
}
document.addEventListener('mousedown', listener)
document.addEventListener('touchstart', listener)
return () => {
document.removeEventListener('mousedown', listener)
document.removeEventListener('touchstart', listener)
}
}, [open])
return (
<div ref={ref} className="download-resume-dropdown">
<div className="download-resume-shared-wrapper">
<div className="download-resume-lazer-wrapper">
<div className="download-resume-lazer-border" />
<div className="download-resume-lazer-glow" />
<div className="download-resume-lazer-inner">
<button
className={`download-resume-summary ${open ? 'open' : ''}`}
onClick={() => setOpen(!open)}
type="button"
>
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round" width="20" height="20">
<path d="M12 3v10m0 0l-3-3m3 3l3-3" />
<path d="M3 17h18" />
</svg>
<span>{strings.common.resumeDownload[lang]}</span>
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round" width="16" height="16" className="chevron">
<polyline points="6 9 12 15 18 9" />
</svg>
</button>
</div>
</div>
<div className={`download-resume-options ${open ? 'open' : ''}`}>
{resumeLanguages.map(lang => (
<a
key={lang}
href={resumeUrlFor(lang)}
download
className="download-resume-option"
>
{langLabels[lang]}
</a>
))}
</div>
</div>
</div>
)
}
export function DownloadResume() {
if (!resumeAvailable) return null
return (
<div style={{ marginTop: '32px' }}>
{resumeLanguages.length > 1 ? (
<DownloadDropdown />
<DownloadResumeDropdown />
) : (
<DownloadButton lang={resumeLanguages[0]} />
)}
</div>
)
}
export { DownloadResumeDropdown }
+6 -5
View File
@@ -4,6 +4,7 @@ import { experiences } from "@/data/experience"
import { InView } from "@/components/ui/InView"
import { useLanguage } from '@/hooks/useLanguage'
import { strings } from '@/i18n/strings'
import { useField, useFieldArray } from '@/i18n/useField'
export function Experience() {
const { lang } = useLanguage()
@@ -23,7 +24,7 @@ export function Experience() {
},
}}
>
<SectionHeading title={strings.experience.heading[lang]} tag="03 - Experience" />
<SectionHeading title={strings.experience.heading[lang]} tag={strings.experience.heading[lang]} />
<div style={{ maxWidth: '700px' }}>
<div className="timeline">
{experiences.map((exp, i) => (
@@ -43,7 +44,7 @@ export function Experience() {
>
<div className="timeline-marker" />
<div className="timeline-header">
<div className="timeline-title">{lang === 'vi' ? exp.title : exp.titleEn}</div>
<div className="timeline-title">{useField(exp.title, exp.titleEn)}</div>
<div className="timeline-company">{exp.company}</div>
<div className="timeline-duration">{exp.duration}</div>
{exp.location && (
@@ -51,7 +52,7 @@ export function Experience() {
)}
</div>
<ul className="timeline-responsibilities">
{(lang === 'vi' ? exp.responsibilities : exp.responsibilitiesEn ?? []).map((r) => (
{useFieldArray(exp.responsibilities, exp.responsibilitiesEn).map((r) => (
<li key={r}>{r}</li>
))}
</ul>
@@ -61,7 +62,7 @@ export function Experience() {
{achievement.title}
</div>
<div className="achievement-context">
{lang === 'vi' ? achievement.context : achievement.contextEn}
{useField(achievement.context, achievement.contextEn)}
</div>
<div
style={{
@@ -70,7 +71,7 @@ export function Experience() {
marginBottom: "8px",
}}
>
{lang === 'vi' ? achievement.impact : achievement.impactEn}
{useField(achievement.impact, achievement.impactEn)}
</div>
{achievement.metrics &&
achievement.metrics.length > 0 && (
+3 -2
View File
@@ -4,6 +4,7 @@ import { skillGroups } from "@/data/skills"
import { InView } from "@/components/ui/InView"
import { useLanguage } from '@/hooks/useLanguage'
import { strings } from '@/i18n/strings'
import { useField } from '@/i18n/useField'
export function Expertise() {
const { lang } = useLanguage()
@@ -23,7 +24,7 @@ export function Expertise() {
},
}}
>
<SectionHeading title={strings.expertise.heading[lang]} tag="02 - Expertise" />
<SectionHeading title={strings.expertise.heading[lang]} tag={strings.expertise.heading[lang]} />
<div className="expertise-grid">
{skillGroups.map((group, i) => (
<motion.div
@@ -40,7 +41,7 @@ export function Expertise() {
whileHover={{ scale: 1.05, y: -2 }}
whileTap={{ scale: 0.98 }}
>
<h3>{lang === 'vi' ? group.title : group.titleEn}</h3>
<h3>{useField(group.title, group.titleEn)}</h3>
<ul className="expertise-skills">
{group.skills.map((skill) => (
<li key={skill} className="expertise-skill">
+4 -68
View File
@@ -1,75 +1,11 @@
import { useState, useRef, useEffect } from 'react'
import { motion, useScroll, useTransform } from "motion/react"
import { InView } from "@/components/ui/InView"
import { resumeAvailable, resumeLanguages, resumeUrlFor } from "@/data/resume"
import { resumeAvailable, resumeLanguages, resumeUrlFor, resumeLanguageLabels } from "@/data/resume"
import type { Language } from '@/types'
import { useLanguage } from '@/hooks/useLanguage'
import { strings } from '@/i18n/strings'
import { useField } from '@/i18n/useField'
const langLabels: Record<Language, string> = {
en: 'English',
vi: 'Tiếng Việt',
}
function HeroDownloadDropdown() {
const { lang } = useLanguage()
const [open, setOpen] = useState(false)
const ref = useRef<HTMLDivElement>(null)
useEffect(() => {
if (!open) return
const listener = (e: MouseEvent | TouchEvent) => {
if (ref.current && !ref.current.contains(e.target as Node)) {
setOpen(false)
}
}
document.addEventListener('mousedown', listener)
document.addEventListener('touchstart', listener)
return () => {
document.removeEventListener('mousedown', listener)
document.removeEventListener('touchstart', listener)
}
}, [open])
return (
<div ref={ref} className="download-resume-dropdown hero-download-dropdown">
<div className="download-resume-shared-wrapper">
<div className="download-resume-lazer-wrapper">
<div className="download-resume-lazer-border" />
<div className="download-resume-lazer-glow" />
<div className="download-resume-lazer-inner">
<button
className={`download-resume-summary hero-download-summary ${open ? 'open' : ''}`}
onClick={() => setOpen(!open)}
type="button"
>
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round" width="18" height="18">
<path d="M12 3v10m0 0l-3-3m3 3l3-3" />
<path d="M3 17h18" />
</svg>
<span>{strings.common.resumeDownload[lang]}</span>
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" strokeLinecap="round" strokeLinejoin="round" width="14" height="14" className="chevron">
<polyline points="6 9 12 15 18 9" />
</svg>
</button>
</div>
</div>
<div className={`download-resume-options ${open ? 'open' : ''}`}>
{resumeLanguages.map(lang => (
<a
key={lang}
href={resumeUrlFor(lang)}
download
target="_blank"
className="download-resume-option"
>
{langLabels[lang]}
</a>
))}
</div>
</div>
</div>
)
}
import { DownloadResumeDropdown } from '@/components/sections/DownloadResume'
function HeroDownloadButton({ lang }: { lang: Language }) {
return (
@@ -79,7 +15,7 @@ function HeroDownloadButton({ lang }: { lang: Language }) {
target="_blank"
className="btn btn-primary hero-download-mobile-btn"
>
Download Resume ({langLabels[lang]})
Download Resume ({resumeLanguageLabels[lang]})
</a>
)
}
@@ -194,7 +130,7 @@ export function Hero() {
{resumeAvailable && (
<>
<div className="hero-download-desktop">
<HeroDownloadDropdown />
<DownloadResumeDropdown className="hero-download-dropdown" wrapperClassName="hero-download-summary" targetBlank />
</div>
<div className="hero-download-mobile">
{resumeLanguages.map(lang => (
+3 -2
View File
@@ -6,6 +6,7 @@ import { projects } from "@/data/projects"
import { InView } from "@/components/ui/InView"
import { useLanguage } from '@/hooks/useLanguage'
import { strings } from '@/i18n/strings'
import { useField } from '@/i18n/useField'
const MotionLink = motion.create(Link)
@@ -29,7 +30,7 @@ export function Projects() {
},
}}
>
<SectionHeading title={strings.projects.featured[lang]} tag="04 - Projects" />
<SectionHeading title={strings.projects.featured[lang]} tag={strings.projects.featured[lang]} />
<Link
to="/projects"
style={{ fontSize: "14px", fontWeight: 500, color: "var(--accent)", display: "block", marginBottom: "24px" }}
@@ -60,7 +61,7 @@ export function Projects() {
{strings.projects.categories[project.category][lang]}
</Badge>
</div>
<p className="project-card-summary">{lang === 'vi' ? project.summary : project.summaryEn}</p>
<p className="project-card-summary">{useField(project.summary, project.summaryEn)}</p>
<div className="project-card-techs">
{project.technologies.slice(0, 4).map((tech) => (
<span key={tech} className="tag">