diff --git a/docs/design/spec-v2.md b/docs/design/spec-v2.md index f352deb..d0465e4 100644 --- a/docs/design/spec-v2.md +++ b/docs/design/spec-v2.md @@ -22,13 +22,14 @@ v2 bao gồm 6 tính năng, mỗi tính năng có spec riêng trong `specs/`: | File | Feature | Priority | Est. | Status | |------|---------|----------|------|--------| | `specs/v2/spec-v2-resume.md` | Resume download | P1 | ~15 min | ✅ Done | +| `specs/v2/spec-v2-hero-carousel.md` | Hero visual carousel | P1 | ~1 hour | | | `specs/v2/spec-v2-seo.md` | SEO (metadata, OG, sitemap) | P1 | ~1 hour | | | `specs/v2/spec-v2-blog.md` | Blog (MDX, articles, syntax highlight) | P1 | ~4 hours | | | `specs/v2/spec-v2-analytics.md` | Analytics (Plausible) | P2 | ~30 min | | | `specs/v2/spec-v2-testing.md` | Testing (Vitest + E2E) | P5 | ~3 hours | | | `specs/v2/spec-v2-cicd.md` | CI/CD (GitHub Actions) | P5 | ~1 hour | | -**Implementation order:** ~~Resume~~ → SEO → Blog → Analytics → Testing → CI/CD +**Implementation order:** ~~Resume~~ → Hero Carousel → SEO → Blog → Analytics → Testing → CI/CD --- diff --git a/docs/design/specs/ui/spec-ui-hero-photo.md b/docs/design/specs/ui/spec-ui-hero-photo.md new file mode 100644 index 0000000..792d1f9 --- /dev/null +++ b/docs/design/specs/ui/spec-ui-hero-photo.md @@ -0,0 +1,130 @@ +# UI Spec - Hero Photo Background + Open to Work Badge + +## Overview + +Thay thế hero-visual (SVG diagram) bằng profile photo background, fill toàn bộ vùng bên phải hero section. Badge "Open to Work" overlay ở góc dưới ảnh. + +--- + +## Structure + +``` +Hero (section) +├── hero-photo-bg (div, ảnh nền) +│ └── profile-photo.webp (img, object-fit: cover) +├── hero-content (div, text bên trái) +│ ├── hero-name (h1) +│ ├── hero-title (p) +│ ├── hero-tagline (p) +│ ├── hero-cta (div, buttons) +│ └── SocialLinks +└── OpenToWorkBadge (component, góc dưới-right) + ├── icon (checkmark) + ├── "Open to Work" (text chính) + └── "Software Engineer" (subtitle) +``` + +--- + +## Hero Photo Background + +### Desktop + +- Position: absolute, fill `hero-visual` area +- `object-fit: cover` — fill hết khung, cắt phần thừa +- `object-position: center top` — giữ khuôn mặt ở trên +- Border-radius: 0 (khung vuông/tròn?) +- Z-index: 0 (nằm dưới text) + +### Mobile + +- Position: absolute, fill TOÀN BỘ hero section +- `object-fit: cover` +- Overlay gradient để text readable + +--- + +## Text Overlay + +### Desktop + +- Text nằm bên trái, không đè lên ảnh +- Giữ layout 2 cột hiện tại +- Không cần overlay + +### Mobile + +- Overlay gradient từ trái qua (transparent → dark) +- Hoặc overlay bán trong suốt toàn bộ hero +- Đảm bảo text contrast ratio ≥ 4.5:1 + +--- + +## Open to Work Badge + +### Design + +- Shape: bo góc 12px +- Background: accent color (hoặc gradient accent) +- Size: 200x200 (max-width: 200px) +- Padding: 20px +- Shadow: subtle drop shadow + +### Content + +``` +┌──────────────────┐ +│ ✓ Open to Work │ +│ Software │ +│ Engineer │ +└──────────────────┘ +``` + +- Icon: checkmark (SVG inline) +- Title: "Open to Work" — bold, 18px +- Subtitle: "Software Engineer" — regular, 14px, muted +- Icon + Title: cùng dòng +- Subtitle: dòng dưới + +### Position + +- Desktop: góc dưới-right của `hero-visual` +- Mobile: góc dưới-right của hero section +- Margin: 20px từ cạnh + +--- + +## Responsive + +### Desktop (>768px) + +``` +┌──────────────────────────────────────┐ +│ Text Content │ Photo BG │ +│ (left 50%) │ (right 50%) │ +│ │ │ +│ │ [OTW] │ +└──────────────────────────────────────┘ +``` + +### Mobile (≤768px) + +``` +┌──────────────────────────────┐ +│ Photo BG (full) │ +│ ┌────────────────────────┐ │ +│ │ Text Content + Overlay │ │ +│ └────────────────────────┘ │ +│ [OTW] │ +└──────────────────────────────┘ +``` + +--- + +## Constraints + +- Không hard-code nội dung trong JSX — data-driven từ `profile.ts` +- Ảnh fallback: placeholder gray nếu thiếu asset +- Giảm motion: không animation khi scroll +- Accessibility: alt text cho ảnh, aria-label cho badge +- Không thay đổi layout text content bên trái diff --git a/docs/design/specs/v2/spec-v2-resume.md b/docs/design/specs/v2/spec-v2-resume.md index 07cfa1f..194bf6c 100644 --- a/docs/design/specs/v2/spec-v2-resume.md +++ b/docs/design/specs/v2/spec-v2-resume.md @@ -1,7 +1,7 @@ # Specification — v2 Resume Download > **Document:** `spec-v2-resume.md` -> **Version:** 0.3.0 +> **Version:** 0.4.0 > **Parent:** `spec-v2.md` > **Priority:** P1 > **Estimate:** ~15 minutes @@ -12,7 +12,7 @@ - Nút **"Download Resume"** hiển thị ở **2 vị trí**: 1. **Hero section** — CTA row (bên cạnh "View Projects" / "Contact Me") - 2. **Contact section** — trong `contact-links` grid + 2. **Contact section / Contact page** — riêng biệt, sau `contact-links` grid - Link trực tiếp đến file PDF (`/resume.pdf`) với attribute `download` - Khi chưa có PDF → ẩn hoàn toàn ở cả 2 vị trí - PDF upload vào `public/resume.pdf` @@ -22,60 +22,77 @@ ## Implementation +### DownloadResume Component + +```tsx +// src/components/sections/DownloadResume.tsx +import { resumeAvailable } from '@/data/resume' + +export function DownloadResume() { + if (!resumeAvailable) return null + return ( +
+ + ... +
Download Resume
+
PDF
+
+
+ ) +} +``` + ### Hero Section (primary CTA) ```tsx // Hero.tsx +import { Button } from '@/components/ui/Button' import { resumeAvailable } from '@/data/resume' export function Hero() { return ( -
-
- {/* ... heading, title, tagline ... */} -
- - {resumeAvailable && ( - - )} - -
- +
+ + {resumeAvailable && ( + + )} + +
+ ) +} +``` + +### Contact Section (home page) + +```tsx +// Contact.tsx +import { DownloadResume } from '@/components/sections/DownloadResume' + +export function Contact() { + return ( +
+ +
+ {/* Email, GitHub, LinkedIn */}
- {/* ... hero-visual ... */} +
) } ``` -### Contact Section (secondary) +### ContactPage (standalone page) ```tsx -// Contact.tsx -import { resumeAvailable } from '@/data/resume' +// ContactPage.tsx +import { DownloadResume } from '@/components/sections/DownloadResume' -export function Contact() { +export function ContactPage() { return ( -
- -
- {/* ... existing links (Email, GitHub, LinkedIn) ... */} - {resumeAvailable && ( - - ... -
-
Download Resume
-
PDF
-
-
- )} -
+
+

Contact

+
...
+
) } @@ -95,10 +112,10 @@ Nút Resume trong nav chỉ hiện khi có `/resume` route (HTML resume page). --- ## Acceptance + - [x] Nút "Download Resume" hiển thị trong Hero CTA row -- [x] Nút "Download Resume" hiển thị trong Contact section +- [x] DownloadResume component riêng, dùng lại trong Contact section và ContactPage - [x] Click → download PDF từ `/resume.pdf` - [x] Khi chưa có PDF → ẩn hoàn toàn ở cả 2 vị trí - [x] Responsive trên mobile - [x] Nav không có nút Resume (Phase 2) - diff --git a/public/toast-bar0001-0120.mp4 b/public/toast-bar0001-0120.mp4 new file mode 100644 index 0000000..99d9088 Binary files /dev/null and b/public/toast-bar0001-0120.mp4 differ diff --git a/src/App.css b/src/App.css index 9c7ef55..78c3cb3 100644 --- a/src/App.css +++ b/src/App.css @@ -400,26 +400,60 @@ } .hero-visual { + position: relative; display: flex; align-items: center; justify-content: center; } -.hero-graphic { +.hero-photo { width: 100%; - max-width: 400px; - aspect-ratio: 1; - position: relative; + height: 100%; + object-fit: cover; + object-position: center top; + border-radius: 16px; + display: block; +} + +.otw-badge { + position: absolute; + bottom: 20px; + right: 20px; + background: var(--accent); + color: #fff; + padding: 20px; + border-radius: 12px; + box-shadow: 0 4px 12px rgba(0, 0, 0, 0.15); + display: flex; + flex-direction: column; + gap: 6px; + max-width: 200px; +} + +.otw-icon { + width: 16px; + height: 16px; + margin-bottom: 2px; +} + +.otw-title { + font-size: 18px; + font-weight: 700; + line-height: 1.2; +} + +.otw-subtitle { + font-size: 14px; + opacity: 0.9; + line-height: 1.3; } @media (max-width: 768px) { .hero { - grid-template-columns: 1fr; - gap: 32px; - min-height: auto; - padding: 48px 0; + position: relative; + min-height: 500px; + overflow: hidden; } - .hero-cta { flex-direction: column; } @@ -429,7 +463,23 @@ } .hero-visual { - display: none; + position: absolute; + inset: 0; + z-index: 0; + } + .hero-content { + position: relative; + z-index: 1; + background: rgba(0, 0, 0, 0.55); + padding: 32px 24px; + border-radius: 16px; + backdrop-filter: blur(4px); + } + + .otw-badge { + bottom: 16px; + right: 16px; + padding: 16px; } } diff --git a/src/components/sections/Contact.tsx b/src/components/sections/Contact.tsx index f9789b1..dba8c12 100644 --- a/src/components/sections/Contact.tsx +++ b/src/components/sections/Contact.tsx @@ -1,4 +1,4 @@ -import { resumeAvailable } from '@/data/resume' +import { DownloadResume } from '@/components/sections/DownloadResume' import { SectionHeading } from '@/components/ui/SectionHeading' import { profile } from '@/data/profile' @@ -35,20 +35,8 @@ export function Contact() {
Your Name
- {resumeAvailable && ( - - - - - - -
-
Download Resume
-
PDF
-
-
- )} +
) } diff --git a/src/components/sections/DownloadResume.tsx b/src/components/sections/DownloadResume.tsx new file mode 100644 index 0000000..b68d3c1 --- /dev/null +++ b/src/components/sections/DownloadResume.tsx @@ -0,0 +1,21 @@ +import { resumeAvailable } from '@/data/resume' + +export function DownloadResume() { + if (!resumeAvailable) return null + + return ( +
+ + + + + + +
+
Download Resume
+
PDF
+
+
+
+ ) +} diff --git a/src/components/sections/Hero.tsx b/src/components/sections/Hero.tsx index 7415117..43116ed 100644 --- a/src/components/sections/Hero.tsx +++ b/src/components/sections/Hero.tsx @@ -1,3 +1,4 @@ +import { OpenToWorkBadge } from '@/components/ui/OpenToWorkBadge' import { resumeAvailable } from '@/data/resume' import { Button } from '@/components/ui/Button' import { SocialLinks } from '@/components/ui/SocialLinks' @@ -62,37 +63,12 @@ export function Hero() {
-
- - {/* Abstract system diagram */} - - - - - {/* Nodes */} - - - - - - {/* Connections */} - - - - - - {/* Diagonal connections */} - - - - - - {/* Center label */} - - core - - -
+ Profile photo +
) diff --git a/src/components/ui/OpenToWorkBadge.tsx b/src/components/ui/OpenToWorkBadge.tsx new file mode 100644 index 0000000..ef28ff0 --- /dev/null +++ b/src/components/ui/OpenToWorkBadge.tsx @@ -0,0 +1,23 @@ +import { profile } from '@/data/profile' + +export function OpenToWorkBadge() { + return ( +
+ + + + Open to Work + {profile.title} +
+ ) +} diff --git a/src/pages/ContactPage.tsx b/src/pages/ContactPage.tsx index effc2da..63c9fd1 100644 --- a/src/pages/ContactPage.tsx +++ b/src/pages/ContactPage.tsx @@ -1,3 +1,4 @@ +import { DownloadResume } from '@/components/sections/DownloadResume' import { profile } from '@/data/profile' export function ContactPage() { @@ -36,6 +37,7 @@ export function ContactPage() { + ) }