mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-23 00:20:40 +07:00
docs(specs): record the timeline pass, variant model and resume undefined fix
- AGENTS.md: data layer now names ExperienceEntry.variant ('current' | 'gap'); Card dropped
from the ui/ component list (deleted in d172843)
- spec-ui-components.md: Card section replaced with a removal note (component + .card* rules
deleted; remaining cards are section-specific classes)
- spec-ui-experience.md: structure tree used the dropped `current: true` flag -> composed class
- spec-v3-typography.md: achievement rules marked deleted, dead-CSS list extended, Experience
TSX row marked superseded, new 4.4 covering the timeline pass and the resume generator fix
- spec-v3-resume-improvements.md: Bugs Fixed row 2 for
"${exp.achievements?.map(...).join('')}" printing the literal "undefined"; malformed table
separator repaired
- spec-v2-resume-playwright.md: acceptance row 4 notes the achievements branch is now a
guarded no-op
- spec-v3-i18n.md: experience.ts data row and the Experience strings rows updated
(achievements dropped, relax-gap added, experience.tldr / tldrText recorded)
- spec-v3-theme-palette-gasatrya.md: lint baseline annotated 15/9 -> 11/9
This commit is contained in:
1 parent
166eb171b5
commit
5b4b301ef1
8 files changed
+30
-47
No files matched your search
@@ -716,7 +716,7 @@ will show because `/resume.pdf` exists on the server.
|
||||
| 1 | `pnpm tsx scripts/generate-resume.ts` produces `dist/resume.pdf` | ✅ | Script at `scripts/generate-resume.ts`, alias `pnpm build:resume` |
|
||||
| 2 | PDF is A4 size, multi-page with correct pagination | ✅ | `@page { size: A4 }` in template, `format: 'A4'` in script |
|
||||
| 3 | Header contains profile photo (circular crop), name, title, contact info | ✅ | Base64 photo, profile data from `src/data/profile.ts` |
|
||||
| 4 | Experience section includes all companies, roles, responsibilities, achievements | ✅ | `renderExperience()` renders exp, responsibilities, achievements with technicalWork |
|
||||
| 4 | Experience section includes all companies, roles, responsibilities, achievements | ✅ | `renderExperience()` renders exp, responsibilities, achievements with technicalWork. Note (2026-10-16): the achievements branch is now a guarded no-op — `src/data/experience.ts` no longer carries `achievements`, and the map is `(exp.achievements ?? [])` because `${exp.achievements?.map(...).join('')}` used to print the literal `undefined` |
|
||||
| 5 | Skills section includes all skill groups | ✅ | `renderSkills()` renders all groups in 2-column grid |
|
||||
| 6 | All projects included (not just featured) | ✅ | `renderProjects()` iterates full `projects` array |
|
||||
| 7 | Sections do not split across pages | ✅ | `.avoid-break { page-break-inside: avoid }` on exp-entry, achievement, skill-group, project |
|
||||
|
||||
Reference in new issue
Block a user