mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-23 00:20:40 +07:00
docs(specs): record the timeline pass, variant model and resume undefined fix
- AGENTS.md: data layer now names ExperienceEntry.variant ('current' | 'gap'); Card dropped
from the ui/ component list (deleted in d172843)
- spec-ui-components.md: Card section replaced with a removal note (component + .card* rules
deleted; remaining cards are section-specific classes)
- spec-ui-experience.md: structure tree used the dropped `current: true` flag -> composed class
- spec-v3-typography.md: achievement rules marked deleted, dead-CSS list extended, Experience
TSX row marked superseded, new 4.4 covering the timeline pass and the resume generator fix
- spec-v3-resume-improvements.md: Bugs Fixed row 2 for
"${exp.achievements?.map(...).join('')}" printing the literal "undefined"; malformed table
separator repaired
- spec-v2-resume-playwright.md: acceptance row 4 notes the achievements branch is now a
guarded no-op
- spec-v3-i18n.md: experience.ts data row and the Experience strings rows updated
(achievements dropped, relax-gap added, experience.tldr / tldrText recorded)
- spec-v3-theme-palette-gasatrya.md: lint baseline annotated 15/9 -> 11/9
This commit is contained in:
1 parent
166eb171b5
commit
5b4b301ef1
8 files changed
+30
-47
No files matched your search
@@ -411,7 +411,7 @@ New structure: **one dark block + one light block + one media bridge** (removes
|
||||
- [x] `src/index.css` palette rewritten — `:root` dark default (2-51), `:root[data-theme='light']` (54-79), `@media (prefers-color-scheme: light)` bridge for `:root:not([data-theme='dark'])` (82-109); 8 new tokens + `color-scheme`
|
||||
- [x] Card inset highlight applied — `.card` base, `.card:hover`, `.card-elevated` — **superseded**: the whole `.card*` block was deleted as dead code in the typography pass (`spec-v3-typography.md` §4.2); `--inset-highlight` is still consumed, by `.project-section`
|
||||
- [x] **B13** fixed — late-found hardcoded values from the grep gate: blue focus ring `rgba(96,165,250,0.1)` → `var(--accent-soft)` (`src/App.css:1351`)
|
||||
- [ ] `pnpm lint` clean — **not clean, and not from this change**: 15 errors + 9 warnings, every one in a `.tsx` file this change never touched (`react-hooks(rules-of-hooks)` on `useField` / `useFieldArray` called inside callbacks). Modified files are `src/App.css`, `src/index.css`, `index.html`, `public/favicon.svg`, `public/resume-template.html` and two spec documents
|
||||
- [ ] `pnpm lint` clean — **not clean, and not from this change**: 15 errors + 9 warnings at the time, every one in a `.tsx` file this change never touched (`react-hooks(rules-of-hooks)` on `useField` / `useFieldArray` called inside callbacks). Modified files are `src/App.css`, `src/index.css`, `index.html`, `public/favicon.svg`, `public/resume-template.html` and two spec documents. Update 2026-10-16: after the achievements markup was removed from the timeline the count is **11 errors / 9 warnings** — the four that disappeared were `rules-of-hooks` findings inside that markup
|
||||
- [x] `pnpm exec tsc -b` passes (exit 0)
|
||||
- [ ] `pnpm build` end-to-end — blocked by an environment lock, not by the palette: Vite's `emptyDir` throws `EPERM` on `dist\assets` because `docker-compose.yaml:7` mounts `./dist:/usr/share/nginx/html:ro`. Proof the sources build: `pnpm exec vite build --outDir dist-verify` → 538 modules transformed, 26.15 kB CSS, no errors (temp out dir deleted)
|
||||
- [ ] Verified in real browser (user): `/`, `/projects`, `/projects/:id`, `/experience`, `/contact`, `/philosophy`, mobile ≤768px, both themes
|
||||
|
||||
Reference in new issue
Block a user