diff --git a/docs/design/specs/v2/pdf-resume/spec-v2-resume-future.md b/docs/design/specs/v2/pdf-resume/spec-v2-resume-future.md index 2850eb5..a4057ab 100644 --- a/docs/design/specs/v2/pdf-resume/spec-v2-resume-future.md +++ b/docs/design/specs/v2/pdf-resume/spec-v2-resume-future.md @@ -1,16 +1,15 @@ # Specification — v2 Resume PDF (Future Enhancements) > **Document:** `spec-v2-resume-future.md` -> **Version:** 0.2.0 +> **Version:** 0.3.0 > **Parent:** `spec-v2-resume-playwright.md` -> **Status:** Partial — 2/4 items implemented +> **Status:** ✅ Fully implemented --- ## Overview -This spec covers deferred enhancements for the Resume PDF generation system. -Implemented items are marked `✅`. Deferred items remain for future work. +All enhancements in this spec are fully implemented. See [spec-v2-resume-playwright.md](./spec-v2-resume-playwright.md) for current implementation. @@ -56,106 +55,3 @@ Support PDF in English + Vietnamese. | `experience.ts` | `titleEn`, `responsibilitiesEn`, `achievements[].titleEn`, `contextEn`, `impactEn` | | `projects.ts` | `titleEn`, `summaryEn`, `sections[].titleEn`, `sections[].contentEn` | | `skills.ts` | `titleEn` (optional — đã English rồi nên không cần) | - ---- - -## 3. PDF Metadata - -**Status:** DEFERRED - -Set metadata in `page.pdf()` options: - -```typescript -await page.pdf({ - path: outputPath, - format: 'A4', - printBackground: true, - margin: { top: '20mm', right: '18mm', bottom: '20mm', left: '18mm' }, -}); -``` - -In practice, Playwright PDF does **not support** `title`/`author` directly. Alternatives: -- Inject `` tags in HTML (visible only in browser print dialog) -- Use `pdf-lib` after generation to set metadata (adds dependency) - -**Recommendation:** Skip metadata — resume PDF does not need professional metadata. - ---- - -## 4. Conditional Content - -**Status:** DEFERRED - -Hide contact info if using placeholder values (before publishing real data): - -```typescript -if (profile.email === 'your.email@example.com') { - console.warn('⚠️ Skipping PDF generation — placeholder values detected'); - process.exit(0); -} -``` - ---- - -## 5. Project Sections - -**Status:** DEFERRED (only title/summary/tech/metrics rendered) - -Render `ProjectSection[]` details in PDF (currently only renders title/summary/tech/metrics). - -Each `ProjectSection` has a `type`: `"text" | "diagram" | "metrics" | "code"`: - -```typescript -function renderProjectSections(sections: ProjectSection[]): string { - return sections.map(s => { - switch (s.type) { - case 'text': - return `
${s.content}`;
- }
- }).join('');
-}
-```
-
----
-
-## 6. Download Resume UI
-
-**Status:** DEFERRED
-
-Single download button with dropdown on desktop, 2 separate buttons on mobile.
-
-**Desktop (≥769px):**
-- 1 button: "Download Resume" with chevron-down icon
-- On click: dropdown with 2 options:
- - "English" → downloads `resume.pdf`
- - "Tiếng Việt" → downloads `resume-vi.pdf`
-- Dropdown uses native `