mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-22 16:10:40 +07:00
feat(edit): keep edit mode across navigation, only Exit leaves
Edit mode is a session, not a URL state. MaybeEditMode mounts the shell on ?edit or on the session flag; while mounted, EditModeShell re-attaches ?edit after a route change that dropped it (replace navigation, skipped while authenticating so it never fights a failed auth). The session initializes once per mount - entry URL from a ref, stripEditQuery reads window.location - so navigation neither re-authenticates, re-fetches, nor re-restores the draft. ?edit parsing, the session/branch flags and the portfolio-draft key move to a dependency-free src/i18n/edit-session.ts so App.tsx can read the gate without pulling the Basic-auth probe (and through it draft.ts) into the entry chunk; edit-mode.ts is now the auth handshake alone. Verified: tsc -b, pnpm build (entry chunk carries no probe literal, EditModeShell stays a separate lazy chunk), pnpm lint (no new warnings), throwaway smokes for the session semantics (17/17) and the router behaviour behind the guard (5/5), both deleted after the run.
This commit is contained in:
1 parent
1bc12d23a6
commit
7b4a782f59
7 files changed
+121
-73
No files matched your search
+9
-3
@@ -6,6 +6,7 @@ import { ThemeProvider } from '@/hooks/useTheme'
|
||||
import { Layout } from '@/components/layout/Layout'
|
||||
import { LanguageProvider } from '@/hooks/useLanguage'
|
||||
import { I18nProvider } from '@/i18n/provider'
|
||||
import { editRequested, hasEditFlag } from '@/i18n/edit-session'
|
||||
import { HomePage } from '@/pages/HomePage'
|
||||
|
||||
// HomePage stays eager: it is the landing route and owns the LCP, so its code must
|
||||
@@ -19,13 +20,18 @@ const PhilosophyPage = lazy(() => import('@/pages/PhilosophyPage').then((m) => (
|
||||
const ContactPage = lazy(() => import('@/pages/ContactPage').then((m) => ({ default: m.ContactPage })))
|
||||
|
||||
// Edit mode is lazy too: visitors never download the draft store, the panel
|
||||
// or the save pipeline (spec-v4 §7 P3.4). The gate only mounts the shell when
|
||||
// `?edit` is present; the shell then authenticates or strips the query again.
|
||||
// or the save pipeline (spec-v4 §7 P3.4). The gate opens the shell on `?edit`
|
||||
// or on a session that is already in the mode; the shell authenticates, or it
|
||||
// closes the session again.
|
||||
const EditModeShell = lazy(() => import('@/components/layout/EditModeShell'))
|
||||
|
||||
function MaybeEditMode({ children }: { children: ReactNode }) {
|
||||
const location = useLocation()
|
||||
const editing = new URLSearchParams(location.search).has('edit')
|
||||
// `?edit` opens edit mode; from there the session flag keeps it across every
|
||||
// navigation and every reload until the EditBar's Exit ends it. The flag and
|
||||
// the query test live in `edit-session.ts`, which carries no dependency on
|
||||
// the draft store, so this gate keeps the edit code out of the entry chunk.
|
||||
const editing = editRequested(location.search) || hasEditFlag()
|
||||
if (!editing) return <>{children}</>
|
||||
return (
|
||||
<Suspense fallback={null}>
|
||||
|
||||
Reference in new issue
Block a user