mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-23 00:20:40 +07:00
resume: ship the open-to-work entry in both PDFs with an accent live-node bullet (spec-v3 follow-up 25)
This commit is contained in:
1 parent
66b46adfec
commit
a5b658e0af
3 files changed
+6
-4
No files matched your search
@@ -49,7 +49,7 @@ Modern, elegant, brand-consistent A4 resume: correct print geometry, timeline ex
|
||||
- `--lang=all` → `['en','vi']` in **one** Chromium launch, one page, loop `page.pdf`; rejected with `--preview`.
|
||||
- `escapeHtml()` applied to every data-derived string before template injection.
|
||||
- Placeholder fill via literal `split/join` (avoids regex + `$` pitfalls of `String.replace`); **placeholder guard**: any unresolved `{{KEY}}` after fill → `console.error` + `exit(1)` before browser launch (prevents the dead-placeholder bug class recorded in `spec-v3-resume-improvements.md`).
|
||||
- `renderExperience` filters `variant === 'current'` — the open-to-work entry is excluded from the resume PDF entirely (owner decision 2026-10-19; site timeline untouched). The earlier status-pill design was removed: `renderStatus`, `OPEN_TO_WORK` labels, and the `{{STATUS}}` placeholder no longer exist. `renderTldr` reads the shared `strings` module — no duplicated TL;DR copy.
|
||||
- `renderExperience` renders every entry including `variant === 'current'` (open-to-work) — reversal of the 2026-10-19 exclusion, owner decision 2026-11-02: the entry now leads the resume timeline with an accent bullet (`.exp-entry.current::before` in the template, mirroring the site's live node). The earlier status-pill design stays removed: `renderStatus`, `OPEN_TO_WORK` labels, and the `{{STATUS}}` placeholder no longer exist. `renderTldr` reads the shared `strings` module — no duplicated TL;DR copy.
|
||||
- `resolveField(en, vi, lang)` now takes the language explicitly (script handles multiple languages per run).
|
||||
- `page.pdf`: added `preferCSSPageSize: true` (activates `@page`) and `tagged: true` (tagged/accessibility PDF); removed the non-existent `title`/`author` options — PDF Title metadata now comes from the HTML `<title>` (`Resume - {NAME}` per language).
|
||||
- `mkdirSync(dirname(outputPath), { recursive: true })` before writing.
|
||||
@@ -89,7 +89,7 @@ Modern, elegant, brand-consistent A4 resume: correct print geometry, timeline ex
|
||||
| Aspect | Detail |
|
||||
|---|---|
|
||||
| PDF author metadata | `printToPDF` has no author parameter; Playwright has no `author` option — author metadata is not set. Title comes from HTML `<title>`. |
|
||||
| Open-to-work | The `variant: 'current'` entry is excluded from the PDF entirely (owner decision); full text remains on the site timeline. |
|
||||
| Open-to-work | Superseded 2026-11-02: the `variant: 'current'` entry now ships in the PDF as the first timeline entry, with the accent bullet; the earlier full exclusion (owner decision 2026-10-19) was reversed at the owner's request. |
|
||||
| ATS | Single-column, real bullets, text-first markup kept — chips/pills are visual only, extraction-safe. |
|
||||
| `scripts/` type coverage | `tsconfig.node.json` includes only `vite.config.ts`; the resume script is type-checked only ad hoc. Left as-is (config change out of scope). |
|
||||
| Palette | Resume is locked to the light-mode red palette (print default); no `--palette=` flag. |
|
||||
@@ -127,4 +127,5 @@ Modern, elegant, brand-consistent A4 resume: correct print geometry, timeline ex
|
||||
- [x] Owner follow-up 22 (2026-10-20): **bar resume icon at 24×24** — `ResumeNavButton` now renders `<ResumeIcon size={24} />` instead of the component's 20px default. The glyph is built on the 24 grid (follow-up 19), so at 24px it renders 1:1: strokes land at exactly 2px like every other bar icon and the 6-unit letters become 6px — the size the follow-up 17 notes had already named as the alternative when 20px was the constraint. The 44px target is untouched: `.nav-control`'s 8px padding + 1px border leave a 26px content box, 2px wider than the icon, and the icon now matches the 24px home glyph beside it. Proof: the shipped path strings rasterized at 24px on `#151914` and `#f6f5f2` — dash open at both gaps, both letters clear; `pnpm lint` + `tsc -b` clean.
|
||||
- [x] Owner follow-up 23 (2026-10-20): **tighter brand-group spacing — the left icons carry no borders** — `.nav-brand`'s 12px gap was sized for bordered boxes, but the group's three controls (hamburger, home, resume) are borderless, so the spacing that reads is glyph-to-glyph: 10px of target padding + 12px gap + 10px = 32px between the 24px glyphs. The gap drops to 4px at every width: 24px between glyphs, hover fills stay 4px apart, and two 2px-offset focus rings (2+2px) meet without overlapping. The `@media (max-width: 420px)` rule now only drops the bordered action controls 16px→8px; the brand group needs no narrow-width override because 4px is already below 8px. Width budgets improve at every breakpoint: at 390px, 260px controls + 8px brand gaps + 16px action gaps = 284px inside 358px; at 320px, 284px inside 296px — 12px of slack where the old layout had 4px. All 44px targets unchanged.
|
||||
- [x] Owner follow-up 24 (2026-10-27): **EN resume renamed `resume.pdf` → `resume-en.pdf`; the dialog shows bare filenames** — the EN output now follows the `resume-<lang>.pdf` pattern the VI file already used. `resumeFileNameFor(lang)` in `src/data/resume.ts` is the single source of both names; `resumeUrlFor` is `/` + filename, so the leading slash is a URL concern, not a filename. `scripts/generate-resume.ts` writes `dist/resume-${lang}.pdf` for every language (the `lang === 'en' ? ''` suffix special case is gone); the `resume-pdf-en` artifact path is renamed in both deploy workflows, and `rsync --delete` drops the stale `/resume.pdf` from the server on the first deploy after the change. `ResumeDialog`'s option line renders `resumeFileNameFor` — `resume-en.pdf` / `resume-vi.pdf` — under each language label, while the `href` keeps the absolute path. Proof: `tsc -b` + `pnpm lint` clean; `pnpm build:resume-all` writes `dist/resume-en.pdf` + `dist/resume-vi.pdf`
|
||||
- [x] Owner follow-up 25 (2026-11-02): **open-to-work returns to the resume PDF** — the owner asked for the "Seeking a New Place" entry in the generated PDF, reversing the 2026-10-19 exclusion. `renderExperience` drops the `.filter(exp => exp.variant !== 'current')` leg; the entry flows through the ordinary record path (it already leads `src/data/experience.json` and carries full EN + VI text). The template gains one decoration rule, `.exp-entry.current::before { background: var(--accent); }`, beside the `.gap` block — the accent bullet mirrors the site timeline's live node; text markup and ATS safety are unchanged. Both PDFs regenerated with `pnpm build:resume-all`.
|
||||
- [ ] Owner visual check of `dist/resume-en.pdf` / `dist/resume-vi.pdf` in a real browser/PDF viewer
|
||||
Reference in new issue
Block a user