mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-22 16:10:40 +07:00
fix(hero): single download CTA, no click flash, mobile lazer beam
One trigger at every width opens the language dialog: the details dropdown markup, its CSS, both chevron rules and the hero-download desktop/mobile variants are gone, and @media (max-width: 768px) lets the trigger fill the CTA column like the other two buttons. The trigger carries an open class so the :hover accent fill does not fire at the click instant behind the overlay, and the scrim is a plain colour mix instead of backdrop-filter: blur(4px), which used to repaint the page under the fading overlay. transition: all became explicit background/color transitions. The lazer split was geometric: inset: -200% resolved against the wrapper, so the rotating layer measured 1710x265 for the 342x53 mobile wrapper, and once its short half-side (132.5px) is narrower than the wrapper half-diagonal (173px) the layer stops covering the wrapper's own edges, cutting the beam in two for part of every cycle (14/72 angles). Both layers are now inset: 0 and the spin animates a registered @property --lazer-angle (0deg -> 360deg) instead of rotating a box: 1 lit segment at 72/72 angles on both 342x53 and 167x53, same 4s cycle, and the blurred glow layer shrinks to the wrapper box. Also carries the nav chrome this feature needs: .nav-resume, the borderless .nav-resume-trigger (border-color transparent at rest, hover and open, matching the home icon beside it while keeping the 44px target, hover fill and :focus-visible ring), and the 420px gap plus new 360px padding tightening so six controls fit a 320px viewport. AGENTS.md and docs/design/specs/v3/spec-v3-resume-redesign.md follow-ups 13-17 record all of it.
This commit is contained in:
1 parent
4f1d4ebe30
commit
affca525b4
3 files changed
+180
-81
No files matched your search
@@ -115,4 +115,9 @@ Modern, elegant, brand-consistent A4 resume: correct print geometry, timeline ex
|
||||
- [x] Owner follow-up 10 (2026-10-19): **Zalo removed from the site** — `SocialId` drops `'zalo'`; `Profile.zaloUrl` removed from `src/data/profile.ts` and from the `Profile` interface in `src/types/index.ts`; the zalo entries are gone from `social.ts` and `ContactLinks.tsx` (its `labelKey` union narrows to email/github/linkedin/telegram); `strings.social.aria.zalo` and `strings.contact.zalo` + `zaloSub` deleted; `ZaloIcon` deleted from `icons.tsx`, so the tiles are stroke lucide (mail/github/linkedin) + the filled telegram glyph. Hero, footer and the mobile sheet follow automatically through `SocialLinks`. **Resume QR block unchanged by owner decision** — `resumeQr` keeps `{id: 'zalo', file: 'zalo.jpg'}` and `public/resume-qr/zalo.jpg` stays on disk; only the website drops Zalo. Proof: `pnpm lint` no new warnings, `tsc -b` + `vite build` clean (545 modules, ContactPage chunk 0.53 kB), grep over `src/` finds `zalo` only in `resume.ts`
|
||||
- [x] Owner follow-up 11 (2026-10-19): **header photo + QR gap** — `.header-photo` 72 → 96px; `.header-info` `margin-left` 12 → 24px (clear space for the bigger photo); `.header-qr` keeps `margin-left: auto` and its `gap` goes 18 → **50px**, so the pair stays pinned to the right edge while the Telegram code sits 50px left of Zalo — each code gets its own quiet zone and a scanner cannot land on the wrong one. Measured at the real print content width (180mm = 680px): photo 96×96 at x=0, info x=138, Telegram QR 493.9–562, Zalo QR 612–680 (flush with the right edge), **QR separation 18 → 50.0 px**, 137px clear between the contact info and the Telegram code, all four contact URLs still one line each, nothing overflows the 680px content box. Header height is unchanged (150.8px — the info block, not the photo, is the tallest child), so pagination does not move. QR payloads re-decoded before the move: `telegram.jpg` → `https://t.me/dongdn`, `zalo.jpg` → `https://zaloapp.com/qr/p/14ic4cmkuegf` (assets correctly labelled). Both `resume.pdf` and `resume-vi.pdf` rebuilt (21:25)
|
||||
- [x] Owner follow-up 12 (2026-10-19): **download-resume button removed from the site contact surfaces** — `<DownloadResume />` deleted from `src/components/sections/Contact.tsx` and `src/pages/ContactPage.tsx` (each now ends at `<ContactLinks />`); `DownloadResume()` and its single-language `DownloadButton()` fallback deleted from `src/components/sections/DownloadResume.tsx` (104 → 71 lines, the file exports only `DownloadResumeDropdown`, which is what Hero uses — hero CTA untouched), so the `resumeAvailable` and `Language` imports that only those two components used are gone; the dead `.download-resume-button` rule and its comment deleted from `src/App.css`. `resumeAvailable` stays in `src/data/resume.ts` because Hero gates its CTA on it. Proof: `pnpm lint` unchanged (4 pre-existing warnings), `tsc -b` + `vite build` clean, built CSS 33.69 → 33.60 kB with zero `download-resume-button` hits, ContactPage chunk 0.53 → 0.51 kB, hero CTA classes (`hero-download-dropdown`, `hero-download-summary`, `hero-download-mobile-btn`, `download-resume-option`) and the `/resume.pdf` href still in the bundle
|
||||
- [x] Owner follow-up 13 (2026-10-19): **download CTA unified into one trigger + modal** — `src/components/sections/DownloadResume.tsx` rewritten: one lazer-wrapped button at every width (`aria-haspopup="dialog"`, `aria-expanded`, `aria-controls="resume-modal"`) opening an `AnimatePresence` dialog (`role="dialog" aria-modal="true"`, focus moves into the panel when the open animation ends, Escape / click-outside / the close button return focus to the trigger, `document.body.style.overflow` locked while open, `useClickOutside` hook replaces the old inline listener — the duplication `spec-v3-theme-palette-switch.md:374` flagged). Options come from `resumeLanguages`: `English → /resume.pdf`, `Tiếng Việt → /resume-vi.pdf`, each with `download` and the file name under the label. Hero drops `HeroDownloadButton`, the `Language` import and the `hero-download-desktop` / `hero-download-mobile` split, rendering `{resumeAvailable && <DownloadResume />}` once — mobile gets the same single button as desktop. New chrome strings `resumeModalTitle` / `resumeModalAria` / `resumeModalHint` / `resumeModalClose` in `strings.common`. CSS: `.download-resume` + the `.resume-modal*` block added (overlay `z-index: 1100`, above the 1000 nav), a ≤768px block stretches the trigger to the CTA column width and centres its content; deleted `.download-resume-dropdown`, `.download-resume-options`, `.download-resume-option`, `.download-resume-shared-wrapper`, `.download-resume-summary::-webkit-details-marker`, both chevron rules, `.hero-download-desktop`, `.hero-download-mobile` and their media block. Lazer border/glow kept, chevron dropped. Proof: `pnpm lint` unchanged, `tsc -b` + `vite build` clean (CSS 33.60 → 34.42 kB), built CSS 0 hits for every deleted selector and 15 for `resume-modal`, throwaway SSR render → exactly 1 trigger carrying the dialog aria triple, 0 modal nodes while closed, 0 hits for `hero-download-*` / `download-resume-option*` / `chevron`. Still open for the owner's real-browser check: open/close, Escape, focus return, and the full-width trigger at ≤768px
|
||||
- [x] Owner follow-up 14 (2026-10-19): **colour flash on click fixed** — two causes. (a) The trigger flipped to the `--accent` fill at the instant of the click: the pointer is still on the button so `:hover` fires, and the leftover `.download-resume-summary.open` rule (solid accent, which the rewritten component never applied — dead CSS) agreed with it, so the button went solid accent behind the semi-transparent overlay. The trigger now carries `open` from state and `.download-resume-summary.open, .download-resume-summary.open:hover` hold it at the resting look (`background: transparent; color: var(--accent)`); a `@media (hover: none)` block does the same for the sticky tap-hover on touch devices. (b) `.resume-modal-overlay` had `backdrop-filter: blur(4px)` over a 60% `--bg-primary` scrim: `AnimatePresence` mounts the element on the first frame, so the blur landed at full strength while its opacity was still animating — the page behind jumped before the dialog arrived. `backdrop-filter` removed, scrim raised to 78% `--bg-primary`, and overlay and panel now share `duration: 0.18` so scrim and dialog read as one motion. `transition: all` on the trigger replaced by `background, color` (repo rule: a control never carries `transition: all`). Proof from the built CSS: the trigger carries `transition:background …, color …`, zero `transition:all` in the bundle, `.download-resume-summary.open,.download-resume-summary.open:hover{color:var(--accent);background:0 0}` present, `.resume-modal-overlay` has no `backdrop-filter`. Open/close feel still needs the owner's real-browser check
|
||||
- [x] Owner follow-up 15 (2026-10-20): **mobile lazer no longer splits into two segments** — the cause is geometric, not colour. `.download-resume-lazer-border` / `.download-resume-lazer-glow` used `inset: -200%`, which resolves against the wrapper's own width and height, so the rotating layer measured **1710×265** on the 342×53 mobile wrapper (167×53 on desktop). `@keyframes download-resume-lazer-spin` rotated that box, and once its short half-side (132.5px) is narrower than the wrapper's half-diagonal (173px) the layer stops covering the wrapper's own edges: the lit band gets cut and the beam reads as two parts. Desktop never showed it (132.5 > 87.6 half-diagonal), which is why only the full-width mobile button looked broken. Fix: both layers are now `inset: 0` — exactly the wrapper box, so coverage is complete at every angle — and the spin animates the gradient itself through a registered `@property --lazer-angle { syntax: '<angle>'; inherits: false; initial-value: 0deg }` (`from var(--lazer-angle, 0deg)`, keyframes `0deg → 360deg`) instead of rotating a box: same 4s cycle, same arc stops, and the painted layer shrinks from 1710×265 to the wrapper box, which also cuts the cost of the `blur(12px)` glow. Proof: geometry model over 72 rotation angles — old box **1 segment on 58/72 and 2 segments on 14/72** at 342×53, 1/1 at 167×53; new geometry **1 segment on 72/72** at both sizes. Playwright probe against the production build: ring layer rect now equals the wrapper (342×53 mobile, 167×53 desktop), `--lazer-angle` advances 81° → 190° in 1.2s (4s per turn) with `animation-name: download-resume-lazer-spin`, and `@property --lazer-angle{syntax:"<angle>";inherits:false;initial-value:0deg}` is in the built CSS. `prefers-reduced-motion` keeps `animation: none`, which now parks the beam at the registered `initial-value: 0deg`
|
||||
- [x] Owner follow-up 16 (2026-10-20): **resume entry in the navigation bar** — `src/components/layout/ResumeNavButton.tsx` is the third item in `.nav-brand`, right after the home icon: a `nav-control nav-resume-trigger` 44px icon box (`ResumeIcon` added to `src/components/ui/icons.tsx` — lucide `file-down`, 20px `currentColor` stroke, `aria-hidden`), named by `strings.nav.resume` (`Get resume` / `Tải CV`), `title` = the modal hint, `aria-haspopup="dialog"` / `aria-expanded` / `aria-controls="resume-modal-nav"`, gated on `resumeAvailable`. The dialog is no longer duplicated: `src/components/ui/ResumeDialog.tsx` owns the overlay + panel + `resumeLanguages` options and takes a `dialogId`, so the hero trigger keeps `#resume-modal` and the bar trigger gets `#resume-modal-nav` — one markup source, no duplicate ids. `src/hooks/useResumeDialog.ts` holds the state both triggers share (open flag, container/trigger/panel refs, `useClickOutside`, Escape, body-overflow lock, focus return); `close` is guarded on an `openRef` because the click-outside listener is live even while closed — unguarded it pulled focus to the trigger on every click anywhere on the page. Panel focus moved from `onAnimationComplete` to a one-frame `useEffect` keyed on `open`: `AnimatePresence` keeps the open=true props on its exiting copy, so the old handler fired again at the end of the exit animation, focused the panel and stranded focus on `<body>` when it unmounted (measured `body` before, `BUTTON.nav-control.nav-resume-trigger` after). `resumeAvailable` moved out of Hero's JSX into the leaf components, so Hero renders `<DownloadResume />` plainly. CSS: `.nav-resume { display: flex }`; `@media (max-width: 420px)` now tightens `.nav-brand` **and** `.nav-actions` to 8px gaps and a new `@media (max-width: 360px)` drops the container padding to 12px — six controls (40 + 44×5 = 260px) overflowed at the old 12px gaps (`.nav-container` scrollWidth 324 > 320), and after the change 320 measures 320 = 320 with 360/390/420/1024/1280 clean and the resume box at 44×44. Probe on the production build: bar control 44×44 with the full aria triple, `#resume-modal-nav` opens with 2 `download` options (`/resume.pdf`, `/resume-vi.pdf`), focus lands on the panel, Escape and the close button return focus to the trigger, an overlay/outside click leaves focus where the user clicked, `body.style.overflow` locks and restores, and the hero trigger is still exactly 1 with its own `#resume-modal`. `pnpm lint` unchanged (4 pre-existing warnings), `tsc -b` + `vite build` clean (CSS 34.65 → 34.71 kB). Owner check in a real browser: the glyph's look and position in the bar, and the row at 320–420px
|
||||
- [x] Owner follow-up 17 (2026-10-20): **bar resume icon — no border, CV lettering** — `.nav-resume-trigger` overrides the shared chrome with `border-color: transparent` in one rule group covering rest, `:hover` and `.open`, so the entry reads like its borderless neighbour `.nav-logo` while keeping the 44px target, the `--bg-elevated` hover fill and the `:focus-visible` ring. `ResumeIcon` replaced (lucide `file-down` → drawn lettering): `M13.5 7.8A6.5 6.5 0 1 0 13.5 16.2` (C, open to the right) + `M15 6l3.5 12L22 6` (V). The shape was chosen by rasterizing candidates at the bar's real 20px and reading the silhouette: a page outline with small `CV` inside, and a page outline with a `CV` band, both merge into unreadable mush at 20px; the letters alone stay legible, so no document frame. The owner's Flaticon artwork (#6588184) was not fetched or copied — the page returns 403 to this environment and the session has no vision model to inspect a raster — so the glyph is original work in the bar's existing 2px `currentColor` stroke language; an exact match needs the owner to supply the SVG. Proof: built CSS `.nav-resume-trigger,.nav-resume-trigger:hover,.nav-resume-trigger.open{border-color:#0000}`; live computed style at rest `rgba(0,0,0,0)` border with a 44×44 box and a 20×20 icon, on hover border still `rgba(0,0,0,0)` with `--bg-elevated` fill and `--accent` icon; the two path strings are the only resume paths in the bundle; the shipped paths rasterized at 20px read as `C` + `V`
|
||||
- [ ] Owner visual check of `dist/resume.pdf` / `dist/resume-vi.pdf` in a real browser/PDF viewer
|
||||
Reference in new issue
Block a user