diff --git a/docs/design/specs/v3/spec-v3-theme-palette-gasatrya.md b/docs/design/specs/v3/spec-v3-theme-palette-gasatrya.md index 55551b9..b2e0759 100644 --- a/docs/design/specs/v3/spec-v3-theme-palette-gasatrya.md +++ b/docs/design/specs/v3/spec-v3-theme-palette-gasatrya.md @@ -317,7 +317,7 @@ New structure: **one dark block + one light block + one media bridge** (removes `@media (prefers-color-scheme: dark) { :root:not([data-theme='light']) { … } }` is **deleted**: its values are identical to `:root`, so it can never change anything. -`.skip-link` (`src/index.css:265-275`): `background: var(--accent); color: white;` → `color: var(--text-on-accent);`. **Moot in the shipped tree:** the block was deleted in the working tree and no component renders `.skip-link`; `strings.skipLink` is unused. +`.skip-link` (`src/index.css:265-275`): `background: var(--accent); color: white;` → `color: var(--text-on-accent);`. **Closed:** the block was deleted in the working tree, no component renders `.skip-link`, and `strings.skipLink` has been removed too — `grep -i skip` over `src/` → 0 matches. ### 4.2 `index.html` — prevent first-paint flash @@ -426,7 +426,7 @@ New structure: **one dark block + one light block + one media bridge** (removes - [x] Rebuilt after the second pass: `tsc -b` exit 0; `vite build` 538 modules, 26.04 kB CSS — built CSS carries `#b04138`, `#a8382f`, `#9b3229` (×2 each: light block + media bridge) and `#f06060`, with no `#b91c1c`, no `#7f1d1d`, no blue - [x] Third pass (user feedback): the translucent `--accent-soft` panel let the conic lazer sweep show through the whole button — replaced with the new **opaque** token `--accent-tint` (light `#f5e3e1`, dark `#2f1e1a`) on `.download-resume-lazer-inner` (`src/App.css:835`), so the sweep is visible only in the 2 px ring - [x] Third pass verified: `tsc -b` exit 0; `vite build` → 26.11 kB CSS; compiled rule is `.download-resume-lazer-inner{…background:var(--accent-tint)…}` and the built CSS carries `#2f1e1a` ×1 and `#f5e3e1` ×2 (light block + bridge). Accent label on the solid tint: 4.63 light / 5.74 dark; primary ink on it 14.36 / 14.58 -- [ ] **B7** reclassified — the `.skip-link` rules were deleted from `src/index.css` in the working tree (not by this change) and no component renders the class; `strings.skipLink` (`src/i18n/strings.ts:98`) is now an unused string. Either restore markup + CSS or delete the string; nothing left to tokenize +- [x] **B7** closed — the `.skip-link` rules were deleted from `src/index.css` in the working tree (not by this change), no component renders the class, and `strings.skipLink` has since been removed as well; nothing left to tokenize or delete ## 7. Verification plan @@ -498,5 +498,5 @@ New structure: **one dark block + one light block + one media bridge** (removes - Manual browser pass (§7 item 4) is the user's; the palette has not been verified headlessly, per project rule. - `pnpm build` end-to-end blocked by the nginx `dist/` mount — needs `docker compose stop` before a real production build, or a different out dir. - `pnpm lint` dirty at baseline (15 errors + 9 warnings, all `react-hooks(rules-of-hooks)` in `.tsx` files this change never touched). -- `.skip-link` orphan decision (§6, B7). +- ~~`.skip-link` orphan decision (§6, B7)~~ — closed: no markup, no CSS, no string (`grep -i skip` over `src/` → 0 matches). Restoring it would be a new feature, not a cleanup. - Hairline grid adoption deferred (§9 item 3). diff --git a/docs/design/specs/v3/spec-v3-typography.md b/docs/design/specs/v3/spec-v3-typography.md index fd56268..5651905 100644 --- a/docs/design/specs/v3/spec-v3-typography.md +++ b/docs/design/specs/v3/spec-v3-typography.md @@ -4,7 +4,7 @@ > **Version:** 1.0.0 > **Parent:** `spec.md` (IA/content readability), sibling of `spec-v3-theme-palette-gasatrya.md` > **Priority:** P1 -> **Status:** Implemented in source. `tsc -b` and the production build are green; the visual pass is the user's in a real browser (project rule: no headless verification). +> **Status:** Implemented. TSX sweep done, `Card` deleted, `tsc -b` and the production build are green; the visual pass is the user's in a real browser (project rule: no headless verification). --- @@ -63,7 +63,7 @@ Reading bands used: 45-75 characters (Bringhurst), 38-80 (Butterick). Before: 11 - `--sans` → system stack (finding P5). `--mono` unchanged (it already ends in `ui-monospace, monospace`, so it resolves without a download). - `h3 { font-size: 21px }`; new `h4 { 18px }`, `h5 { 16px }`, `h6 { 15px }`. - `p { font-size: var(--text-body); line-height: var(--leading-body); color: var(--text-secondary); }` — was implicit 16px / 1.7. -- `.container-narrow` deleted (no consumer). +- `.container-narrow` deleted (no consumer), including its two leftover entries in the responsive padding selector lists. ### 4.2 `src/App.css` @@ -90,6 +90,7 @@ Prose system (rewritten in place of the dead `.prose` block): .contact-link-sub { font-size: var(--text-meta); line-height: 1.5; color: var(--text-muted); } .achievement-impact { font-size: var(--text-meta); line-height: var(--leading-body); color: var(--text-secondary); margin-bottom: 8px; } .achievement-metrics { margin-bottom: 8px; } +.download-resume-button { justify-content: center; padding 12px 20px; color text-primary; } /* variant of .contact-link; replaces the DownloadButton inline style */ ``` Existing rules retuned to the scale: @@ -119,7 +120,7 @@ Deleted as dead (no component rendered any of them; verified by grepping every c | `src/pages/ExperiencePage.tsx`, `src/components/sections/Experience.tsx` | impact div → `.achievement-impact`; metrics wrapper → `.achievement-metrics`; `maxWidth:'700px'` → `.page-body` | | `src/pages/ContactPage.tsx`, `src/components/sections/Contact.tsx` | label divs → `.link-label`; sub-labels → `.contact-link-sub`; `maxWidth:'700px'` → `.page-body` | | `src/components/sections/Projects.tsx` | "view all" link → `.section-cta` | -| `src/components/sections/DownloadResume.tsx` | option label → `.link-label` | +| `src/components/sections/DownloadResume.tsx` | option label → `.link-label`; `DownloadButton` inline layout + `color` → `className="contact-link download-resume-button"` | | `src/components/ui/Card.tsx` | deleted; export removed from `src/components/index.ts` | ## 5. Affected files @@ -127,7 +128,7 @@ Deleted as dead (no component rendered any of them; verified by grepping every c | File | Change | |---|---| | `src/index.css` | token block (5 added, `--max-narrow` deleted), `--sans`, `h3`-`h6`, `p`, `.container-narrow` deleted | -| `src/App.css` | prose system added/rewritten, 10 selectors retuned, ~170 lines of dead CSS deleted | +| `src/App.css` | prose system added/rewritten, 10 selectors retuned, `.download-resume-button` added, ~170 lines of dead CSS deleted | | 8 page/section TSX files | inline type styles → classes (see §4.3) | | `src/components/ui/Card.tsx` | deleted | | `src/components/index.ts` | `Card` export removed | @@ -144,8 +145,8 @@ Deleted as dead (no component rendered any of them; verified by grepping every c - [x] 10 existing selectors retuned to the scale - [x] Dead CSS deleted, `Card` component deleted - [x] Philosophy page: prose column, paragraph spacing, no nested `

`, ARIA id wired -- [ ] Inline type styles removed from the 8 TSX files — in flight, tracked here -- [ ] `tsc -b` + `vite build` green after the TSX sweep +- [x] Inline type styles removed from the 8 TSX files — gate `style=\{\{[^}]*(fontSize|lineHeight|fontWeight|color|maxWidth)` over `src/` → 0 matches +- [x] `tsc -b` + `vite build` green after the TSX sweep - [ ] Manual browser pass (§7) on `/`, `/about`, `/experience`, `/projects`, `/projects/:id`, `/philosophy`, `/contact`, dark and light ## 7. Verification plan @@ -153,6 +154,9 @@ Deleted as dead (no component rendered any of them; verified by grepping every c 1. `pnpm exec tsc -b` → exit 0 (the `Card` deletion must not leave an import behind). 2. `pnpm exec vite build --outDir dist-verify` → module count and CSS size; grep the built CSS for `--text-body`, `--measure-prose`, `.prose-lede`, and for the absence of `.card{`, `.form-input`, `.filter-pill`, `.article-card`, `.engineering-tab`, `.breadcrumb`, `.page-header`, `.container-narrow`. 3. Grep gate: `style=\{\{[^}]*(fontSize|lineHeight|fontWeight|color|maxWidth)` over `src/**/*.tsx` → zero matches; `grep "Card"` over `src/` → zero matches. + Result: 538 modules, CSS 24.8 KB (5.37 KB gzip). Built CSS contains `--text-body`, `--measure-prose`, `.prose-lede`, `.prose`, `.page-body`, `.subheading`, `.project-section`, `.back-link`, `.section-cta`, `.link-label`, `.contact-link-sub`, `.achievement-impact`, `.achievement-metrics`, `.philosophy-quote`, `.download-resume-button`; zero hits for `.card{`, `card-elevated`, `card-featured`, `form-*`, `filter-*`, `article-*`, `engineering-tab*`, `breadcrumb*`, `page-header`, `container-narrow`, `--max-narrow`. `grep "Card"` over `src/` → 0 matches. + + oxlint against HEAD and against the working tree produce identical diagnostics (15 errors / 9 warnings): every one is pre-existing — oxlint treats the `useField` / `useFieldArray` helpers in `src/i18n/useField.ts` as hooks, plus `Navigation.tsx:26` `set-state-in-effect`. Out of scope here. 4. Manual, real browser (no headless, per project rule): - `/philosophy`: three paragraphs visibly separated, ~600px column, 18px body, quote title 21px, no wall of text. - `/about`: bio 20px capped at 600px, section titles 21px, cards unchanged in width. @@ -174,5 +178,5 @@ Deleted as dead (no component rendered any of them; verified by grepping every c ## 9. Open questions 1. **Wire Source Sans 3 later?** It is already shipped and used by the PDF, and gasatrya uses it. Cost: four `@font-face` rules, ~75 KB per weight, and its x-height is 0.486 em vs Segoe UI's 0.500 — the scale would need +1px to read the same. Deferred by user decision. -2. **`.skip-link` orphan** (shared with the palette spec): the rules were deleted from `src/index.css` in the working tree and no component renders the class, while `strings.skipLink` (`src/i18n/strings.ts:98`) still exists. Restore markup + CSS or delete the string. +2. ~~**`.skip-link` orphan**~~ — closed. `strings.skipLink` no longer exists either: `grep -i skip` over `src/` → 0 matches, so there is no orphan left in either direction. 3. **`--leading-body` 1.65 vs the old 1.7** — 1.7 was applied only to `p`; 1.65 is now applied to body copy in every element role. Whether 1.6 or 1.7 reads better at 18px is a call for the manual pass. diff --git a/src/App.css b/src/App.css index f043410..e79e691 100644 --- a/src/App.css +++ b/src/App.css @@ -1067,7 +1067,7 @@ } } -/* ===== Project Cards Grid ===== */ +/* ===== Projects Grid ===== */ .projects-grid { display: grid; grid-template-columns: repeat(2, 1fr); @@ -1232,6 +1232,13 @@ color: var(--text-muted); } +/* Resume download button variant of the contact tile */ +.download-resume-button { + justify-content: center; + padding: 12px 20px; + color: var(--text-primary); +} + @media (max-width: 768px) { .contact-links { flex-direction: column; diff --git a/src/components/index.ts b/src/components/index.ts index 4027856..421d86e 100644 --- a/src/components/index.ts +++ b/src/components/index.ts @@ -1,7 +1,6 @@ export { Button } from './ui/Button' export { Badge } from './ui/Badge' export { Tag } from './ui/Tag' -export { Card } from './ui/Card' export { SectionHeading } from './ui/SectionHeading' export { SocialLinks } from './ui/SocialLinks' export { Navigation } from './layout/Navigation' diff --git a/src/components/sections/About.tsx b/src/components/sections/About.tsx index 0d32870..138bb03 100644 --- a/src/components/sections/About.tsx +++ b/src/components/sections/About.tsx @@ -11,12 +11,12 @@ export function About() {

-
-

+

+

{useField(profile.bio, profile.bioEn)}

-

+

{strings.about.engineeringTitle[lang]}

@@ -33,7 +33,7 @@ export function About() { ))}
-

+

{strings.about.exploringTitle[lang]}

diff --git a/src/components/sections/Contact.tsx b/src/components/sections/Contact.tsx index 375a99f..8ffe0ff 100644 --- a/src/components/sections/Contact.tsx +++ b/src/components/sections/Contact.tsx @@ -22,7 +22,7 @@ export function Contact() { > -
+
-
+
{strings.contact.email[lang]}
-
+
{profile.email}
@@ -67,10 +67,10 @@ export function Contact() {
-
+
{strings.contact.github[lang]}
-
+
@yourusername
@@ -92,10 +92,10 @@ export function Contact() {
-
+
{strings.contact.linkedin[lang]}
-
+
Your Name
diff --git a/src/components/sections/DownloadResume.tsx b/src/components/sections/DownloadResume.tsx index 03f233e..7db5685 100644 --- a/src/components/sections/DownloadResume.tsx +++ b/src/components/sections/DownloadResume.tsx @@ -77,23 +77,12 @@ function DownloadButton({ lang }: { lang: Language }) { -
{strings.common.resumeDownload[currentLang]} {resumeLanguageLabels[lang]}
+
{strings.common.resumeDownload[currentLang]} {resumeLanguageLabels[lang]}
) } diff --git a/src/components/sections/Experience.tsx b/src/components/sections/Experience.tsx index ccfd17b..483f558 100644 --- a/src/components/sections/Experience.tsx +++ b/src/components/sections/Experience.tsx @@ -25,7 +25,7 @@ export function Experience() { }} > -
+
{experiences.map((exp, i) => ( {useField(achievement.context, achievement.contextEn)}
-
+
{useField(achievement.impact, achievement.impactEn)}
{achievement.metrics && achievement.metrics.length > 0 && ( -
+
{achievement.metrics.map((m) => ( {m} diff --git a/src/components/sections/Projects.tsx b/src/components/sections/Projects.tsx index 3ce995d..1179a6f 100644 --- a/src/components/sections/Projects.tsx +++ b/src/components/sections/Projects.tsx @@ -33,7 +33,7 @@ export function Projects() { {strings.projects.viewAll[lang]} → diff --git a/src/components/ui/Card.tsx b/src/components/ui/Card.tsx deleted file mode 100644 index 453f2fc..0000000 --- a/src/components/ui/Card.tsx +++ /dev/null @@ -1,31 +0,0 @@ -import { forwardRef } from 'react' -import type { ComponentPropsWithoutRef } from 'react' - -type CardVariant = 'default' | 'elevated' | 'featured' - -interface CardProps extends ComponentPropsWithoutRef<'div'> { - variant?: CardVariant - children: React.ReactNode -} - -const variantClasses: Record = { - default: 'card', - elevated: 'card card-elevated', - featured: 'card card-featured', -} - -export const Card = forwardRef( - ({ variant = 'default', className = '', children, ...props }, ref) => { - return ( -
- {children} -
- ) - } -) - -Card.displayName = 'Card' diff --git a/src/index.css b/src/index.css index 4772106..b51a1a3 100644 --- a/src/index.css +++ b/src/index.css @@ -239,8 +239,7 @@ pre code { padding: 48px 0; } .container-wide, - .container-content, - .container-narrow { + .container-content { padding-left: 32px; padding-right: 32px; } @@ -248,8 +247,7 @@ pre code { @media (min-width: 769px) and (max-width: 1200px) { .container-wide, - .container-content, - .container-narrow { + .container-content { padding-left: 40px; padding-right: 40px; } diff --git a/src/pages/AboutPage.tsx b/src/pages/AboutPage.tsx index b00138a..0df193b 100644 --- a/src/pages/AboutPage.tsx +++ b/src/pages/AboutPage.tsx @@ -18,12 +18,12 @@ export function AboutPage() { subtitle={strings.about.subtitle[lang]} tag={strings.about.heading[lang]} /> -
-

+

+

{useField(profile.bio, profile.bioEn)}

-

+

{strings.about.engineeringTitle[lang]}

@@ -40,7 +40,7 @@ export function AboutPage() { ))}
-

+

{strings.about.exploringTitlePage[lang]}

diff --git a/src/pages/ContactPage.tsx b/src/pages/ContactPage.tsx index 2498b83..a50a873 100644 --- a/src/pages/ContactPage.tsx +++ b/src/pages/ContactPage.tsx @@ -15,8 +15,8 @@ export function ContactPage() {
-
{strings.contact.email[lang]}
-
{profile.email}
+
{strings.contact.email[lang]}
+
{profile.email}
@@ -24,8 +24,8 @@ export function ContactPage() {
-
{strings.contact.github[lang]}
-
@dong-nz
+
{strings.contact.github[lang]}
+
@dong-nz
@@ -33,8 +33,8 @@ export function ContactPage() {
-
{strings.contact.linkedin[lang]}
-
@dong-nz
+
{strings.contact.linkedin[lang]}
+
@dong-nz
diff --git a/src/pages/ExperiencePage.tsx b/src/pages/ExperiencePage.tsx index 99a1c8c..2757547 100644 --- a/src/pages/ExperiencePage.tsx +++ b/src/pages/ExperiencePage.tsx @@ -30,11 +30,11 @@ export function ExperiencePage() {
{achievement.title}
{useField(achievement.context, achievement.contextEn)}
-
+
{useField(achievement.impact, achievement.impactEn)}
{achievement.metrics && achievement.metrics.length > 0 && ( -
+
{achievement.metrics.map((m) => ( {m} diff --git a/src/pages/PhilosophyPage.tsx b/src/pages/PhilosophyPage.tsx index 27741f8..8ee723e 100644 --- a/src/pages/PhilosophyPage.tsx +++ b/src/pages/PhilosophyPage.tsx @@ -6,17 +6,18 @@ import {strings} from '@/i18n/strings' export function PhilosophyPage() { const {lang} = useLanguage() return ( -
- - {strings.philosophy.quotes.map((quote) => ( -
-

- {quote.title[lang]} -

- {/* Placeholder for expanded content */} -

-

- ))} +
+ +
+ {strings.philosophy.quotes.map((quote) => ( +
+

+ {quote.title[lang]} +

+
+
+ ))} +
) } diff --git a/src/pages/ProjectDetailPage.tsx b/src/pages/ProjectDetailPage.tsx index 445da28..eda70b0 100644 --- a/src/pages/ProjectDetailPage.tsx +++ b/src/pages/ProjectDetailPage.tsx @@ -25,7 +25,7 @@ export function ProjectDetailPage() { return (
- + {strings.projectDetail.backToProjects[lang]} ← @@ -34,49 +34,51 @@ export function ProjectDetailPage() { {strings.projects.categories[project.category][lang]}
-

+

{useField(project.summary, project.summaryEn)}

- {project.metrics && project.metrics.length > 0 && ( -
-

{strings.projectDetail.impact[lang]}

-
- {project.metrics.map((m) => ( - - {m} - +
+ {project.metrics && project.metrics.length > 0 && ( +
+

{strings.projectDetail.impact[lang]}

+
+ {project.metrics.map((m) => ( + + {m} + + ))} +
+
+ )} + +
+

{strings.projectDetail.role[lang]}

+

{project.role}

+
+ +
+

{strings.projectDetail.technologies[lang]}

+
+ {project.technologies.map((tech) => ( + {tech} ))}
- )} -
-

{strings.projectDetail.role[lang]}

-

{project.role}

+ {project.sections && project.sections.length > 0 && ( +
+

{strings.projectDetail.experiments[lang]}

+ {project.sections.map((section, idx) => ( +
+

{useField(section.title, section.titleEn)}

+

{useField(section.content, section.contentEn)}

+ {section.type} +
+ ))} +
+ )}
- -
-

{strings.projectDetail.technologies[lang]}

-
- {project.technologies.map((tech) => ( - {tech} - ))} -
-
- - {project.sections && project.sections.length > 0 && ( -
-

{strings.projectDetail.experiments[lang]}

- {project.sections.map((section, idx) => ( -
-

{useField(section.title, section.titleEn)}

-

{useField(section.content, section.contentEn)}

- {section.type} -
- ))} -
- )}
) }