mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-23 00:20:40 +07:00
feat: drop site Zalo, widen resume header, remove contact download button
- site: Zalo removed from SocialId, Profile, social.ts, ContactLinks, strings and icons.tsx; the resume QR block keeps Zalo by owner decision - resume: .header-photo 72 -> 96px, .header-info margin-left 12 -> 24px, .header-qr gap 18 -> 50px so the Telegram code sits clear of Zalo - contact: <DownloadResume /> removed from the Contact section and ContactPage; DownloadResume() + DownloadButton() and the dead .download-resume-button rule deleted, Hero CTA untouched
This commit is contained in:
1 parent
2573977508
commit
25b0ead76a
15 files changed
+19
-73
No files matched your search
@@ -112,4 +112,7 @@ Modern, elegant, brand-consistent A4 resume: correct print geometry, timeline ex
|
||||
- [x] Owner follow-up 8 (2026-10-19): Telegram + Zalo added to website social links — `SocialId` extended (`telegram`, `zalo`), `Profile.telegramUrl` (`https://t.me/dongdn`) + `Profile.zaloUrl` (`https://zaloapp.com/qr/p/14ic4cmkuegf`, same target as the resume QR), two entries appended in `social.ts`, aria labels en/vi in `strings.social.aria`; new `TelegramIcon` + `ZaloIcon` in `icons.tsx` as **simple-icons brand glyphs** (monochrome `currentColor`; lucide dropped brand icons — `lucide:telegram` 404s) — so the tiles are stroke lucide (mail/github/linkedin) + filled brand glyphs (telegram/zalo). Hero, footer, and the mobile sheet pick up all 5 tiles automatically via `SocialLinks`. Verified: `tsc -b` pass, bundle contains both hrefs + both aria labels exactly once, lint unchanged
|
||||
- [x] Throwaway strict typecheck of `scripts/generate-resume.ts` — clean (temp config removed)
|
||||
- [x] Owner follow-up 9 (2026-10-19): Telegram + Zalo cards added to contact — new shared `src/components/ui/ContactLinks.tsx` renders all 5 cards (email, github, linkedin, telegram, zalo) from `profile` + `strings.contact` (new labels `telegram`/`zalo`, new `Profile.telegramHandle`); **`Contact.tsx` (98→34 lines) and `ContactPage.tsx` (83→29 lines) deduplicated** — the two hand-copied card lists (root cause of the follow-up 7 miss) are gone, both consumers render `<ContactLinks />`; Zalo card sub is `zaloapp.com/qr/p/14ic4cmkuegf` (URL minus protocol; swap to `zalo.me/<phone>` if owner supplies the number). Proof: throwaway SSR render → exactly 5 `contact-link` anchors with correct href/target/rel (mailto has none) incl. `t.me/dongdn` + `@dongdn`; `pnpm build` + sitemap clean (ContactPage chunk 2.04 → 0.53 kB), lint unchanged. Also unblocked: viewer closed → both resume PDFs rebuilt (14:34)
|
||||
- [x] Owner follow-up 10 (2026-10-19): **Zalo removed from the site** — `SocialId` drops `'zalo'`; `Profile.zaloUrl` removed from `src/data/profile.ts` and from the `Profile` interface in `src/types/index.ts`; the zalo entries are gone from `social.ts` and `ContactLinks.tsx` (its `labelKey` union narrows to email/github/linkedin/telegram); `strings.social.aria.zalo` and `strings.contact.zalo` + `zaloSub` deleted; `ZaloIcon` deleted from `icons.tsx`, so the tiles are stroke lucide (mail/github/linkedin) + the filled telegram glyph. Hero, footer and the mobile sheet follow automatically through `SocialLinks`. **Resume QR block unchanged by owner decision** — `resumeQr` keeps `{id: 'zalo', file: 'zalo.jpg'}` and `public/resume-qr/zalo.jpg` stays on disk; only the website drops Zalo. Proof: `pnpm lint` no new warnings, `tsc -b` + `vite build` clean (545 modules, ContactPage chunk 0.53 kB), grep over `src/` finds `zalo` only in `resume.ts`
|
||||
- [x] Owner follow-up 11 (2026-10-19): **header photo + QR gap** — `.header-photo` 72 → 96px; `.header-info` `margin-left` 12 → 24px (clear space for the bigger photo); `.header-qr` keeps `margin-left: auto` and its `gap` goes 18 → **50px**, so the pair stays pinned to the right edge while the Telegram code sits 50px left of Zalo — each code gets its own quiet zone and a scanner cannot land on the wrong one. Measured at the real print content width (180mm = 680px): photo 96×96 at x=0, info x=138, Telegram QR 493.9–562, Zalo QR 612–680 (flush with the right edge), **QR separation 18 → 50.0 px**, 137px clear between the contact info and the Telegram code, all four contact URLs still one line each, nothing overflows the 680px content box. Header height is unchanged (150.8px — the info block, not the photo, is the tallest child), so pagination does not move. QR payloads re-decoded before the move: `telegram.jpg` → `https://t.me/dongdn`, `zalo.jpg` → `https://zaloapp.com/qr/p/14ic4cmkuegf` (assets correctly labelled). Both `resume.pdf` and `resume-vi.pdf` rebuilt (21:25)
|
||||
- [x] Owner follow-up 12 (2026-10-19): **download-resume button removed from the site contact surfaces** — `<DownloadResume />` deleted from `src/components/sections/Contact.tsx` and `src/pages/ContactPage.tsx` (each now ends at `<ContactLinks />`); `DownloadResume()` and its single-language `DownloadButton()` fallback deleted from `src/components/sections/DownloadResume.tsx` (104 → 71 lines, the file exports only `DownloadResumeDropdown`, which is what Hero uses — hero CTA untouched), so the `resumeAvailable` and `Language` imports that only those two components used are gone; the dead `.download-resume-button` rule and its comment deleted from `src/App.css`. `resumeAvailable` stays in `src/data/resume.ts` because Hero gates its CTA on it. Proof: `pnpm lint` unchanged (4 pre-existing warnings), `tsc -b` + `vite build` clean, built CSS 33.69 → 33.60 kB with zero `download-resume-button` hits, ContactPage chunk 0.53 → 0.51 kB, hero CTA classes (`hero-download-dropdown`, `hero-download-summary`, `hero-download-mobile-btn`, `download-resume-option`) and the `/resume.pdf` href still in the bundle
|
||||
- [ ] Owner visual check of `dist/resume.pdf` / `dist/resume-vi.pdf` in a real browser/PDF viewer
|
||||
Reference in new issue
Block a user