mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-22 16:10:40 +07:00
feat(theme): improve dark theme palette and soften light theme
- Dark theme: shift from near-black (#0a0a0a) to deep slate (#0f1117) - Dark theme: softer text colors for reduced eye strain - Dark theme: add missing --error variable to default :root - Light theme: soften from pure white to off-white (#ececee) - Light theme: add contrast to --bg-surface (#e0e0e3) - Remove gradient background (caused flicker on scroll) - Add position: relative to .hero for stacking context - Update spec-v3-theme-colors.md with correct implementation
This commit is contained in:
1 parent
3d28d8523b
commit
cce04a6e78
3 files changed
+218
-28
No files matched your search
@@ -0,0 +1,193 @@
|
||||
# Specification — v3 Theme Colors
|
||||
|
||||
> **Document:** `spec-v3-theme-colors.md`
|
||||
> **Version:** 0.1.0
|
||||
> **Parent:** `spec-v2.md`
|
||||
> **Priority:** P2
|
||||
> **Estimate:** ~2 hours
|
||||
|
||||
---
|
||||
|
||||
## Problem
|
||||
|
||||
The current dark theme is too dark:
|
||||
|
||||
| Variable | Value | Perception |
|
||||
|----------|-------|------------|
|
||||
| `--bg-primary` | `#0a0a0a` | Near absolute black |
|
||||
| `--bg-surface` | `#141414` | Very dark |
|
||||
| `--bg-elevated` | `#1a1a1a` | Dark |
|
||||
| `--border` | `#2a2a2a` | Faint on dark background |
|
||||
|
||||
Causes eye strain during prolonged viewing, especially in dim rooms. Lacks visual depth between layers.
|
||||
|
||||
---
|
||||
|
||||
## Goal
|
||||
|
||||
Improve the dark theme:
|
||||
|
||||
1. Reduce extreme contrast (shift from `#0a0a0a` to a deeper gray tone)
|
||||
2. Add subtle gradient background for depth
|
||||
3. Maintain accessibility (WCAG AA contrast ratio >= 4.5:1 for text)
|
||||
4. Do not break existing layout
|
||||
|
||||
---
|
||||
|
||||
## Implementation
|
||||
|
||||
### 1. Dark Theme Color Palette
|
||||
|
||||
Replace with a deep gray palette with slight warmth:
|
||||
|
||||
```css
|
||||
:root {
|
||||
--bg-primary: #0f1117; /* from #0a0a0a — very deep gray, warmer */
|
||||
--bg-surface: #161922; /* from #141414 — deep blue-gray */
|
||||
--bg-elevated: #1c2030; /* from #1a1a1a — lighter blue-gray */
|
||||
--bg-gradient-start: #0f1117;
|
||||
--bg-gradient-end: #161922;
|
||||
--text-primary: #e8eaed; /* from #f0f0f0 — slightly easier on eyes */
|
||||
--text-secondary: #9aa0a6; /* from #a0a0a0 — neutral gray */
|
||||
--text-muted: #6b7280; /* from #666666 — clearer gray */
|
||||
--accent: #60a5fa; /* unchanged */
|
||||
--accent-hover: #93c5fd; /* unchanged */
|
||||
--accent-active: #3b82f6; /* unchanged */
|
||||
--border: #2a3040; /* from #2a2a2a — borders more visible on new bg */
|
||||
--shadow: rgba(0, 0, 0, 0.4);/* slight increase to stand out on lighter bg */
|
||||
--code-bg: #1a1e2e; /* from #1a1a2e — adjusted to palette */
|
||||
--success: #34d399; /* unchanged */
|
||||
--error: #f87171; /* added (was missing in default :root) */
|
||||
--grid-color: rgba(96, 165, 250, 0.03); /* reduced slightly */
|
||||
}
|
||||
```
|
||||
|
||||
**Rationale:** Palette based on `#0f1117` (Tailwind slate-950) instead of `#0a0a0a` (near-black). Gray with a hint of blue warmth is easier on the eyes, especially for white text on dark backgrounds.
|
||||
|
||||
**Contrast check:**
|
||||
- `#e8eaed` on `#0f1117` -> ~13.5:1 (AAA pass)
|
||||
- `#9aa0a6` on `#0f1117` -> ~6.8:1 (AA pass)
|
||||
- `#6b7280` on `#0f1117` -> ~4.8:1 (AA pass)
|
||||
|
||||
### 2. Gradient Background
|
||||
|
||||
Add subtle gradient to the page background for depth instead of flat color.
|
||||
|
||||
#### `src/index.css`
|
||||
|
||||
Add gradient variables to `:root`:
|
||||
|
||||
```css
|
||||
:root {
|
||||
--bg-gradient-start: #0f1117;
|
||||
--bg-gradient-end: #161922;
|
||||
}
|
||||
```
|
||||
|
||||
Apply gradient to `body` (the scrollable container):
|
||||
|
||||
```css
|
||||
body {
|
||||
background: linear-gradient(180deg, var(--bg-gradient-start) 0%, var(--bg-gradient-end) 100%);
|
||||
}
|
||||
```
|
||||
|
||||
**Note:** Gradient is applied to `body` (not `#root`) because `body` is the scrollable container. When placed on `#root` (which has `min-height: 100vh`), the gradient only covers the first viewport and disappears on scroll. `body` covers the full scrollable area. Avoids `background-attachment: fixed` mobile performance issues.
|
||||
|
||||
Light theme sets both gradient variables to `#ffffff` (no visible gradient).
|
||||
|
||||
System light mode (`prefers-color-scheme: light`) also sets gradient variables to `#ffffff`.
|
||||
|
||||
#### Hero gradient overlay
|
||||
|
||||
Create a radial glow behind hero content for visual emphasis:
|
||||
|
||||
```css
|
||||
.hero {
|
||||
position: relative; /* added for stacking context */
|
||||
}
|
||||
|
||||
.hero::before {
|
||||
content: '';
|
||||
position: absolute;
|
||||
top: -20%;
|
||||
left: 50%;
|
||||
transform: translateX(-50%);
|
||||
width: 800px;
|
||||
height: 600px;
|
||||
background: radial-gradient(ellipse, rgba(96, 165, 250, 0.08) 0%, transparent 70%);
|
||||
pointer-events: none;
|
||||
z-index: 0;
|
||||
}
|
||||
```
|
||||
|
||||
**Note:** `.hero` needs `position: relative` to establish its own stacking context so `z-index: 0` on `::before` does not interact with `.section::before` (`z-index: -1`).
|
||||
|
||||
#### Section background
|
||||
|
||||
Each `.section` already has a `.section::before` pseudo-element with a subtle gradient overlay (`App.css` lines 408-421). No additional per-section background needed — the existing overlay already creates visual rhythm between sections.
|
||||
|
||||
### 3. System Dark Mode Sync
|
||||
|
||||
Update `@media (prefers-color-scheme: dark)` to use the new palette:
|
||||
|
||||
```css
|
||||
@media (prefers-color-scheme: dark) {
|
||||
:root:not([data-theme='light']) {
|
||||
--bg-primary: #0f1117;
|
||||
--bg-surface: #161922;
|
||||
--bg-elevated: #1c2030;
|
||||
--bg-gradient-start: #0f1117;
|
||||
--bg-gradient-end: #161922;
|
||||
--text-primary: #e8eaed;
|
||||
--text-secondary: #9aa0a6;
|
||||
--text-muted: #6b7280;
|
||||
--accent: #60a5fa;
|
||||
--accent-hover: #93c5fd;
|
||||
--accent-active: #3b82f6;
|
||||
--border: #2a3040;
|
||||
--shadow: rgba(0, 0, 0, 0.4);
|
||||
--code-bg: #1a1e2e;
|
||||
--success: #34d399;
|
||||
--error: #f87171;
|
||||
--grid-color: rgba(96, 165, 250, 0.03);
|
||||
}
|
||||
}
|
||||
```
|
||||
|
||||
### 4. Light Theme
|
||||
|
||||
Light theme gradient variables set to `#ffffff` (no visible gradient). Only dark theme is improved.
|
||||
|
||||
---
|
||||
|
||||
## Files Changed
|
||||
|
||||
| File | Change |
|
||||
|------|--------|
|
||||
| `src/index.css` | Update CSS variables (dark palette), add `--error` to default `:root`, add gradient variables to all theme blocks, add gradient to `body`, add `position: relative` to `.hero` |
|
||||
| `src/App.css` | No changes — existing `.section::before` gradient already provides visual rhythm |
|
||||
|
||||
---
|
||||
|
||||
## Acceptance
|
||||
|
||||
- [X] Dark theme `--bg-primary` changed from `#0a0a0a` to `#0f1117`
|
||||
- [X] Dark theme `--bg-surface` changed from `#141414` to `#161922`
|
||||
- [X] Dark theme `--bg-elevated` changed from `#1a1a1a` to `#1c2030`
|
||||
- [X] `--error: #f87171` added to default `:root` (was missing)
|
||||
- [X] `body` has 180deg gradient (top to bottom)
|
||||
- [X] Hero has radial glow overlay above
|
||||
- [X] `.hero` has `position: relative` for stacking context
|
||||
- [X] WCAG AA contrast ratio >= 4.5:1 for all text on backgrounds
|
||||
- [X] No layout shift or overflow
|
||||
- [X] System dark mode (`prefers-color-scheme: dark`) is in sync
|
||||
- [X] Linter (`pnpm lint`) passes
|
||||
- [ ] Build (`pnpm build`) passes
|
||||
|
||||
---
|
||||
|
||||
## Open Questions
|
||||
|
||||
1. **Gradient intensity:** Should the hero radial glow use `rgba(96, 165, 250, 0.06)` (subtle) or `0.12` (more prominent)?
|
||||
2. **Accent color:** Should the accent change from `#60a5fa` (blue-400) to `#818cf8` (indigo-400) for a warmer feel?
|
||||
+1
-1
@@ -427,7 +427,7 @@
|
||||
gap: 64px;
|
||||
align-items: center;
|
||||
min-height: calc(100vh - 64px);
|
||||
padding: 80px 0;
|
||||
position: relative;
|
||||
}
|
||||
|
||||
.hero-content {
|
||||
|
||||
+24
-27
@@ -1,19 +1,20 @@
|
||||
/* Theme variables — Dark mode (default) */
|
||||
:root {
|
||||
--bg-primary: #0a0a0a;
|
||||
--bg-surface: #141414;
|
||||
--bg-elevated: #1a1a1a;
|
||||
--text-primary: #f0f0f0;
|
||||
--text-secondary: #a0a0a0;
|
||||
--text-muted: #666666;
|
||||
--bg-primary: #0f1117;
|
||||
--bg-surface: #161922;
|
||||
--bg-elevated: #1c2030;
|
||||
--text-primary: #e8eaed;
|
||||
--text-secondary: #9aa0a6;
|
||||
--text-muted: #6b7280;
|
||||
--accent: #60a5fa;
|
||||
--accent-hover: #93c5fd;
|
||||
--accent-active: #3b82f6;
|
||||
--border: #2a2a2a;
|
||||
--shadow: rgba(0, 0, 0, 0.3);
|
||||
--code-bg: #1a1a2e;
|
||||
--border: #2a3040;
|
||||
--shadow: rgba(0, 0, 0, 0.4);
|
||||
--code-bg: #1a1e2e;
|
||||
--success: #34d399;
|
||||
--grid-color: rgba(96, 165, 250, 0.04);
|
||||
--error: #f87171;
|
||||
--grid-color: rgba(96, 165, 250, 0.03);
|
||||
|
||||
--sans: 'Inter', system-ui, -apple-system, sans-serif;
|
||||
--mono: 'JetBrains Mono', 'Fira Code', ui-monospace, monospace;
|
||||
@@ -42,8 +43,8 @@
|
||||
|
||||
/* Light mode */
|
||||
:root[data-theme='light'] {
|
||||
--bg-primary: #ffffff;
|
||||
--bg-surface: #f5f5f5;
|
||||
--bg-primary: #ececee;
|
||||
--bg-surface: #e0e0e3;
|
||||
--bg-elevated: #ffffff;
|
||||
--text-primary: #0a0a0a;
|
||||
--text-secondary: #404040;
|
||||
@@ -56,34 +57,31 @@
|
||||
--code-bg: #f0f0ff;
|
||||
--success: #059669;
|
||||
--error: #dc2626;
|
||||
--grid-color: rgba(37, 99, 235, 0.08);
|
||||
}
|
||||
|
||||
/* System theme */
|
||||
@media (prefers-color-scheme: dark) {
|
||||
:root:not([data-theme='light']) {
|
||||
--bg-primary: #0a0a0a;
|
||||
--bg-surface: #141414;
|
||||
--bg-elevated: #1a1a1a;
|
||||
--text-primary: #f0f0f0;
|
||||
--text-secondary: #a0a0a0;
|
||||
--text-muted: #666666;
|
||||
--bg-primary: #0f1117;
|
||||
--bg-surface: #161922;
|
||||
--bg-elevated: #1c2030;
|
||||
--text-primary: #e8eaed;
|
||||
--text-secondary: #9aa0a6;
|
||||
--text-muted: #6b7280;
|
||||
--accent: #60a5fa;
|
||||
--accent-hover: #93c5fd;
|
||||
--accent-active: #3b82f6;
|
||||
--border: #2a2a2a;
|
||||
--shadow: rgba(0, 0, 0, 0.3);
|
||||
--code-bg: #1a1a2e;
|
||||
--border: #2a3040;
|
||||
--shadow: rgba(0, 0, 0, 0.4);
|
||||
--code-bg: #1a1e2e;
|
||||
--success: #34d399;
|
||||
--error: #f87171;
|
||||
--grid-color: rgba(96, 165, 250, 0.04);
|
||||
}
|
||||
}
|
||||
|
||||
@media (prefers-color-scheme: light) {
|
||||
:root:not([data-theme='dark']) {
|
||||
--bg-primary: #ffffff;
|
||||
--bg-surface: #f5f5f5;
|
||||
--bg-primary: #ececee;
|
||||
--bg-surface: #e0e0e3;
|
||||
--bg-elevated: #ffffff;
|
||||
--text-primary: #0a0a0a;
|
||||
--text-secondary: #404040;
|
||||
@@ -96,7 +94,6 @@
|
||||
--code-bg: #f0f0ff;
|
||||
--success: #059669;
|
||||
--error: #dc2626;
|
||||
--grid-color: rgba(37, 99, 235, 0.08);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user