style(ui): finish v3 typography sweep - inline type styles to classes

PhilosophyPage: prose column, paragraph spacing, no nested <p>, aria-labelledby wired to a real SectionHeading id.

About/AboutPage, ProjectDetailPage, Experience/ExperiencePage, Contact/ContactPage, Projects, DownloadResume: inline fontSize/lineHeight/fontWeight/color/maxWidth replaced by .prose, .prose-lede, .page-body, .subheading, .project-section, .back-link, .section-cta, .link-label, .contact-link-sub, .achievement-impact, .achievement-metrics.

App.css: add .download-resume-button as a variant of .contact-link. index.css: drop leftover .container-narrow from two responsive selector lists. Delete dead ui/Card.tsx and its barrel export.

Specs: typography progress marked done with the verification log; .skip-link orphan closed in both v3 specs (strings.skipLink is gone too).

tsc -b exit 0; vite build 538 modules / 24.86 kB CSS; built CSS carries every new class and none of the deleted selectors; oxlint diagnostics identical to HEAD (15 errors / 9 warnings, all pre-existing).
This commit is contained in:
dong.nguyen committed 2026-10-16 21:29:40 +07:00
1 parent c1e64eabbd
commit d172843738
16 files changed
+103 -140

No files matched your search

@@ -317,7 +317,7 @@ New structure: **one dark block + one light block + one media bridge** (removes
`@media (prefers-color-scheme: dark) { :root:not([data-theme='light']) { … } }` is **deleted**: its values are identical to `:root`, so it can never change anything. `@media (prefers-color-scheme: dark) { :root:not([data-theme='light']) { … } }` is **deleted**: its values are identical to `:root`, so it can never change anything.
`.skip-link` (`src/index.css:265-275`): `background: var(--accent); color: white;` → `color: var(--text-on-accent);`. **Moot in the shipped tree:** the block was deleted in the working tree and no component renders `.skip-link`; `strings.skipLink` is unused. `.skip-link` (`src/index.css:265-275`): `background: var(--accent); color: white;` → `color: var(--text-on-accent);`. **Closed:** the block was deleted in the working tree, no component renders `.skip-link`, and `strings.skipLink` has been removed too — `grep -i skip` over `src/` → 0 matches.
### 4.2 `index.html` — prevent first-paint flash ### 4.2 `index.html` — prevent first-paint flash
@@ -426,7 +426,7 @@ New structure: **one dark block + one light block + one media bridge** (removes
- [x] Rebuilt after the second pass: `tsc -b` exit 0; `vite build` 538 modules, 26.04 kB CSS — built CSS carries `#b04138`, `#a8382f`, `#9b3229` (×2 each: light block + media bridge) and `#f06060`, with no `#b91c1c`, no `#7f1d1d`, no blue - [x] Rebuilt after the second pass: `tsc -b` exit 0; `vite build` 538 modules, 26.04 kB CSS — built CSS carries `#b04138`, `#a8382f`, `#9b3229` (×2 each: light block + media bridge) and `#f06060`, with no `#b91c1c`, no `#7f1d1d`, no blue
- [x] Third pass (user feedback): the translucent `--accent-soft` panel let the conic lazer sweep show through the whole button — replaced with the new **opaque** token `--accent-tint` (light `#f5e3e1`, dark `#2f1e1a`) on `.download-resume-lazer-inner` (`src/App.css:835`), so the sweep is visible only in the 2 px ring - [x] Third pass (user feedback): the translucent `--accent-soft` panel let the conic lazer sweep show through the whole button — replaced with the new **opaque** token `--accent-tint` (light `#f5e3e1`, dark `#2f1e1a`) on `.download-resume-lazer-inner` (`src/App.css:835`), so the sweep is visible only in the 2 px ring
- [x] Third pass verified: `tsc -b` exit 0; `vite build` → 26.11 kB CSS; compiled rule is `.download-resume-lazer-inner{…background:var(--accent-tint)…}` and the built CSS carries `#2f1e1a` ×1 and `#f5e3e1` ×2 (light block + bridge). Accent label on the solid tint: 4.63 light / 5.74 dark; primary ink on it 14.36 / 14.58 - [x] Third pass verified: `tsc -b` exit 0; `vite build` → 26.11 kB CSS; compiled rule is `.download-resume-lazer-inner{…background:var(--accent-tint)…}` and the built CSS carries `#2f1e1a` ×1 and `#f5e3e1` ×2 (light block + bridge). Accent label on the solid tint: 4.63 light / 5.74 dark; primary ink on it 14.36 / 14.58
- [ ] **B7** reclassified — the `.skip-link` rules were deleted from `src/index.css` in the working tree (not by this change) and no component renders the class; `strings.skipLink` (`src/i18n/strings.ts:98`) is now an unused string. Either restore markup + CSS or delete the string; nothing left to tokenize - [x] **B7** closed — the `.skip-link` rules were deleted from `src/index.css` in the working tree (not by this change), no component renders the class, and `strings.skipLink` has since been removed as well; nothing left to tokenize or delete
## 7. Verification plan ## 7. Verification plan
@@ -498,5 +498,5 @@ New structure: **one dark block + one light block + one media bridge** (removes
- Manual browser pass (§7 item 4) is the user's; the palette has not been verified headlessly, per project rule. - Manual browser pass (§7 item 4) is the user's; the palette has not been verified headlessly, per project rule.
- `pnpm build` end-to-end blocked by the nginx `dist/` mount — needs `docker compose stop` before a real production build, or a different out dir. - `pnpm build` end-to-end blocked by the nginx `dist/` mount — needs `docker compose stop` before a real production build, or a different out dir.
- `pnpm lint` dirty at baseline (15 errors + 9 warnings, all `react-hooks(rules-of-hooks)` in `.tsx` files this change never touched). - `pnpm lint` dirty at baseline (15 errors + 9 warnings, all `react-hooks(rules-of-hooks)` in `.tsx` files this change never touched).
- `.skip-link` orphan decision (§6, B7). - ~~`.skip-link` orphan decision (§6, B7)~~ — closed: no markup, no CSS, no string (`grep -i skip` over `src/` → 0 matches). Restoring it would be a new feature, not a cleanup.
- Hairline grid adoption deferred (§9 item 3). - Hairline grid adoption deferred (§9 item 3).
+11 -7
View File
@@ -4,7 +4,7 @@
> **Version:** 1.0.0 > **Version:** 1.0.0
> **Parent:** `spec.md` (IA/content readability), sibling of `spec-v3-theme-palette-gasatrya.md` > **Parent:** `spec.md` (IA/content readability), sibling of `spec-v3-theme-palette-gasatrya.md`
> **Priority:** P1 > **Priority:** P1
> **Status:** Implemented in source. `tsc -b` and the production build are green; the visual pass is the user's in a real browser (project rule: no headless verification). > **Status:** Implemented. TSX sweep done, `Card` deleted, `tsc -b` and the production build are green; the visual pass is the user's in a real browser (project rule: no headless verification).
--- ---
@@ -63,7 +63,7 @@ Reading bands used: 45-75 characters (Bringhurst), 38-80 (Butterick). Before: 11
- `--sans` → system stack (finding P5). `--mono` unchanged (it already ends in `ui-monospace, monospace`, so it resolves without a download). - `--sans` → system stack (finding P5). `--mono` unchanged (it already ends in `ui-monospace, monospace`, so it resolves without a download).
- `h3 { font-size: 21px }`; new `h4 { 18px }`, `h5 { 16px }`, `h6 { 15px }`. - `h3 { font-size: 21px }`; new `h4 { 18px }`, `h5 { 16px }`, `h6 { 15px }`.
- `p { font-size: var(--text-body); line-height: var(--leading-body); color: var(--text-secondary); }` — was implicit 16px / 1.7. - `p { font-size: var(--text-body); line-height: var(--leading-body); color: var(--text-secondary); }` — was implicit 16px / 1.7.
- `.container-narrow` deleted (no consumer). - `.container-narrow` deleted (no consumer), including its two leftover entries in the responsive padding selector lists.
### 4.2 `src/App.css` ### 4.2 `src/App.css`
@@ -90,6 +90,7 @@ Prose system (rewritten in place of the dead `.prose` block):
.contact-link-sub { font-size: var(--text-meta); line-height: 1.5; color: var(--text-muted); } .contact-link-sub { font-size: var(--text-meta); line-height: 1.5; color: var(--text-muted); }
.achievement-impact { font-size: var(--text-meta); line-height: var(--leading-body); color: var(--text-secondary); margin-bottom: 8px; } .achievement-impact { font-size: var(--text-meta); line-height: var(--leading-body); color: var(--text-secondary); margin-bottom: 8px; }
.achievement-metrics { margin-bottom: 8px; } .achievement-metrics { margin-bottom: 8px; }
.download-resume-button { justify-content: center; padding 12px 20px; color text-primary; } /* variant of .contact-link; replaces the DownloadButton inline style */
``` ```
Existing rules retuned to the scale: Existing rules retuned to the scale:
@@ -119,7 +120,7 @@ Deleted as dead (no component rendered any of them; verified by grepping every c
| `src/pages/ExperiencePage.tsx`, `src/components/sections/Experience.tsx` | impact div → `.achievement-impact`; metrics wrapper → `.achievement-metrics`; `maxWidth:'700px'` → `.page-body` | | `src/pages/ExperiencePage.tsx`, `src/components/sections/Experience.tsx` | impact div → `.achievement-impact`; metrics wrapper → `.achievement-metrics`; `maxWidth:'700px'` → `.page-body` |
| `src/pages/ContactPage.tsx`, `src/components/sections/Contact.tsx` | label divs → `.link-label`; sub-labels → `.contact-link-sub`; `maxWidth:'700px'` → `.page-body` | | `src/pages/ContactPage.tsx`, `src/components/sections/Contact.tsx` | label divs → `.link-label`; sub-labels → `.contact-link-sub`; `maxWidth:'700px'` → `.page-body` |
| `src/components/sections/Projects.tsx` | "view all" link → `.section-cta` | | `src/components/sections/Projects.tsx` | "view all" link → `.section-cta` |
| `src/components/sections/DownloadResume.tsx` | option label → `.link-label` | | `src/components/sections/DownloadResume.tsx` | option label → `.link-label`; `DownloadButton` inline layout + `color` → `className="contact-link download-resume-button"` |
| `src/components/ui/Card.tsx` | deleted; export removed from `src/components/index.ts` | | `src/components/ui/Card.tsx` | deleted; export removed from `src/components/index.ts` |
## 5. Affected files ## 5. Affected files
@@ -127,7 +128,7 @@ Deleted as dead (no component rendered any of them; verified by grepping every c
| File | Change | | File | Change |
|---|---| |---|---|
| `src/index.css` | token block (5 added, `--max-narrow` deleted), `--sans`, `h3`-`h6`, `p`, `.container-narrow` deleted | | `src/index.css` | token block (5 added, `--max-narrow` deleted), `--sans`, `h3`-`h6`, `p`, `.container-narrow` deleted |
| `src/App.css` | prose system added/rewritten, 10 selectors retuned, ~170 lines of dead CSS deleted | | `src/App.css` | prose system added/rewritten, 10 selectors retuned, `.download-resume-button` added, ~170 lines of dead CSS deleted |
| 8 page/section TSX files | inline type styles → classes (see §4.3) | | 8 page/section TSX files | inline type styles → classes (see §4.3) |
| `src/components/ui/Card.tsx` | deleted | | `src/components/ui/Card.tsx` | deleted |
| `src/components/index.ts` | `Card` export removed | | `src/components/index.ts` | `Card` export removed |
@@ -144,8 +145,8 @@ Deleted as dead (no component rendered any of them; verified by grepping every c
- [x] 10 existing selectors retuned to the scale - [x] 10 existing selectors retuned to the scale
- [x] Dead CSS deleted, `Card` component deleted - [x] Dead CSS deleted, `Card` component deleted
- [x] Philosophy page: prose column, paragraph spacing, no nested `<p>`, ARIA id wired - [x] Philosophy page: prose column, paragraph spacing, no nested `<p>`, ARIA id wired
- [ ] Inline type styles removed from the 8 TSX files — in flight, tracked here - [x] Inline type styles removed from the 8 TSX files — gate `style=\{\{[^}]*(fontSize|lineHeight|fontWeight|color|maxWidth)` over `src/` → 0 matches
- [ ] `tsc -b` + `vite build` green after the TSX sweep - [x] `tsc -b` + `vite build` green after the TSX sweep
- [ ] Manual browser pass (§7) on `/`, `/about`, `/experience`, `/projects`, `/projects/:id`, `/philosophy`, `/contact`, dark and light - [ ] Manual browser pass (§7) on `/`, `/about`, `/experience`, `/projects`, `/projects/:id`, `/philosophy`, `/contact`, dark and light
## 7. Verification plan ## 7. Verification plan
@@ -153,6 +154,9 @@ Deleted as dead (no component rendered any of them; verified by grepping every c
1. `pnpm exec tsc -b` → exit 0 (the `Card` deletion must not leave an import behind). 1. `pnpm exec tsc -b` → exit 0 (the `Card` deletion must not leave an import behind).
2. `pnpm exec vite build --outDir dist-verify` → module count and CSS size; grep the built CSS for `--text-body`, `--measure-prose`, `.prose-lede`, and for the absence of `.card{`, `.form-input`, `.filter-pill`, `.article-card`, `.engineering-tab`, `.breadcrumb`, `.page-header`, `.container-narrow`. 2. `pnpm exec vite build --outDir dist-verify` → module count and CSS size; grep the built CSS for `--text-body`, `--measure-prose`, `.prose-lede`, and for the absence of `.card{`, `.form-input`, `.filter-pill`, `.article-card`, `.engineering-tab`, `.breadcrumb`, `.page-header`, `.container-narrow`.
3. Grep gate: `style=\{\{[^}]*(fontSize|lineHeight|fontWeight|color|maxWidth)` over `src/**/*.tsx` → zero matches; `grep "Card"` over `src/` → zero matches. 3. Grep gate: `style=\{\{[^}]*(fontSize|lineHeight|fontWeight|color|maxWidth)` over `src/**/*.tsx` → zero matches; `grep "Card"` over `src/` → zero matches.
Result: 538 modules, CSS 24.8 KB (5.37 KB gzip). Built CSS contains `--text-body`, `--measure-prose`, `.prose-lede`, `.prose`, `.page-body`, `.subheading`, `.project-section`, `.back-link`, `.section-cta`, `.link-label`, `.contact-link-sub`, `.achievement-impact`, `.achievement-metrics`, `.philosophy-quote`, `.download-resume-button`; zero hits for `.card{`, `card-elevated`, `card-featured`, `form-*`, `filter-*`, `article-*`, `engineering-tab*`, `breadcrumb*`, `page-header`, `container-narrow`, `--max-narrow`. `grep "Card"` over `src/` → 0 matches.
oxlint against HEAD and against the working tree produce identical diagnostics (15 errors / 9 warnings): every one is pre-existing — oxlint treats the `useField` / `useFieldArray` helpers in `src/i18n/useField.ts` as hooks, plus `Navigation.tsx:26` `set-state-in-effect`. Out of scope here.
4. Manual, real browser (no headless, per project rule): 4. Manual, real browser (no headless, per project rule):
- `/philosophy`: three paragraphs visibly separated, ~600px column, 18px body, quote title 21px, no wall of text. - `/philosophy`: three paragraphs visibly separated, ~600px column, 18px body, quote title 21px, no wall of text.
- `/about`: bio 20px capped at 600px, section titles 21px, cards unchanged in width. - `/about`: bio 20px capped at 600px, section titles 21px, cards unchanged in width.
@@ -174,5 +178,5 @@ Deleted as dead (no component rendered any of them; verified by grepping every c
## 9. Open questions ## 9. Open questions
1. **Wire Source Sans 3 later?** It is already shipped and used by the PDF, and gasatrya uses it. Cost: four `@font-face` rules, ~75 KB per weight, and its x-height is 0.486 em vs Segoe UI's 0.500 — the scale would need +1px to read the same. Deferred by user decision. 1. **Wire Source Sans 3 later?** It is already shipped and used by the PDF, and gasatrya uses it. Cost: four `@font-face` rules, ~75 KB per weight, and its x-height is 0.486 em vs Segoe UI's 0.500 — the scale would need +1px to read the same. Deferred by user decision.
2. **`.skip-link` orphan** (shared with the palette spec): the rules were deleted from `src/index.css` in the working tree and no component renders the class, while `strings.skipLink` (`src/i18n/strings.ts:98`) still exists. Restore markup + CSS or delete the string. 2. ~~**`.skip-link` orphan**~~ — closed. `strings.skipLink` no longer exists either: `grep -i skip` over `src/` → 0 matches, so there is no orphan left in either direction.
3. **`--leading-body` 1.65 vs the old 1.7** — 1.7 was applied only to `p`; 1.65 is now applied to body copy in every element role. Whether 1.6 or 1.7 reads better at 18px is a call for the manual pass. 3. **`--leading-body` 1.65 vs the old 1.7** — 1.7 was applied only to `p`; 1.65 is now applied to body copy in every element role. Whether 1.6 or 1.7 reads better at 18px is a call for the manual pass.
+8 -1
View File
@@ -1067,7 +1067,7 @@
} }
} }
/* ===== Project Cards Grid ===== */ /* ===== Projects Grid ===== */
.projects-grid { .projects-grid {
display: grid; display: grid;
grid-template-columns: repeat(2, 1fr); grid-template-columns: repeat(2, 1fr);
@@ -1232,6 +1232,13 @@
color: var(--text-muted); color: var(--text-muted);
} }
/* Resume download button variant of the contact tile */
.download-resume-button {
justify-content: center;
padding: 12px 20px;
color: var(--text-primary);
}
@media (max-width: 768px) { @media (max-width: 768px) {
.contact-links { .contact-links {
flex-direction: column; flex-direction: column;
-1
View File
@@ -1,7 +1,6 @@
export { Button } from './ui/Button' export { Button } from './ui/Button'
export { Badge } from './ui/Badge' export { Badge } from './ui/Badge'
export { Tag } from './ui/Tag' export { Tag } from './ui/Tag'
export { Card } from './ui/Card'
export { SectionHeading } from './ui/SectionHeading' export { SectionHeading } from './ui/SectionHeading'
export { SocialLinks } from './ui/SocialLinks' export { SocialLinks } from './ui/SocialLinks'
export { Navigation } from './layout/Navigation' export { Navigation } from './layout/Navigation'
+4 -4
View File
@@ -11,12 +11,12 @@ export function About() {
<InView> <InView>
<section className="section container-wide" aria-labelledby="about-heading"> <section className="section container-wide" aria-labelledby="about-heading">
<SectionHeading title={strings.about.heading[lang]} tag={strings.about.heading[lang]} /> <SectionHeading title={strings.about.heading[lang]} tag={strings.about.heading[lang]} />
<div style={{ maxWidth: '700px' }}> <div className="page-body">
<p style={{ fontSize: '18px', marginBottom: '32px' }}> <p className="prose-lede">
{useField(profile.bio, profile.bioEn)} {useField(profile.bio, profile.bioEn)}
</p> </p>
<h3 style={{ fontSize: '20px', marginBottom: '16px', color: 'var(--text-primary)' }}> <h3 className="subheading">
{strings.about.engineeringTitle[lang]} {strings.about.engineeringTitle[lang]}
</h3> </h3>
<div className="philosophy-grid"> <div className="philosophy-grid">
@@ -33,7 +33,7 @@ export function About() {
))} ))}
</div> </div>
<h3 style={{ fontSize: '20px', marginTop: '32px', marginBottom: '12px', color: 'var(--text-primary)' }}> <h3 className="subheading">
{strings.about.exploringTitle[lang]} {strings.about.exploringTitle[lang]}
</h3> </h3>
<div className="interests-list"> <div className="interests-list">
+7 -7
View File
@@ -22,7 +22,7 @@ export function Contact() {
> >
<SectionHeading title={strings.contact.heading[lang]} tag={strings.common.contactTag[lang]} /> <SectionHeading title={strings.contact.heading[lang]} tag={strings.common.contactTag[lang]} />
<div style={{ maxWidth: '700px' }}> <div className="page-body">
<div className="contact-links"> <div className="contact-links">
<motion.a <motion.a
href={`mailto:${profile.email}`} href={`mailto:${profile.email}`}
@@ -42,10 +42,10 @@ export function Contact() {
<path d="M22 4l-10 8L2 4" /> <path d="M22 4l-10 8L2 4" />
</svg> </svg>
<div> <div>
<div style={{ fontWeight: 500, color: "var(--text-primary)" }}> <div className="link-label">
{strings.contact.email[lang]} {strings.contact.email[lang]}
</div> </div>
<div style={{ fontSize: "14px", color: "var(--text-muted)" }}> <div className="contact-link-sub">
{profile.email} {profile.email}
</div> </div>
</div> </div>
@@ -67,10 +67,10 @@ export function Contact() {
<path d="M12 0C5.37 0 0 5.37 0 12c0 5.31 3.435 9.795 8.205 11.385.6.105.825-.255.825-.57 0-.285-.015-1.23-.015-2.235-3.015.555-3.795-.735-4.035-1.41-.135-.345-.72-1.41-1.23-1.695-.42-.225-1.02-.78-.015-.795.945-.015 1.62.87 1.845 1.23 1.08 1.815 2.805 1.305 3.495.99.105-.78.42-1.305.765-1.605-2.67-.3-5.46-1.335-5.46-5.925 0-1.305.465-2.385 1.23-3.225-.12-.3-.54-1.53.12-3.18 0 0 1.005-.315 3.3 1.23.96-.27 1.98-.405 3-.405s2.04.135 3 .405c2.295-1.56 3.3-1.23 3.3-1.23.66 1.65.24 2.88.12 3.18.765.84 1.23 1.905 1.23 3.225 0 4.605-2.805 5.625-5.475 5.925.435.375.81 1.095.81 2.22 0 1.605-.015 2.895-.015 3.3 0 .315.225.69.825.57A12.02 12.02 0 0 0 24 12c0-6.63-5.37-12-12-12z" /> <path d="M12 0C5.37 0 0 5.37 0 12c0 5.31 3.435 9.795 8.205 11.385.6.105.825-.255.825-.57 0-.285-.015-1.23-.015-2.235-3.015.555-3.795-.735-4.035-1.41-.135-.345-.72-1.41-1.23-1.695-.42-.225-1.02-.78-.015-.795.945-.015 1.62.87 1.845 1.23 1.08 1.815 2.805 1.305 3.495.99.105-.78.42-1.305.765-1.605-2.67-.3-5.46-1.335-5.46-5.925 0-1.305.465-2.385 1.23-3.225-.12-.3-.54-1.53.12-3.18 0 0 1.005-.315 3.3 1.23.96-.27 1.98-.405 3-.405s2.04.135 3 .405c2.295-1.56 3.3-1.23 3.3-1.23.66 1.65.24 2.88.12 3.18.765.84 1.23 1.905 1.23 3.225 0 4.605-2.805 5.625-5.475 5.925.435.375.81 1.095.81 2.22 0 1.605-.015 2.895-.015 3.3 0 .315.225.69.825.57A12.02 12.02 0 0 0 24 12c0-6.63-5.37-12-12-12z" />
</svg> </svg>
<div> <div>
<div style={{ fontWeight: 500, color: "var(--text-primary)" }}> <div className="link-label">
{strings.contact.github[lang]} {strings.contact.github[lang]}
</div> </div>
<div style={{ fontSize: "14px", color: "var(--text-muted)" }}> <div className="contact-link-sub">
@yourusername @yourusername
</div> </div>
</div> </div>
@@ -92,10 +92,10 @@ export function Contact() {
<path d="M20.447 20.452h-3.554v-5.569c0-1.328-.027-3.037-1.852-3.037-1.853 0-2.136 1.445-2.136 2.939v5.667H9.351V9h3.414v1.561h.046c.477-.9 1.637-1.85 3.37-1.85 3.601 0 4.267 2.37 4.267 5.455v6.286zM5.337 7.433a2.062 2.062 0 0 1-2.063-2.065 2.064 2.064 0 1 1 2.063 2.065zm1.782 13.019H3.555V9h3.564v11.452zM22.225 0H1.771C.792 0 0 .774 0 1.729v20.542C0 23.227.792 24 1.771 24h20.451C23.2 24 24 23.227 24 22.271V1.729C24 .774 23.2 0 22.222 0h.003z" /> <path d="M20.447 20.452h-3.554v-5.569c0-1.328-.027-3.037-1.852-3.037-1.853 0-2.136 1.445-2.136 2.939v5.667H9.351V9h3.414v1.561h.046c.477-.9 1.637-1.85 3.37-1.85 3.601 0 4.267 2.37 4.267 5.455v6.286zM5.337 7.433a2.062 2.062 0 0 1-2.063-2.065 2.064 2.064 0 1 1 2.063 2.065zm1.782 13.019H3.555V9h3.564v11.452zM22.225 0H1.771C.792 0 0 .774 0 1.729v20.542C0 23.227.792 24 1.771 24h20.451C23.2 24 24 23.227 24 22.271V1.729C24 .774 23.2 0 22.222 0h.003z" />
</svg> </svg>
<div> <div>
<div style={{ fontWeight: 500, color: "var(--text-primary)" }}> <div className="link-label">
{strings.contact.linkedin[lang]} {strings.contact.linkedin[lang]}
</div> </div>
<div style={{ fontSize: "14px", color: "var(--text-muted)" }}> <div className="contact-link-sub">
Your Name Your Name
</div> </div>
</div> </div>
+2 -13
View File
@@ -77,23 +77,12 @@ function DownloadButton({ lang }: { lang: Language }) {
<a <a
href={resumeUrlFor(lang)} href={resumeUrlFor(lang)}
download download
className="contact-link" className="contact-link download-resume-button"
style={{
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
gap: '12px',
padding: '12px 20px',
borderRadius: '8px',
textDecoration: 'none',
color: 'var(--text-primary)',
border: '1px solid var(--border)',
}}
> >
<svg viewBox="0 0 24 24" fill="currentColor" width="24" height="24"> <svg viewBox="0 0 24 24" fill="currentColor" width="24" height="24">
<path d="M12 2a1 1 0 0 1 1 1v9.586l2.707-2.707a1 1 0 1 1 1.414 1.414l-4.5 4.5a1 1 0 0 1-1.414 0l-4.5-4.5a1 1 0 0 1 1.414-1.414L11 12.586V3a1 1 0 0 1 1-1zm-7 16a1 1 0 1 1 0 2h14a1 1 0 1 1 0-2H5z" /> <path d="M12 2a1 1 0 0 1 1 1v9.586l2.707-2.707a1 1 0 1 1 1.414 1.414l-4.5 4.5a1 1 0 0 1-1.414 0l-4.5-4.5a1 1 0 0 1 1.414-1.414L11 12.586V3a1 1 0 0 1 1-1zm-7 16a1 1 0 1 1 0 2h14a1 1 0 1 1 0-2H5z" />
</svg> </svg>
<div style={{ fontWeight: 500, color: 'var(--text-primary)' }}>{strings.common.resumeDownload[currentLang]} {resumeLanguageLabels[lang]}</div> <div className="link-label">{strings.common.resumeDownload[currentLang]} {resumeLanguageLabels[lang]}</div>
</a> </a>
) )
} }
+3 -9
View File
@@ -25,7 +25,7 @@ export function Experience() {
}} }}
> >
<SectionHeading title={strings.experience.heading[lang]} tag={strings.experience.heading[lang]} /> <SectionHeading title={strings.experience.heading[lang]} tag={strings.experience.heading[lang]} />
<div style={{ maxWidth: '700px' }}> <div className="page-body">
<div className="timeline"> <div className="timeline">
{experiences.map((exp, i) => ( {experiences.map((exp, i) => (
<motion.div <motion.div
@@ -64,18 +64,12 @@ export function Experience() {
<div className="achievement-context"> <div className="achievement-context">
{useField(achievement.context, achievement.contextEn)} {useField(achievement.context, achievement.contextEn)}
</div> </div>
<div <div className="achievement-impact">
style={{
fontSize: "14px",
color: "var(--text-secondary)",
marginBottom: "8px",
}}
>
{useField(achievement.impact, achievement.impactEn)} {useField(achievement.impact, achievement.impactEn)}
</div> </div>
{achievement.metrics && {achievement.metrics &&
achievement.metrics.length > 0 && ( achievement.metrics.length > 0 && (
<div style={{ marginBottom: "8px" }}> <div className="achievement-metrics">
{achievement.metrics.map((m) => ( {achievement.metrics.map((m) => (
<span key={m} className="achievement-metric"> <span key={m} className="achievement-metric">
{m} {m}
+1 -1
View File
@@ -33,7 +33,7 @@ export function Projects() {
<SectionHeading title={strings.projects.featured[lang]} tag={strings.projects.featured[lang]} /> <SectionHeading title={strings.projects.featured[lang]} tag={strings.projects.featured[lang]} />
<Link <Link
to="/projects" to="/projects"
style={{ fontSize: "14px", fontWeight: 500, color: "var(--accent)", display: "block", marginBottom: "24px" }} className="section-cta"
> >
{strings.projects.viewAll[lang]} → {strings.projects.viewAll[lang]} →
</Link> </Link>
-31
View File
@@ -1,31 +0,0 @@
import { forwardRef } from 'react'
import type { ComponentPropsWithoutRef } from 'react'
type CardVariant = 'default' | 'elevated' | 'featured'
interface CardProps extends ComponentPropsWithoutRef<'div'> {
variant?: CardVariant
children: React.ReactNode
}
const variantClasses: Record<CardVariant, string> = {
default: 'card',
elevated: 'card card-elevated',
featured: 'card card-featured',
}
export const Card = forwardRef<HTMLDivElement, CardProps>(
({ variant = 'default', className = '', children, ...props }, ref) => {
return (
<div
className={`${variantClasses[variant]} ${className}`.trim()}
ref={ref}
{...props}
>
{children}
</div>
)
}
)
Card.displayName = 'Card'
+2 -4
View File
@@ -239,8 +239,7 @@ pre code {
padding: 48px 0; padding: 48px 0;
} }
.container-wide, .container-wide,
.container-content, .container-content {
.container-narrow {
padding-left: 32px; padding-left: 32px;
padding-right: 32px; padding-right: 32px;
} }
@@ -248,8 +247,7 @@ pre code {
@media (min-width: 769px) and (max-width: 1200px) { @media (min-width: 769px) and (max-width: 1200px) {
.container-wide, .container-wide,
.container-content, .container-content {
.container-narrow {
padding-left: 40px; padding-left: 40px;
padding-right: 40px; padding-right: 40px;
} }
+4 -4
View File
@@ -18,12 +18,12 @@ export function AboutPage() {
subtitle={strings.about.subtitle[lang]} subtitle={strings.about.subtitle[lang]}
tag={strings.about.heading[lang]} tag={strings.about.heading[lang]}
/> />
<div style={{ maxWidth: '700px' }}> <div className="page-body">
<p style={{ fontSize: '18px', marginBottom: '32px' }}> <p className="prose-lede">
{useField(profile.bio, profile.bioEn)} {useField(profile.bio, profile.bioEn)}
</p> </p>
<h3 style={{ fontSize: '20px', marginBottom: '16px', color: 'var(--text-primary)' }}> <h3 className="subheading">
{strings.about.engineeringTitle[lang]} {strings.about.engineeringTitle[lang]}
</h3> </h3>
<div className="philosophy-grid"> <div className="philosophy-grid">
@@ -40,7 +40,7 @@ export function AboutPage() {
))} ))}
</div> </div>
<h3 style={{ fontSize: '20px', marginTop: '32px', marginBottom: '12px', color: 'var(--text-primary)' }}> <h3 className="subheading">
{strings.about.exploringTitlePage[lang]} {strings.about.exploringTitlePage[lang]}
</h3> </h3>
<div className="interests-list"> <div className="interests-list">
+6 -6
View File
@@ -15,8 +15,8 @@ export function ContactPage() {
<path d="M22 4l-10 8L2 4" /> <path d="M22 4l-10 8L2 4" />
</svg> </svg>
<div> <div>
<div style={{ fontWeight: 500, color: 'var(--text-primary)' }}>{strings.contact.email[lang]}</div> <div className="link-label">{strings.contact.email[lang]}</div>
<div style={{ fontSize: '14px', color: 'var(--text-muted)' }}>{profile.email}</div> <div className="contact-link-sub">{profile.email}</div>
</div> </div>
</a> </a>
<a href={profile.githubUrl} target="_blank" rel="noopener noreferrer" className="contact-link"> <a href={profile.githubUrl} target="_blank" rel="noopener noreferrer" className="contact-link">
@@ -24,8 +24,8 @@ export function ContactPage() {
<path d="M12 0C5.37 0 0 5.37 0 12c0 5.31 3.435 9.795 8.205 11.385.6.105.825-.255.825-.57 0-.285-.015-1.23-.015-2.235-3.015.555-3.795-.735-4.035-1.41-.135-.345-.72-1.41-1.23-1.695-.42-.225-1.02-.78-.015-.795.945-.015 1.62.87 1.845 1.23 1.08 1.815 2.805 1.305 3.495.99.105-.78.42-1.305.765-1.605-2.67-.3-5.46-1.335-5.46-5.925 0-1.305.465-2.385 1.23-3.225-.12-.3-.54-1.53.12-3.18 0 0 1.005-.315 3.3 1.23.96-.27 1.98-.405 3-.405s2.04.135 3 .405c2.295-1.56 3.3-1.23 3.3-1.23.66 1.65.24 2.88.12 3.18.765.84 1.23 1.905 1.23 3.225 0 4.605-2.805 5.625-5.475 5.925.435.375.81 1.095.81 2.22 0 1.605-.015 2.895-.015 3.3 0 .315.225.69.825.57A12.02 12.02 0 0 0 24 12c0-6.63-5.37-12-12-12z" /> <path d="M12 0C5.37 0 0 5.37 0 12c0 5.31 3.435 9.795 8.205 11.385.6.105.825-.255.825-.57 0-.285-.015-1.23-.015-2.235-3.015.555-3.795-.735-4.035-1.41-.135-.345-.72-1.41-1.23-1.695-.42-.225-1.02-.78-.015-.795.945-.015 1.62.87 1.845 1.23 1.08 1.815 2.805 1.305 3.495.99.105-.78.42-1.305.765-1.605-2.67-.3-5.46-1.335-5.46-5.925 0-1.305.465-2.385 1.23-3.225-.12-.3-.54-1.53.12-3.18 0 0 1.005-.315 3.3 1.23.96-.27 1.98-.405 3-.405s2.04.135 3 .405c2.295-1.56 3.3-1.23 3.3-1.23.66 1.65.24 2.88.12 3.18.765.84 1.23 1.905 1.23 3.225 0 4.605-2.805 5.625-5.475 5.925.435.375.81 1.095.81 2.22 0 1.605-.015 2.895-.015 3.3 0 .315.225.69.825.57A12.02 12.02 0 0 0 24 12c0-6.63-5.37-12-12-12z" />
</svg> </svg>
<div> <div>
<div style={{ fontWeight: 500, color: 'var(--text-primary)' }}>{strings.contact.github[lang]}</div> <div className="link-label">{strings.contact.github[lang]}</div>
<div style={{ fontSize: '14px', color: 'var(--text-muted)' }}>@dong-nz</div> <div className="contact-link-sub">@dong-nz</div>
</div> </div>
</a> </a>
<a href={profile.linkedinUrl} target="_blank" rel="noopener noreferrer" className="contact-link"> <a href={profile.linkedinUrl} target="_blank" rel="noopener noreferrer" className="contact-link">
@@ -33,8 +33,8 @@ export function ContactPage() {
<path d="M20.447 20.452h-3.554v-5.569c0-1.328-.027-3.037-1.852-3.037-1.853 0-2.136 1.445-2.136 2.939v5.667H9.351V9h3.414v1.561h.046c.477-.9 1.637-1.85 3.37-1.85 3.601 0 4.267 2.37 4.267 5.455v6.286zM5.337 7.433a2.062 2.062 0 0 1-2.063-2.065 2.064 2.064 0 1 1 2.063 2.065zm1.782 13.019H3.555V9h3.564v11.452zM22.225 0H1.771C.792 0 0 .774 0 1.729v20.542C0 23.227.792 24 1.771 24h20.451C23.2 24 24 23.227 24 22.271V1.729C24 .774 23.2 0 22.222 0h.003z" /> <path d="M20.447 20.452h-3.554v-5.569c0-1.328-.027-3.037-1.852-3.037-1.853 0-2.136 1.445-2.136 2.939v5.667H9.351V9h3.414v1.561h.046c.477-.9 1.637-1.85 3.37-1.85 3.601 0 4.267 2.37 4.267 5.455v6.286zM5.337 7.433a2.062 2.062 0 0 1-2.063-2.065 2.064 2.064 0 1 1 2.063 2.065zm1.782 13.019H3.555V9h3.564v11.452zM22.225 0H1.771C.792 0 0 .774 0 1.729v20.542C0 23.227.792 24 1.771 24h20.451C23.2 24 24 23.227 24 22.271V1.729C24 .774 23.2 0 22.222 0h.003z" />
</svg> </svg>
<div> <div>
<div style={{ fontWeight: 500, color: 'var(--text-primary)' }}>{strings.contact.linkedin[lang]}</div> <div className="link-label">{strings.contact.linkedin[lang]}</div>
<div style={{ fontSize: '14px', color: 'var(--text-muted)' }}>@dong-nz</div> <div className="contact-link-sub">@dong-nz</div>
</div> </div>
</a> </a>
</div> </div>
+2 -2
View File
@@ -30,11 +30,11 @@ export function ExperiencePage() {
<div key={achievement.id} className="achievement"> <div key={achievement.id} className="achievement">
<div className="achievement-title">{achievement.title}</div> <div className="achievement-title">{achievement.title}</div>
<div className="achievement-context">{useField(achievement.context, achievement.contextEn)}</div> <div className="achievement-context">{useField(achievement.context, achievement.contextEn)}</div>
<div style={{ fontSize: '14px', color: 'var(--text-secondary)', marginBottom: '8px' }}> <div className="achievement-impact">
{useField(achievement.impact, achievement.impactEn)} {useField(achievement.impact, achievement.impactEn)}
</div> </div>
{achievement.metrics && achievement.metrics.length > 0 && ( {achievement.metrics && achievement.metrics.length > 0 && (
<div style={{ marginBottom: '8px' }}> <div className="achievement-metrics">
{achievement.metrics.map((m) => ( {achievement.metrics.map((m) => (
<span key={m} className="achievement-metric"> <span key={m} className="achievement-metric">
{m} {m}
+12 -11
View File
@@ -6,17 +6,18 @@ import {strings} from '@/i18n/strings'
export function PhilosophyPage() { export function PhilosophyPage() {
const {lang} = useLanguage() const {lang} = useLanguage()
return ( return (
<section className="section container-content" aria-labelledby="engineering-heading"> <section className="section container-content" aria-labelledby="philosophy-heading">
<SectionHeading title={strings.philosophy.heading[lang]} tag={strings.philosophy.heading[lang]}/> <SectionHeading id="philosophy-heading" title={strings.philosophy.heading[lang]} tag={strings.philosophy.heading[lang]}/>
{strings.philosophy.quotes.map((quote) => ( <div className="prose">
<div key={quote.title[lang]} style={{marginBottom: '48px'}}> {strings.philosophy.quotes.map((quote) => (
<h3 style={{fontSize: '20px', marginBottom: '24px', color: 'var(--text-primary)'}}> <div key={quote.title[lang]} className="philosophy-quote">
{quote.title[lang]} <h3>
</h3> {quote.title[lang]}
{/* Placeholder for expanded content */} </h3>
<p style={{color: 'var(--text-secondary)'}} dangerouslySetInnerHTML={{__html: quote.details[lang]}}/> <div dangerouslySetInnerHTML={{__html: quote.details[lang]}}/>
</div> </div>
))} ))}
</div>
</section> </section>
) )
} }
+38 -36
View File
@@ -25,7 +25,7 @@ export function ProjectDetailPage() {
return ( return (
<section className="section container-content" aria-labelledby="project-title"> <section className="section container-content" aria-labelledby="project-title">
<Link to="/projects" style={{ fontSize: '14px', fontWeight: 500, color: 'var(--accent)', marginBottom: '32px', display: 'inline-block' }}> <Link to="/projects" className="back-link">
{strings.projectDetail.backToProjects[lang]} ← {strings.projectDetail.backToProjects[lang]} ←
</Link> </Link>
@@ -34,49 +34,51 @@ export function ProjectDetailPage() {
<Badge variant="outline">{strings.projects.categories[project.category][lang]}</Badge> <Badge variant="outline">{strings.projects.categories[project.category][lang]}</Badge>
</div> </div>
<p style={{ fontSize: '18px', color: 'var(--text-secondary)', marginBottom: '32px' }}> <p className="prose-lede">
{useField(project.summary, project.summaryEn)} {useField(project.summary, project.summaryEn)}
</p> </p>
{project.metrics && project.metrics.length > 0 && ( <div className="prose">
<div style={{ marginBottom: '32px' }}> {project.metrics && project.metrics.length > 0 && (
<h3 style={{ fontSize: '16px', marginBottom: '12px', color: 'var(--text-primary)' }}>{strings.projectDetail.impact[lang]}</h3> <div>
<div style={{ display: 'flex', gap: '16px', flexWrap: 'wrap' }}> <h3>{strings.projectDetail.impact[lang]}</h3>
{project.metrics.map((m) => ( <div style={{ display: 'flex', gap: '16px', flexWrap: 'wrap' }}>
<span key={m} className="achievement-metric"> {project.metrics.map((m) => (
{m} <span key={m} className="achievement-metric">
</span> {m}
</span>
))}
</div>
</div>
)}
<div>
<h3>{strings.projectDetail.role[lang]}</h3>
<p>{project.role}</p>
</div>
<div>
<h3>{strings.projectDetail.technologies[lang]}</h3>
<div className="philosophy-keywords">
{project.technologies.map((tech) => (
<Tag key={tech}>{tech}</Tag>
))} ))}
</div> </div>
</div> </div>
)}
<div style={{ marginBottom: '32px' }}> {project.sections && project.sections.length > 0 && (
<h3 style={{ fontSize: '16px', marginBottom: '12px', color: 'var(--text-primary)' }}>{strings.projectDetail.role[lang]}</h3> <div>
<p>{project.role}</p> <h3>{strings.projectDetail.experiments[lang]}</h3>
{project.sections.map((section, idx) => (
<div key={idx} className="project-section">
<h4>{useField(section.title, section.titleEn)}</h4>
<p>{useField(section.content, section.contentEn)}</p>
<Tag accent>{section.type}</Tag>
</div>
))}
</div>
)}
</div> </div>
<div style={{ marginBottom: '32px' }}>
<h3 style={{ fontSize: '16px', marginBottom: '12px', color: 'var(--text-primary)' }}>{strings.projectDetail.technologies[lang]}</h3>
<div className="philosophy-keywords">
{project.technologies.map((tech) => (
<Tag key={tech}>{tech}</Tag>
))}
</div>
</div>
{project.sections && project.sections.length > 0 && (
<div style={{ marginBottom: '32px' }}>
<h3 style={{ fontSize: '16px', marginBottom: '12px', color: 'var(--text-primary)' }}>{strings.projectDetail.experiments[lang]}</h3>
{project.sections.map((section, idx) => (
<div key={idx} style={{ marginBottom: '16px', padding: '16px', background: 'var(--bg-surface)', borderRadius: '8px' }}>
<h4 style={{ fontSize: '14px', marginBottom: '4px', color: 'var(--text-primary)' }}>{useField(section.title, section.titleEn)}</h4>
<p style={{ fontSize: '14px', color: 'var(--text-secondary)' }}>{useField(section.content, section.contentEn)}</p>
<Tag accent>{section.type}</Tag>
</div>
))}
</div>
)}
</section> </section>
) )
} }