mirror of
https://github.com/dong-nz/cv.git
synced 2026-11-23 00:20:40 +07:00
- Add resume download button in Hero CTA and Contact section - Migrate react-router v6→v7 and v7→v8 - Restructure specs: UI specs to specs/ui/, v2 specs to specs/v2/ - Add profile-photo assets (jpg + webp) - Update AGENTS.md, spec-v2.md index
2.8 KiB
2.8 KiB
Specification — v2 React Router v6 → v7 Migration
Document:
spec-v2-router.mdVersion: 0.1.0 Parent:spec-v2.mdPriority: P0 (prerequisite for v2) Estimate: ~30 minutes
Background
React Router v7 consolidates react-router-dom into react-router. The upgrade is non-breaking if future flags are enabled. This app uses the simple <BrowserRouter> + <Routes> pattern (no data router, no forms, no splat routes).
Current state:
react-router-dompinned at6.30.6(exact, no^)- 4 files import from
react-router-dom - No splat routes, no forms, no data router APIs
Analysis
Applicable flags
| Flag | Applicable? | Notes |
|---|---|---|
v7_relativeSplatPath |
No | No splat routes (*) in app |
v7_startTransition |
Yes | Must enable on <BrowserRouter> |
v7_fetcherPersist |
No | No <RouterProvider> / data router |
v7_normalizeFormMethod |
No | No forms in app |
v7_partialHydration |
No | No <RouterProvider> / data router |
v7_skipActionErrorRevalidation |
No | No data router |
Files affected
| File | Current import | Change needed |
|---|---|---|
src/App.tsx |
react-router-dom |
→ react-router + enable flag |
src/components/layout/Navigation.tsx |
react-router-dom |
→ react-router |
src/components/layout/Footer.tsx |
react-router-dom |
→ react-router |
src/pages/ProjectDetailPage.tsx |
react-router-dom |
→ react-router |
Implementation Steps
Step 1: Verify no future flags needed
In v7, v7_startTransition and other future flags are enabled by default. No future prop needed on <BrowserRouter>.
Step 2: Update package.json
- "react-router-dom": "6.30.6"
+ "react-router": "7.18.4"
Also remove @types/react-router-dom if present (v7 types are bundled).
Step 3: Update imports
All files: replace from 'react-router-dom' → from 'react-router'
src/App.tsx
src/components/layout/Navigation.tsx
src/components/layout/Footer.tsx
src/pages/ProjectDetailPage.tsx
Step 4: Install and verify
pnpm install
pnpm build
Acceptance
package.jsonhasreact-router(notreact-router-dom)- All 4 files import from
react-router pnpm buildsucceeds without errors- Dev server runs without console warnings
- All routes work correctly (/ → /about → /projects → /projects/:id → /engineering → /contact)
- Navigation highlighting works (NavLink active state)
- Mobile menu still works
Notes
- v7 upgrade is non-breaking for this app (simple
<BrowserRouter>pattern) - No code logic changes needed — only imports + package name
- v7 enables all future flags by default; no
futureprop needed