Files
cv/docs/design/specs/v3/spec-v3-resume-redesign.md
T
dong.nguyen 4d4fd066cc feat(nav): CV resume glyph at 24px, portal modal, accent color, tight brand gap
- ResumeIcon: split page outline with a visible left-edge dash and stroked CV
  lettering (owner's 30-grid draft adapted to the 24 grid, spec follow-up 19),
  rendered at 24px matching the home glyph inside the 44px target
- ResumeDialog: portal to document.body — the fixed overlay anchored to the
  bar's backdrop-filter containing block instead of the viewport;
  useClickOutside takes an exclusion ref for the portaled panel
- .nav-resume-trigger: glyph is --accent at rest/hover/open, follows both
  theme axes
- .nav-brand: gap 12px -> 4px (borderless icons read glyph-to-glyph); the
  420px media rule only drops the bordered action gap to 8px
- public/cv-icon.svg rewritten as the canonical glyph; AGENTS.md and
  spec-v3-resume-redesign.md (follow-ups 19-23) updated
2026-10-20 18:55:12 +07:00

130 lines
34 KiB
Markdown
Raw Blame History

This file contains ambiguous Unicode characters
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
# Specification — v3 Resume PDF Redesign
> **Document:** `spec-v3-resume-redesign.md`
> **Version:** 1.6.0 (owner follow-up 6: website icon sync DONE; resume QR block wired, awaiting owner's QR images)
> **Parent:** `spec-v3-resume-improvements.md`
> **Priority:** P1
> **Status:** DONE (visual verification by owner pending)
---
## Problem
Review of `scripts/generate-resume.ts` + `public/resume-template.html` (2026-10-19) found:
| # | Issue | Evidence |
|---|-------|----------|
| 1 | PDF margins were **0mm** — `@page { margin: 20mm 18mm }` never applied: Playwright `page.pdf` defaults `preferCSSPageSize = false`, margins default to 0 (`playwright-core@1.64` `crPdf.ts`: `marginTop = convert(margin.top) \|\| 0`) | verified in `node_modules/.pnpm/playwright-core@1.64.0/.../coreBundle.js` |
| 2 | `.avoid-break` emitted by every renderer but **no CSS rule defined**; no `orphans`/`widows`, no `page-break-*` anywhere in the template | grep: 0 matches |
| 3 | ~56 lines of dead CSS `.achievement*` — `achievements` dropped from `experience.ts` 2026-10-16 | old template lines 127-182 |
| 4 | `{{ABOUT_ME_LABEL}}` replaced by the script but absent from the template — dead placeholder | old template body |
| 5 | `page.pdf` `title`/`author` options **do not exist in Playwright's API** — silently ignored dead options; PDF metadata was never set | `tsc` excess-property check against `PDFPageOptions` |
| 6 | Contact printed full URLs (`https://github.com/dong-nz`); `githubHandle`/`linkedinHandle` unused; no clickable links in the PDF | old template lines 264-268 |
| 7 | `variant: 'current' \| 'gap'` unused by the resume — career break rendered identically to a real job | `types/index.ts` |
| 8 | No brand identity: resume palette was generic warm-gray; site accent (light mode) is `#b04138` | `src/index.css` |
| 9 | `siteUrl` (`cv.vugado.com`) never linked from the PDF | `src/data/site.ts` |
| 10 | `build:resume-all` launched Chromium twice | `package.json` |
## Goal
Modern, elegant, brand-consistent A4 resume: correct print geometry, timeline experience, accent system mirroring the site's light-mode red palette, clickable contact links, single-launch bilingual generation. Open-to-work is excluded from the PDF (owner decision 2026-10-19).
## Implementation
### `public/resume-template.html` — full rewrite
- Brand tokens in `:root`: `--ink #151914`, `--muted #4b4f4a`, `--meta #756b62`, `--accent #b04138`, `--accent-soft rgba(176,65,56,.35)`, `--hairline #d9d6d0`, `--paper #ffffff` — mirrors `src/index.css` light-mode red palette.
- `@page { size: A4; margin: 16mm 15mm 14mm 15mm }` — now actually applied (see script).
- Print hygiene: `p, li { orphans: 2; widows: 2 }`, `.avoid-break { break-inside: avoid }`, `.section-title { break-after: avoid }`.
- Header: 72px circular photo with 2px accent ring, `object-position: center top` — the 3:4 portrait is anchored to the frame top so the head is never cropped (overflow cropped from the bottom, i.e. shoulders); `.header-info` offset 12px from the photo; name 20pt/700/`-0.01em`; title 11pt accent; contact as a two-column grid (`12px 1fr`, 8px column gap) — lucide stroke icons (mail, globe, github, linkedin, `currentColor`, 2px round joins, matching the site's line-art language icons) in the left column, full clickable addresses left-aligned in the right column, order email → website → github → linkedin. Text labels removed. Right end of the header: `.header-qr` block (`margin-left: auto`, 18px gap) — up to two 18mm QR images from `public/resume-qr/` (Telegram, Zalo) with 7pt uppercase `--meta` captions; assets are owner-exported from the apps, private (not committed); a missing file warns and skips (build never blocks).
- Summary: bio directly under header, no section title (modern convention; the dead `ABOUT_ME_LABEL` placeholder removed from the script).
- Experience: `.timeline` 2px hairline + node dots — filled ink for jobs, hollow `--meta` ring + italic for `variant: 'gap'`; duration pill inline right after the title (`flex-wrap`, 8px gap — no right-margin column); company line is a flex row — official company logo (`<img>` 12px, from `ExperienceEntry.logo`) + `Company · Location`; `::marker` accent bullets.
- Timeline TL;DR: final panel on the spine — accent diamond node, `TL;DR` chip (8pt uppercase letterspaced accent) + lede text on `#f5f3ef` surface with hairline border; text imported from `src/i18n/strings.ts` (`strings.experience.tldr` / `tldrText`), the same content as the site timeline.
- Projects: outline tech chips (accent text + `--accent-soft` border, radius 999px); metrics removed from the resume (owner decision 2026-10-19; data and site cards unchanged).
- Skills: 2-column grid, hairline `border-top` per group, accent group titles.
- Footer: `{{UPDATED_LABEL}}: {{UPDATED_DATE}}` only — the website link moved up into the header contact block.
### `scripts/generate-resume.ts` — full rewrite
- `--lang=all` → `['en','vi']` in **one** Chromium launch, one page, loop `page.pdf`; rejected with `--preview`.
- `escapeHtml()` applied to every data-derived string before template injection.
- Placeholder fill via literal `split/join` (avoids regex + `$` pitfalls of `String.replace`); **placeholder guard**: any unresolved `{{KEY}}` after fill → `console.error` + `exit(1)` before browser launch (prevents the dead-placeholder bug class recorded in `spec-v3-resume-improvements.md`).
- `renderExperience` filters `variant === 'current'` — the open-to-work entry is excluded from the resume PDF entirely (owner decision 2026-10-19; site timeline untouched). The earlier status-pill design was removed: `renderStatus`, `OPEN_TO_WORK` labels, and the `{{STATUS}}` placeholder no longer exist. `renderTldr` reads the shared `strings` module — no duplicated TL;DR copy.
- `resolveField(en, vi, lang)` now takes the language explicitly (script handles multiple languages per run).
- `page.pdf`: added `preferCSSPageSize: true` (activates `@page`) and `tagged: true` (tagged/accessibility PDF); removed the non-existent `title`/`author` options — PDF Title metadata now comes from the HTML `<title>` (`Resume - {NAME}` per language).
- `mkdirSync(dirname(outputPath), { recursive: true })` before writing.
### `package.json`
- `build:resume-all` → `pnpm tsx scripts/generate-resume.ts --lang=all` (single launch).
## Affected Files
| File | Action |
|---|---|
| `public/resume-template.html` | Rewritten (302 → ~300 lines, all placeholders re-keyed) |
| `scripts/generate-resume.ts` | Rewritten (~240 lines) |
| `package.json` | 1 line (`build:resume-all`) |
| `AGENTS.md` | Design Specs table: + "resume redesign" |
| `docs/design/specs/v3/spec-v3-resume-redesign.md` | New (this file) |
| `src/data/*`, site components | **Unchanged** — resume only reads existing data (`variant`, handles, `siteUrl`) |
## Acceptance Criteria
| # | Requirement | Status |
|---|-------------|--------|
| 1 | `pnpm build:resume-all` generates `dist/resume.pdf` + `dist/resume-vi.pdf` in one Chromium launch | ✅ (1.5s, both files written) |
| 2 | `@page` margin applied via `preferCSSPageSize: true` | ✅ option set; visual ✅ pending owner check |
| 3 | No unresolved `{{PLACEHOLDER}}` reaches the renderer | ✅ guard exits 1 on leftover; run passed |
| 4 | Contact rows render as icon + full clickable address, icons and values column-aligned, order email → website → github → linkedin | ✅ grid `12px 1fr`, lucide inline SVGs |
| 5 | Open-to-work fully excluded from the resume — no pill, no experience entry | ✅ filter verified; pill removed 2026-10-19 |
| 6 | Gap entry renders hollow node + italic | ✅ `.gap` variant class emitted from data |
| 7 | Company logos render inline for entries with `logo`; entries without logo render unchanged; missing asset file fails the build with a clear error | ✅ logo loader validates, alt="" decorative |
| 8 | `pnpm lint` introduces no new warnings | ✅ (only pre-existing warnings in unrelated files) |
| 9 | Script type-checks clean | ✅ via throwaway tsconfig (bundler resolution + `@/*` paths); `scripts/` is **not** covered by `tsc -b` — known gap, see Tradeoffs |
| 10 | Tagged PDF enabled | ✅ `tagged: true` accepted by Playwright 1.64 types |
## Tradeoffs
| Aspect | Detail |
|---|---|
| PDF author metadata | `printToPDF` has no author parameter; Playwright has no `author` option — author metadata is not set. Title comes from HTML `<title>`. |
| Open-to-work | The `variant: 'current'` entry is excluded from the PDF entirely (owner decision); full text remains on the site timeline. |
| ATS | Single-column, real bullets, text-first markup kept — chips/pills are visual only, extraction-safe. |
| `scripts/` type coverage | `tsconfig.node.json` includes only `vite.config.ts`; the resume script is type-checked only ad hoc. Left as-is (config change out of scope). |
| Palette | Resume is locked to the light-mode red palette (print default); no `--palette=` flag. |
## Progress
- [x] Template rewrite (tokens, header, timeline, chips, skills grid, footer, print hygiene)
- [x] Script rewrite (renderers, escapeHtml, split/join fill, placeholder guard, `--lang=all`, `preferCSSPageSize`, `tagged`, mkdir)
- [x] `package.json` `build:resume-all` → `--lang=all`
- [x] `pnpm lint` — no new warnings
- [x] `pnpm build:resume-all` — both PDFs generated, guard passed
- [x] Owner follow-up (2026-10-19): open-to-work pill removed end-to-end; photo `object-position: center top`; both PDFs regenerated
- [x] Owner follow-up 2 (2026-10-19): contact stacked one full URL per line + website line added; duration pill inline after title; footer reduced to date only; both PDFs regenerated
- [x] Owner follow-up 3 (2026-10-19): contact labelled + reordered (email, website, github, linkedin); TL;DR panel added to resume timeline (shared strings); project metrics removed from resume
- [x] Owner follow-up 4 (2026-10-19): text labels replaced with lucide mail/globe/github/linkedin line icons; contact re-aligned as a two-column grid; label plumbing removed from script
- [x] Owner follow-up 5 (2026-10-19): company logos in resume timeline — `public/resume-logos/lazada.svg` (Commons "Lazada (2019)", wordmark + heart) + `sap.svg` (Commons "SAP-Logo", blue box wordmark), data-driven via new `ExperienceEntry.logo?: string` (`"lazada"`, `"sap"`); site components NOT touched — owner reviews resume first, site sync is a separate follow-up
- [x] Owner follow-up 6a (2026-10-19): website icon sync — new shared `src/components/ui/icons.tsx` (lucide stroke mail/github/linkedin, `currentColor`, 2px round joins — same set as the resume header); `SocialLinks.tsx` tiles (20px) + `Contact.tsx` cards (24px) now import it; filled github octocat / linkedin square marks removed. Resume QR (telegram/zalo) = follow-up 6b, pending owner inputs; website QR gated on owner review
- [x] Owner follow-up 6b (2026-10-19): resume QR block wired end-to-end — `resumeQr` descriptors in `src/data/resume.ts`, loader + `renderQr` in the script, `{{QR_CODES}}` placeholder + `.header-qr` CSS in the template; dummy-PNG pipeline test then real assets landed: owner supplied `public/resume-qr/telegram.jpg` + `zalo.jpg` (owner also flipped the data to `.jpg`); payloads decoded locally (pyzbar): `https://t.me/dongdn`, `https://zaloapp.com/qr/p/14ic4cmkuegf`. Both `resume.pdf` and `resume-vi.pdf` now rebuilt with the QR block embedded (verified: 630×630 + 512×512 JPEG XObjects in both). Website QR display gated on owner review
- [x] Owner follow-up 7 (2026-10-19): (a) **contact page icons missed in 6a** — `src/pages/ContactPage.tsx` is a third copy of the contact cards with its own inline fill SVGs; now imports the shared `icons.tsx` set too (bundle chunk 3.52 → 2.04 kB proves the inline paths are gone); (b) resume photo 64 → 72px; (c) `.header-info` `margin-left: 12px`; (d) QR gap 10 → 18px. `resume.pdf` rebuilt with all four; `resume-vi.pdf` blocked by owner's locked viewer (EBUSY ×2) — re-run `pnpm build:resume-all` after closing it. NOTE: while a `dist/resume*.pdf` is open in a viewer, `pnpm build` also fails (vite `emptyDir` EPERM on the locked PDF)
- [x] Owner follow-up 8 (2026-10-19): Telegram + Zalo added to website social links — `SocialId` extended (`telegram`, `zalo`), `Profile.telegramUrl` (`https://t.me/dongdn`) + `Profile.zaloUrl` (`https://zaloapp.com/qr/p/14ic4cmkuegf`, same target as the resume QR), two entries appended in `social.ts`, aria labels en/vi in `strings.social.aria`; new `TelegramIcon` + `ZaloIcon` in `icons.tsx` as **simple-icons brand glyphs** (monochrome `currentColor`; lucide dropped brand icons — `lucide:telegram` 404s) — so the tiles are stroke lucide (mail/github/linkedin) + filled brand glyphs (telegram/zalo). Hero, footer, and the mobile sheet pick up all 5 tiles automatically via `SocialLinks`. Verified: `tsc -b` pass, bundle contains both hrefs + both aria labels exactly once, lint unchanged
- [x] Throwaway strict typecheck of `scripts/generate-resume.ts` — clean (temp config removed)
- [x] Owner follow-up 9 (2026-10-19): Telegram + Zalo cards added to contact — new shared `src/components/ui/ContactLinks.tsx` renders all 5 cards (email, github, linkedin, telegram, zalo) from `profile` + `strings.contact` (new labels `telegram`/`zalo`, new `Profile.telegramHandle`); **`Contact.tsx` (98→34 lines) and `ContactPage.tsx` (83→29 lines) deduplicated** — the two hand-copied card lists (root cause of the follow-up 7 miss) are gone, both consumers render `<ContactLinks />`; Zalo card sub is `zaloapp.com/qr/p/14ic4cmkuegf` (URL minus protocol; swap to `zalo.me/<phone>` if owner supplies the number). Proof: throwaway SSR render → exactly 5 `contact-link` anchors with correct href/target/rel (mailto has none) incl. `t.me/dongdn` + `@dongdn`; `pnpm build` + sitemap clean (ContactPage chunk 2.04 → 0.53 kB), lint unchanged. Also unblocked: viewer closed → both resume PDFs rebuilt (14:34)
- [x] Owner follow-up 10 (2026-10-19): **Zalo removed from the site** — `SocialId` drops `'zalo'`; `Profile.zaloUrl` removed from `src/data/profile.ts` and from the `Profile` interface in `src/types/index.ts`; the zalo entries are gone from `social.ts` and `ContactLinks.tsx` (its `labelKey` union narrows to email/github/linkedin/telegram); `strings.social.aria.zalo` and `strings.contact.zalo` + `zaloSub` deleted; `ZaloIcon` deleted from `icons.tsx`, so the tiles are stroke lucide (mail/github/linkedin) + the filled telegram glyph. Hero, footer and the mobile sheet follow automatically through `SocialLinks`. **Resume QR block unchanged by owner decision** — `resumeQr` keeps `{id: 'zalo', file: 'zalo.jpg'}` and `public/resume-qr/zalo.jpg` stays on disk; only the website drops Zalo. Proof: `pnpm lint` no new warnings, `tsc -b` + `vite build` clean (545 modules, ContactPage chunk 0.53 kB), grep over `src/` finds `zalo` only in `resume.ts`
- [x] Owner follow-up 11 (2026-10-19): **header photo + QR gap** — `.header-photo` 72 → 96px; `.header-info` `margin-left` 12 → 24px (clear space for the bigger photo); `.header-qr` keeps `margin-left: auto` and its `gap` goes 18 → **50px**, so the pair stays pinned to the right edge while the Telegram code sits 50px left of Zalo — each code gets its own quiet zone and a scanner cannot land on the wrong one. Measured at the real print content width (180mm = 680px): photo 96×96 at x=0, info x=138, Telegram QR 493.9–562, Zalo QR 612–680 (flush with the right edge), **QR separation 18 → 50.0 px**, 137px clear between the contact info and the Telegram code, all four contact URLs still one line each, nothing overflows the 680px content box. Header height is unchanged (150.8px — the info block, not the photo, is the tallest child), so pagination does not move. QR payloads re-decoded before the move: `telegram.jpg` → `https://t.me/dongdn`, `zalo.jpg` → `https://zaloapp.com/qr/p/14ic4cmkuegf` (assets correctly labelled). Both `resume.pdf` and `resume-vi.pdf` rebuilt (21:25)
- [x] Owner follow-up 12 (2026-10-19): **download-resume button removed from the site contact surfaces** — `<DownloadResume />` deleted from `src/components/sections/Contact.tsx` and `src/pages/ContactPage.tsx` (each now ends at `<ContactLinks />`); `DownloadResume()` and its single-language `DownloadButton()` fallback deleted from `src/components/sections/DownloadResume.tsx` (104 → 71 lines, the file exports only `DownloadResumeDropdown`, which is what Hero uses — hero CTA untouched), so the `resumeAvailable` and `Language` imports that only those two components used are gone; the dead `.download-resume-button` rule and its comment deleted from `src/App.css`. `resumeAvailable` stays in `src/data/resume.ts` because Hero gates its CTA on it. Proof: `pnpm lint` unchanged (4 pre-existing warnings), `tsc -b` + `vite build` clean, built CSS 33.69 → 33.60 kB with zero `download-resume-button` hits, ContactPage chunk 0.53 → 0.51 kB, hero CTA classes (`hero-download-dropdown`, `hero-download-summary`, `hero-download-mobile-btn`, `download-resume-option`) and the `/resume.pdf` href still in the bundle
- [x] Owner follow-up 13 (2026-10-19): **download CTA unified into one trigger + modal** — `src/components/sections/DownloadResume.tsx` rewritten: one lazer-wrapped button at every width (`aria-haspopup="dialog"`, `aria-expanded`, `aria-controls="resume-modal"`) opening an `AnimatePresence` dialog (`role="dialog" aria-modal="true"`, focus moves into the panel when the open animation ends, Escape / click-outside / the close button return focus to the trigger, `document.body.style.overflow` locked while open, `useClickOutside` hook replaces the old inline listener — the duplication `spec-v3-theme-palette-switch.md:374` flagged). Options come from `resumeLanguages`: `English → /resume.pdf`, `Tiếng Việt → /resume-vi.pdf`, each with `download` and the file name under the label. Hero drops `HeroDownloadButton`, the `Language` import and the `hero-download-desktop` / `hero-download-mobile` split, rendering `{resumeAvailable && <DownloadResume />}` once — mobile gets the same single button as desktop. New chrome strings `resumeModalTitle` / `resumeModalAria` / `resumeModalHint` / `resumeModalClose` in `strings.common`. CSS: `.download-resume` + the `.resume-modal*` block added (overlay `z-index: 1100`, above the 1000 nav), a ≤768px block stretches the trigger to the CTA column width and centres its content; deleted `.download-resume-dropdown`, `.download-resume-options`, `.download-resume-option`, `.download-resume-shared-wrapper`, `.download-resume-summary::-webkit-details-marker`, both chevron rules, `.hero-download-desktop`, `.hero-download-mobile` and their media block. Lazer border/glow kept, chevron dropped. Proof: `pnpm lint` unchanged, `tsc -b` + `vite build` clean (CSS 33.60 → 34.42 kB), built CSS 0 hits for every deleted selector and 15 for `resume-modal`, throwaway SSR render → exactly 1 trigger carrying the dialog aria triple, 0 modal nodes while closed, 0 hits for `hero-download-*` / `download-resume-option*` / `chevron`. Still open for the owner's real-browser check: open/close, Escape, focus return, and the full-width trigger at ≤768px
- [x] Owner follow-up 14 (2026-10-19): **colour flash on click fixed** — two causes. (a) The trigger flipped to the `--accent` fill at the instant of the click: the pointer is still on the button so `:hover` fires, and the leftover `.download-resume-summary.open` rule (solid accent, which the rewritten component never applied — dead CSS) agreed with it, so the button went solid accent behind the semi-transparent overlay. The trigger now carries `open` from state and `.download-resume-summary.open, .download-resume-summary.open:hover` hold it at the resting look (`background: transparent; color: var(--accent)`); a `@media (hover: none)` block does the same for the sticky tap-hover on touch devices. (b) `.resume-modal-overlay` had `backdrop-filter: blur(4px)` over a 60% `--bg-primary` scrim: `AnimatePresence` mounts the element on the first frame, so the blur landed at full strength while its opacity was still animating — the page behind jumped before the dialog arrived. `backdrop-filter` removed, scrim raised to 78% `--bg-primary`, and overlay and panel now share `duration: 0.18` so scrim and dialog read as one motion. `transition: all` on the trigger replaced by `background, color` (repo rule: a control never carries `transition: all`). Proof from the built CSS: the trigger carries `transition:background …, color …`, zero `transition:all` in the bundle, `.download-resume-summary.open,.download-resume-summary.open:hover{color:var(--accent);background:0 0}` present, `.resume-modal-overlay` has no `backdrop-filter`. Open/close feel still needs the owner's real-browser check
- [x] Owner follow-up 15 (2026-10-20): **mobile lazer no longer splits into two segments** — the cause is geometric, not colour. `.download-resume-lazer-border` / `.download-resume-lazer-glow` used `inset: -200%`, which resolves against the wrapper's own width and height, so the rotating layer measured **1710×265** on the 342×53 mobile wrapper (167×53 on desktop). `@keyframes download-resume-lazer-spin` rotated that box, and once its short half-side (132.5px) is narrower than the wrapper's half-diagonal (173px) the layer stops covering the wrapper's own edges: the lit band gets cut and the beam reads as two parts. Desktop never showed it (132.5 > 87.6 half-diagonal), which is why only the full-width mobile button looked broken. Fix: both layers are now `inset: 0` — exactly the wrapper box, so coverage is complete at every angle — and the spin animates the gradient itself through a registered `@property --lazer-angle { syntax: '<angle>'; inherits: false; initial-value: 0deg }` (`from var(--lazer-angle, 0deg)`, keyframes `0deg → 360deg`) instead of rotating a box: same 4s cycle, same arc stops, and the painted layer shrinks from 1710×265 to the wrapper box, which also cuts the cost of the `blur(12px)` glow. Proof: geometry model over 72 rotation angles — old box **1 segment on 58/72 and 2 segments on 14/72** at 342×53, 1/1 at 167×53; new geometry **1 segment on 72/72** at both sizes. Playwright probe against the production build: ring layer rect now equals the wrapper (342×53 mobile, 167×53 desktop), `--lazer-angle` advances 81° → 190° in 1.2s (4s per turn) with `animation-name: download-resume-lazer-spin`, and `@property --lazer-angle{syntax:"<angle>";inherits:false;initial-value:0deg}` is in the built CSS. `prefers-reduced-motion` keeps `animation: none`, which now parks the beam at the registered `initial-value: 0deg`
- [x] Owner follow-up 16 (2026-10-20): **resume entry in the navigation bar** — `src/components/layout/ResumeNavButton.tsx` is the third item in `.nav-brand`, right after the home icon: a `nav-control nav-resume-trigger` 44px icon box (`ResumeIcon` added to `src/components/ui/icons.tsx` — lucide `file-down`, 20px `currentColor` stroke, `aria-hidden`), named by `strings.nav.resume` (`Get resume` / `Tải CV`), `title` = the modal hint, `aria-haspopup="dialog"` / `aria-expanded` / `aria-controls="resume-modal-nav"`, gated on `resumeAvailable`. The dialog is no longer duplicated: `src/components/ui/ResumeDialog.tsx` owns the overlay + panel + `resumeLanguages` options and takes a `dialogId`, so the hero trigger keeps `#resume-modal` and the bar trigger gets `#resume-modal-nav` — one markup source, no duplicate ids. `src/hooks/useResumeDialog.ts` holds the state both triggers share (open flag, container/trigger/panel refs, `useClickOutside`, Escape, body-overflow lock, focus return); `close` is guarded on an `openRef` because the click-outside listener is live even while closed — unguarded it pulled focus to the trigger on every click anywhere on the page. Panel focus moved from `onAnimationComplete` to a one-frame `useEffect` keyed on `open`: `AnimatePresence` keeps the open=true props on its exiting copy, so the old handler fired again at the end of the exit animation, focused the panel and stranded focus on `<body>` when it unmounted (measured `body` before, `BUTTON.nav-control.nav-resume-trigger` after). `resumeAvailable` moved out of Hero's JSX into the leaf components, so Hero renders `<DownloadResume />` plainly. CSS: `.nav-resume { display: flex }`; `@media (max-width: 420px)` now tightens `.nav-brand` **and** `.nav-actions` to 8px gaps and a new `@media (max-width: 360px)` drops the container padding to 12px — six controls (40 + 44×5 = 260px) overflowed at the old 12px gaps (`.nav-container` scrollWidth 324 > 320), and after the change 320 measures 320 = 320 with 360/390/420/1024/1280 clean and the resume box at 44×44. Probe on the production build: bar control 44×44 with the full aria triple, `#resume-modal-nav` opens with 2 `download` options (`/resume.pdf`, `/resume-vi.pdf`), focus lands on the panel, Escape and the close button return focus to the trigger, an overlay/outside click leaves focus where the user clicked, `body.style.overflow` locks and restores, and the hero trigger is still exactly 1 with its own `#resume-modal`. `pnpm lint` unchanged (4 pre-existing warnings), `tsc -b` + `vite build` clean (CSS 34.65 → 34.71 kB). Owner check in a real browser: the glyph's look and position in the bar, and the row at 320–420px
- [x] Owner follow-up 17 (2026-10-20): **bar resume icon — no border, CV lettering** — `.nav-resume-trigger` overrides the shared chrome with `border-color: transparent` in one rule group covering rest, `:hover` and `.open`, so the entry reads like its borderless neighbour `.nav-logo` while keeping the 44px target, the `--bg-elevated` hover fill and the `:focus-visible` ring. `ResumeIcon` replaced (lucide `file-down` → drawn lettering): `M13.5 7.8A6.5 6.5 0 1 0 13.5 16.2` (C, open to the right) + `M15 6l3.5 12L22 6` (V). The shape was chosen by rasterizing candidates at the bar's real 20px and reading the silhouette: a page outline with small `CV` inside, and a page outline with a `CV` band, both merge into unreadable mush at 20px; the letters alone stay legible, so no document frame. The owner's Flaticon artwork (#6588184) was not fetched or copied — the page returns 403 to this environment and the session has no vision model to inspect a raster — so the glyph is original work in the bar's existing 2px `currentColor` stroke language; an exact match needs the owner to supply the SVG. Proof: built CSS `.nav-resume-trigger,.nav-resume-trigger:hover,.nav-resume-trigger.open{border-color:#0000}`; live computed style at rest `rgba(0,0,0,0)` border with a 44×44 box and a 20×20 icon, on hover border still `rgba(0,0,0,0)` with `--bg-elevated` fill and `--accent` icon; the two path strings are the only resume paths in the bundle; the shipped paths rasterized at 20px read as `C` + `V`
- [x] Owner follow-up 18 (2026-10-20): **bar resume icon — the owner's CV artwork, adapted to the line language** — closes follow-up 17's open end: the owner supplied the artwork (Flaticon #6588184) as `public/cv-icon.svg` — 1024 grid, fixed navy/blue/grey fills, person silhouette, Arial `<text>` "CV", six placeholder lines, two ghost outline paths behind transform hacks. Reviewed against the bar's 2px `currentColor` stroke language and rasterized at the bar's real 20px (follow-up 17's method, pixel grids at DSF 1 on `#151914` and `#f6f5f2`): as-is the asset is a solid ink blob on dark and scattered slivers on light — person, lettering and lines merge; a three-line variant's top stub collides with the fold flap. The file is rewritten as the canonical glyph — 24 grid, `fill: none` + `stroke: currentColor`, 2px round caps/joins: page outline with the corner cut `M14 2H6a2 2 0 0 0-2 2v16a2 2 0 0 0 2 2h12a2 2 0 0 0 2-2V8Z`, fold `M14 2v4a2 2 0 0 0 2 2h4`, two content lines `M8 12h8` / `M8 16h5` (long then short, echoing the original's alternating widths); person, `<text>`, ghost paths and fixed colours deleted. `ResumeIcon` in `src/components/ui/icons.tsx` replaces the CV lettering with the same geometry inlined — the bar icon must inherit the control's colour, and the raster confirms an `<img>`-loaded `currentColor` asset renders black-on-black in the dark bar. Evidence at 20px: outline, fold and both lines stay separate ink runs with ≥2px gaps in both themes; `pnpm lint` + `tsc -b` clean. CV meaning now carried by the translated `strings.nav.resume` label; `AGENTS.md` bar-controls paragraph and External Assets list updated.
- [x] Owner follow-up 19 (2026-10-20): **bar resume icon — CV lettering returns, with the owner's dash** — the owner drafted `public/v-1.svg` (30 grid: page outline split on the left edge by a dash, folded corner, stroked CV lettering replacing the content lines) and asked for it in the bar. `ResumeIcon` in `src/components/ui/icons.tsx` and the canonical `public/cv-icon.svg` are rewritten to the same design, adapted natively to the 24 grid on the existing page geometry: outline `M14 2 H6 a2 2 0 0 0 -2 2 V6` + dash `M4 10 V12` + `M4 16 v4 a2 2 0 0 0 2 2 h12 a2 2 0 0 0 2 -2 V8 L14 2`, fold `M14 2 v4 a2 2 0 0 0 2 2 h4`, lettering `M9.5 12 A3 3 0 0 0 9.5 18` + `M12.5 12 L15 18 L17.5 12` (C opens to the right, both letters 6 units tall, centred). Two adaptations were forced by geometry: the left-edge endpoint gaps are 4px, not v-1's 2px — under 2px round caps a 2px gap closes and the dash reads as a continuous edge (visible gap = endpoint distance − stroke width); and the lettering replaces both content lines, because no other region of the 24-grid page fits legible letters. Follow-up 17's method re-run as proof: rasterized at the bar's real 20px on `#151914` and `#f6f5f2` — the dash and both letters read clearly on each background, unlike the Flaticon artwork's small embedded text. The owner later removed `public/v-1.svg` from the repository; the canonical glyph carries the design.
- [x] Owner follow-up 20 (2026-10-20): **nav resume modal renders as the hero modal** — clicking the bar CV icon opened the shared `ResumeDialog`, but the panel did not display like the hero's: `ResumeNavButton` mounts it inside `.nav-resume`, a descendant of `.nav`, and `.nav` carries `backdrop-filter: blur(12px)` (`App.css:11`) — per CSS Filter Effects a `backdrop-filter` makes an element the containing block for fixed-position descendants, so the overlay's `position: fixed; inset: 0` sized to the ~64px bar instead of the viewport and the panel was centred inside the bar, top half clipped. The hero trigger never showed it because `.download-resume` is only `position: relative`. Fix: `ResumeDialog` now returns `createPortal(<AnimatePresence>…</AnimatePresence>, document.body)` — both triggers' overlays anchor to the viewport and the overlay's `z-index: 1100` sits above the bar's `1000` in the root stacking context. Portal side effect: the panel left `containerRef`, so `useClickOutside` grew an optional third watched ref (`extraRef`, clicks inside either ref are not "outside") and `useResumeDialog` passes `panelRef` — otherwise every click inside the panel closed the dialog. `ThemePaletteMenu`'s two-argument call is untouched; its panel stays in its container. React event semantics unchanged: overlay-click-to-close and the panel's `stopPropagation` still pair correctly through the portal tree; Escape, body scroll lock, and focus return are unaffected. Proof: `pnpm lint` + `tsc -b` clean; modal display to be confirmed by the owner in a real browser.
- [x] Owner follow-up 21 (2026-10-20): **bar resume glyph always carries the theme colour** — the trigger inherited `.nav-control`'s rest `color: var(--text-primary)`, which is identical across the red and blue palettes, so switching palette left the CV glyph unchanged: the entry did not read as themed. `.nav-resume-trigger` now declares `color: var(--accent)` at rest (`App.css`), joining the `border-color: transparent` rule; hover and open already resolve to `--accent` through `.nav-control:hover / .open` (specificity 0,2,0), so the glyph is the active theme/palette's signal colour in every state — rest, hover, open — with no colour step between them, and it follows both theme axes because `--accent` is re-declared in all five blocks of `index.css`. Contrast is the same accent already used by `.nav-link.active` and every control's hover. Cascade verified by rule order (`.nav-resume-trigger` 0,1,0 after `.nav-control` 0,1,0) and a full-file grep: no other rule touches the trigger's colour. `AGENTS.md` bar-controls paragraph updated.
- [x] Owner follow-up 22 (2026-10-20): **bar resume icon at 24×24** — `ResumeNavButton` now renders `<ResumeIcon size={24} />` instead of the component's 20px default. The glyph is built on the 24 grid (follow-up 19), so at 24px it renders 1:1: strokes land at exactly 2px like every other bar icon and the 6-unit letters become 6px — the size the follow-up 17 notes had already named as the alternative when 20px was the constraint. The 44px target is untouched: `.nav-control`'s 8px padding + 1px border leave a 26px content box, 2px wider than the icon, and the icon now matches the 24px home glyph beside it. Proof: the shipped path strings rasterized at 24px on `#151914` and `#f6f5f2` — dash open at both gaps, both letters clear; `pnpm lint` + `tsc -b` clean.
- [x] Owner follow-up 23 (2026-10-20): **tighter brand-group spacing — the left icons carry no borders** — `.nav-brand`'s 12px gap was sized for bordered boxes, but the group's three controls (hamburger, home, resume) are borderless, so the spacing that reads is glyph-to-glyph: 10px of target padding + 12px gap + 10px = 32px between the 24px glyphs. The gap drops to 4px at every width: 24px between glyphs, hover fills stay 4px apart, and two 2px-offset focus rings (2+2px) meet without overlapping. The `@media (max-width: 420px)` rule now only drops the bordered action controls 16px→8px; the brand group needs no narrow-width override because 4px is already below 8px. Width budgets improve at every breakpoint: at 390px, 260px controls + 8px brand gaps + 16px action gaps = 284px inside 358px; at 320px, 284px inside 296px — 12px of slack where the old layout had 4px. All 44px targets unchanged.
- [ ] Owner visual check of `dist/resume.pdf` / `dist/resume-vi.pdf` in a real browser/PDF viewer