- site: Zalo removed from SocialId, Profile, social.ts, ContactLinks, strings and
icons.tsx; the resume QR block keeps Zalo by owner decision
- resume: .header-photo 72 -> 96px, .header-info margin-left 12 -> 24px,
.header-qr gap 18 -> 50px so the Telegram code sits clear of Zalo
- contact: <DownloadResume /> removed from the Contact section and ContactPage;
DownloadResume() + DownloadButton() and the dead .download-resume-button rule
deleted, Hero CTA untouched
New spec-v3-review-fixes.md carries the findings, the per-bundle implementation detail, the affected-file list, the out-of-scope table including the declined resume.pdf bundle with its measured 200 text/html probe, the gate numbers and the commit record. spec-v2-seo.md acceptance is now honest: robots, sitemap, JSON-LD and canonical are done, per-route title/description/OG remain open because the SPA serves one head for every route. spec-v2.md statuses no longer contradict shipped work. AGENTS.md drops both barrels, documents the pure field() helper, the canonical origin module, the sitemap build step and the lazy/default-export gotcha.
Typewriter reads useReducedMotion: under reduced motion the timer never starts and the first role renders whole, while a screen-reader-only span exposes the full role list once instead of one keystroke at a time. BackToTop scrolls instantly under reduced motion and is labelled in the active language; the nav landmark and the mode toggle stop being English-only. The hero photo declares its measured 1200x1600 canvas plus fetch priority so the box is reserved before the 898 kB image decodes. HomePage stays eagerly imported because it owns the LCP; the other six routes lazy-load behind one Suspense boundary, which is also why the pages barrel is gone.
index.html advertised nothing: no title, no description, no Open Graph, no canonical. The head now carries both theme-color values, an OG block with an absolute 1200x1600 image, a Twitter card and a Person JSON-LD block with sameAs and a PostalAddress. src/data/site.ts holds the canonical origin; generate-sitemap.ts writes dist/sitemap.xml from navPaths plus the project list (10 urls) and fails the build if dist/index.html no longer contains siteUrl, because an HTML head cannot import TypeScript and the origin is therefore written twice by hand. Chained into pnpm build so dist/ is complete before the deploy workflow uploads it.
profile-photo.webp~ (1.2 MB) was a stray editor backup sitting in public/ and served as a real asset; icons.svg had no reference in any file; the components barrel exported 14 names with 0 importers. ProjectSection.number (16 entries), FeaturedAchievement with ExperienceEntry.achievements, and Profile.resumeUrl were never rendered by any surface. fadeInUp/.animate-in and the download-resume selectors had no consumers - motion owns entrance animation. Four unreferenced string keys removed.
Contact cards spelled out the handle in JSX while profile data already carried the URLs. profile.ts now holds githubHandle and linkedinHandle, and both the homepage section and the Contact page read them. Project titles were rendered straight from data, bypassing the language resolver, so English mode showed Vietnamese titles. Drops the githubUrl placeholder and the unused githubUrl/demoUrl pair from the Project type.
useField and useFieldArray were hooks called from inside .map() callbacks - 11 rules-of-hooks errors. field(lang, value, valueEn) is a plain function, so the same selection is legal in a callback, with lang read once at component top level. One helper covers scalar and array values because both need the same lockstep rule. resolvedTheme is now theme directly: resolveTheme() was an identity helper left behind by the removed system variant.
Preview chips now mirror the bar swatch: --preview-*-accent is declared per theme (dark #f87171/#60a5fa, light #b04138/#2563eb, repeated in the prefers-color-scheme bridge) and the two [data-palette=blue] blocks declare nothing, since a chip names its own palette through data-preview. --preview-*-bg is deleted; chips take the shared --border-strong hairline. Dark-mode dots move from 2.53/3.13 to 5.24/6.36 against their panel.
The hamburger leads the bar in a new .nav-brand group (trigger then brand), and the wordmark becomes a 24px stroke home icon in a 44px target with a :focus-visible ring, still a <Link to="/">. .logo-bracket/.logo-text are removed and the <=420px guard drops its brand-gap override: the row measures 252px inside 288px.
Docs: new specs/v3/spec-v3-nav-swatch-and-hamburger.md plus supersession notes in spec-v3-mobile-navigation, spec-v3-theme-palette-switch and spec-v3-ui-enhancements; AGENTS.md, spec-ui-layout and spec-ui-navigation updated. Gates: tsc+vite build exit 0, oxlint 15 findings (11 rules-of-hooks, unchanged baseline), zero hex in App.css, 12/12 SSR bar-order assertions.
- Replace the AnimatedSection wrapper with the per-section recipe: InView
wrapping motion.section with initial="hidden" whileInView="visible" and
viewport={{ once: true, amount: 0.1 }}; delete AnimatedSection.tsx
- Apply the item recipe (opacity/y 24, amount 0.2, delay i * 0.08) to timeline
entries, philosophy/expertise/project cards, hero blocks, contact links and
project-detail blocks
- Move transforms into motion: whileHover/whileTap on cards, links and Button;
CSS :hover keeps only colour/border/shadow, and `transition: all` becomes an
explicit property list so motion owns the transform
- Rebuild HeroParticles as perspective-projected depth tiers with scroll-linked
transforms, no mask-image, plus a documented reduced-motion caveat
- Update AGENTS.md motion section and spec-v3-ui-enhancements /
spec-v3-mobile-navigation progress notes
- index.css: --accent-solid / -hover / -active plus --text-on-accent-solid in all
five palette blocks; the two light blocks duplicate the plain accent values
verbatim so light mode does not move
- App.css: .btn-primary and .badge-accent take the solid fill with light text and
a 1px --accent border; hover and active deepen instead of brightening
- ThemePaletteMenu.tsx: the swatch is a motion.span, rotate 90 while the palette
submenu is open, 0 otherwise; reduced motion stays global (main.tsx)
- language control unchanged (owner decision Q1: keep EN/VI)
- docs: new spec-v3-nav-cta-enhancements.md v0.2.0, palette spec to v0.4.0,
AGENTS.md accent-tier and rotation bullets
Gates: tsc -b exit 0, oxlint 19 findings (baseline held), 0 hex/rgba in App.css,
vite build green (CSS 33.48 kB), SSR smoke 7/7.
Second axis on <html>: data-palette (Portfolio type Palette = 'red' | 'blue',
localStorage key portfolio-palette, default red so existing visitors see no
change). Both attributes are written before paint by the index.html init
script and re-written during render in useTheme.
- src/types/index.ts, src/data/palettes.ts: Palette + paletteIds/paletteMeta
(Record<Language, string>, indexed inline - no lookup helper)
- src/hooks/useTheme.tsx: palette state, data-palette write during render,
persistence, setPalette; no cyclePalette
- src/components/layout/ThemePaletteMenu.tsx: disclosure semantics
(aria-expanded/aria-controls, aria-current), variant nav|sheet, panel ids
derived from variant, Escape closes and refocuses the trigger
- src/components/layout/Navigation.tsx: nav instance in .nav-actions, sheet
instance after the mobile link list, remounted closed via key
- src/index.css: blue dark/light blocks (0,3,0 selectors) + preview tokens;
red --accent-soft/--accent-glow re-derived from the accent in force
- src/App.css: .nav-palette* block (token-only), nav hidden at 1024px,
sheet options inline
- specs: palette-switch spec v0.3.0 with the implementation record; corrected
the false AA claim in spec-v3-theme-colors.md (3.90:1, not ~4.8), the
composite values in spec-v3-theme-palette-gasatrya.md, the Footer consumer
claim in spec-v3-theme-switch.md; AGENTS.md Theming section documents the
palette axis
Verified: tsc exit 0; vite build green (CSS 31.80 kB); oxlint unchanged at
11 errors / 9 warnings; hex gate over src/App.css 0 matches; inline type
styles 0; contrast minima 4.96 / 4.63 / 4.81 / 4.64 with zero AA failures.
- AGENTS.md: data layer now names ExperienceEntry.variant ('current' | 'gap'); Card dropped
from the ui/ component list (deleted in d172843)
- spec-ui-components.md: Card section replaced with a removal note (component + .card* rules
deleted; remaining cards are section-specific classes)
- spec-ui-experience.md: structure tree used the dropped `current: true` flag -> composed class
- spec-v3-typography.md: achievement rules marked deleted, dead-CSS list extended, Experience
TSX row marked superseded, new 4.4 covering the timeline pass and the resume generator fix
- spec-v3-resume-improvements.md: Bugs Fixed row 2 for
"${exp.achievements?.map(...).join('')}" printing the literal "undefined"; malformed table
separator repaired
- spec-v2-resume-playwright.md: acceptance row 4 notes the achievements branch is now a
guarded no-op
- spec-v3-i18n.md: experience.ts data row and the Experience strings rows updated
(achievements dropped, relax-gap added, experience.tldr / tldrText recorded)
- spec-v3-theme-palette-gasatrya.md: lint baseline annotated 15/9 -> 11/9
Timeline structure
- Spine drawn per node (.timeline-entry::before) instead of one line on .timeline, so it ends at
the TLDR diamond; marker and spine centres coincide at x=6 (gutter 36 desktop / 28 mobile)
- TLDR terminal node: markup in ExperiencePage + Experience section, copy in i18n/strings.ts
(experience.tldr / experience.tldrText), CSS .timeline-tldr* (stub, accent link, hollow
diamond, chip, text)
- ExperienceEntry gains variant?: 'current' | 'gap'; the class is composed in JSX rather than
hard-coding entry ids
Node decoration
- current node: TLDR-family panel (--bg-surface, 1px --border, radius-lg, whisper shadow) with a
2px accent left edge, real entry padding (16/18/20, mobile 14/16/18) and a pulsing marker;
mobile pulse capped at 6px spread so the ring never touches the panel border
- gap node: dashed spine (repeating-linear-gradient), 10px muted marker, no divider,
italic-muted title and company
Data
- New relax-gap entry (Aug 2026 – Oct 2026) between open-to-work and lazada-senior-swe; unique
entry ids; Nexts and SAP bullets aligned across VI/EN
Typography
- Add --measure-page (680px); .prose-wide / .lede-wide; .page-body 700 -> 680; philosophy grid
3 columns, 2 at <=1024px
Cleanup
- Achievements dropped from the SPA timeline and their dead .achievement* rules deleted
(.achievement-metric kept: projects pages still use it)
Resume generator
- "${exp.achievements?.map(...).join('')}" short-circuited the whole chain and printed the
literal "undefined" in every PDF once an entry had no achievements; now (exp.achievements ?? [])
Docs: spec-ui-experience.md, spec-v3-typography.md, AGENTS.md
Verified: tsc -b clean; vite build green; oxlint 11 errors / 9 warnings (HEAD baseline was 15/9 —
the four that disappeared were the achievements markup findings); pnpm build:resume-all renders
both PDFs with the new ordering and no "undefined".
PhilosophyPage: prose column, paragraph spacing, no nested <p>, aria-labelledby wired to a real SectionHeading id.
About/AboutPage, ProjectDetailPage, Experience/ExperiencePage, Contact/ContactPage, Projects, DownloadResume: inline fontSize/lineHeight/fontWeight/color/maxWidth replaced by .prose, .prose-lede, .page-body, .subheading, .project-section, .back-link, .section-cta, .link-label, .contact-link-sub, .achievement-impact, .achievement-metrics.
App.css: add .download-resume-button as a variant of .contact-link. index.css: drop leftover .container-narrow from two responsive selector lists. Delete dead ui/Card.tsx and its barrel export.
Specs: typography progress marked done with the verification log; .skip-link orphan closed in both v3 specs (strings.skipLink is gone too).
tsc -b exit 0; vite build 538 modules / 24.86 kB CSS; built CSS carries every new class and none of the deleted selectors; oxlint diagnostics identical to HEAD (15 errors / 9 warnings, all pre-existing).
- Remove 'system' from Theme type (now 'dark' | 'light')
- Fix cycle to predictable dark -> light -> dark -> light
- Replace getStoredTheme with getInitialTheme
- Initial load: check localStorage, detect system theme, fallback dark
- Simplify resolveTheme (no longer needs system branch)
- Remove unused getSystemTheme function
- Add spec-v3-theme-switch.md
- Dark theme: shift from near-black (#0a0a0a) to deep slate (#0f1117)
- Dark theme: softer text colors for reduced eye strain
- Dark theme: add missing --error variable to default :root
- Light theme: soften from pure white to off-white (#ececee)
- Light theme: add contrast to --bg-surface (#e0e0e3)
- Remove gradient background (caused flicker on scroll)
- Add position: relative to .hero for stacking context
- Update spec-v3-theme-colors.md with correct implementation
- Update .download-resume-summary to use same CSS as btn-secondary
- Remove hero-specific font-size overrides
- Consistent look with View Projects and Contact Me buttons
- spec-v2-resume-future.md: v0.3.0 - only keep Version Stamping and
Multiple Language Versions, mark both as implemented
- spec-v2-resume-playwright.md: v0.6.0 - remove Future Enhancements
table, mark Download Resume UI as implemented
- DownloadResume: single dropdown button on desktop (≥769px),
2 separate buttons on mobile (<769px)
- Hero CTA: same pattern — dropdown on desktop, 2 buttons on mobile
- Use native <details>/<summary> for dropdown — no React state needed
- CSS: dropdown with chevron animation, hover states, breakpoint-based
visibility toggle
- Mobile: keep existing 2-button layout with language labels
- Add Download Resume UI spec: single button with dropdown on desktop,
2 separate buttons on mobile (≥769px breakpoint)
- Mark Version Stamping and Multiple Language Versions as implemented
in both spec files
- Add implementation details for version stamping and i18n in future spec
- Future spec version 0.2.0 — Partial (2/4 implemented)
- Add version stamp footer 'Last updated: YYYY-MM-DD' to PDF
- Implement bilingual support (English + Vietnamese) for resume PDF
- Add Language type and *En optional fields to types
- Add Vietnamese translations to profile, experience, projects data
- resolveField utility for language-aware field resolution
- Language-specific section labels (Experience/Kinh nghiệm, etc.)
- --lang CLI arg: 'en' (default) or 'vi'
- Output: resume.pdf (EN), resume-vi.pdf (VI)
- Update CI workflow to generate and deploy both PDF versions
- Add build:resume-all npm script
- Update UI components (Hero, DownloadResume) for language selection
- Add spec-v2-resume-future.md for deferred enhancements
- Refactor spec-v2-resume-playwright.md (condense implementation notes)
- Fix mobile padding: add media queries for container and hero-content padding
- Add InView wrapper to Hero and About for scroll-triggered animations
- Add Hero parallax effect: photo moves on scroll, content fades out
- Add section background gradient for smooth visual flow between sections
- Unify section containers to container-wide for title alignment
- Add maxWidth wrappers for text-heavy sections (About, Experience, Contact)
- Replace OpenToWorkBadge with RollingTextLink component
- Update nav router links and profile data
- Add spec docs for v2 homepage enhancements and nav rolling text